VOOZH about

URL: https://bugzilla.mozilla.org/show_bug.cgi?id=1599938

⇱ 1599938 - Implement fetch image helper


Closed Bug 1599938 Opened 6 years ago Closed 6 years ago

Implement fetch image helper

Implement fetch image helper
Core
Audio/Video: Playback
unspecified
Unspecified
Unspecified
task
Points:
---
RESOLVED FIXED
RESOLVED
FIXED
mozilla77
Iteration:
---
a11y-review
Accessibility Severity
Performance Impact
Size Estimate
Webcompat Priority
Webcompat Score
Tracking Status
firefox77 --- fixed
Tracking Status
relnote-firefox
thunderbird_esr115
thunderbird_esr140
firefox-esr115
firefox-esr140
firefox-esr153
firefox77
firefox152
firefox153
firefox154
---
[media-feature]
QA Whiteboard:
---
Has STR:
---
Change Request:
---
Bug Flags:
Signature:
None
This bug is publicly visible.

 
Assignee

Description

β€’
6 years ago

We would do that algorithm in chrome process, then select a image for the virtual media control interface.

https://w3c.github.io/mediasession/#fetch-image-algorithm

Could we stop at point 4 and just pass the src URL to the Platform?
I don't know about Mac OS X and Android, but for Windows and Linux we can safely pass such an URL.

That way we could shift all of the responsabilities down to the Platform.
Otherwise we'd need a temporary directory which needs to be cleaned up, maybe even needs a maximum size limit etc.
Specifically for MPRIS, where we would download a file just to build up a file:/// URL again.

This is maybe something to consider there, UNLESS we ever want to display the artwork within the user agent of some sort.

Assignee

Comment 2

β€’
6 years ago

That is just a recommended way, and I think we won't follow that 100%. This bug is filed for a purpose to ensure that we would feed the event source with artwork url.

Priority: P2 β†’ P3
Whiteboard: [media-feature]
Assignee

Comment 3

β€’
6 years ago

Per bug1623971 comment9, we have to fetch the image inside Gecko, instead of letting external framework to load the URL directly.

Assignee: nobody β†’ alwu
Assignee

Updated

β€’
6 years ago
Blocks: 1623971
Assignee

Comment 4

β€’
6 years ago

We will implement a fetch-image-helper in this class, then the platform event source can selecte the preferred-size artwork and get the image by using this helper.

Summary: Implement MediaSession's fetch image algorithm β†’ Implement fetch image helper
Assignee

Comment 6

β€’
6 years ago

The notification of the reply [1] on Phabricator is easily to miss, so I also set NI here. Thank you.

[1] https://phabricator.services.mozilla.com/D69288#2114435

Flags: needinfo?(amarchesini)
Assignee

Updated

β€’
6 years ago
Depends on: 1628929
Assignee

Comment 7

β€’
6 years ago

A quick update, I found a memory leak issue in the imgTool so I spent some time on that, and will solve that issue in bug1628929 before fixing this bug.

Flags: needinfo?(amarchesini)

Comment 8

β€’
6 years ago
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/645373573077 Implement a helper class to fetch image data from URL r=ckerschb,kershaw
Status: NEW β†’ RESOLVED
Closed: 6 years ago
status-firefox77: --- β†’ fixed
Resolution: --- β†’ FIXED
Target Milestone: --- β†’ mozilla77
You need to log in before you can comment on or make changes to this bug.