update main controller to the last tab playing media

👁 Image	Alastor Wu [:alwu] Assignee
	Description • 6 years ago

Since bug1571493, we are able to control media even if we pause it from website directly, not from the media control keys. But it causes another problem which is we lost tracking the last tab playing media, so we should fix this issue in order to always let media control keys to control the last tab playing media.

---

STR.

1. playing media in tab A
2. playing media in another tab B
3. pause media in tab A by directly controlling media from page
4. start media in tabA again by directly controlling media from page
5. press media control key

Expect.
6. tab A should be controlled

Actual.
6. We are controlling tab B, not tab A

👁 Image	BugBot [:suhaib / :marco/ :calixte]
	Comment 1 • 6 years ago

Bugbug thinks this bug is a defect, but please change it back in case of error.

👁 Image	BugBot [:suhaib / :marco/ :calixte]
	Updated • 6 years ago

👁 Image	Alastor Wu [:alwu] Assignee
	Comment 2 • 6 years ago

👁 Image	Alastor Wu [:alwu] Assignee
	Comment 3 • 6 years ago

👁 Image	Alastor Wu [:alwu] Assignee
	Comment 4 • 6 years ago

👁 Image	Alastor Wu [:alwu] Assignee
	Comment 5 • 6 years ago

👁 Image	Alastor Wu [:alwu] Assignee
	Comment 6 • 6 years ago

👁 Image	Alastor Wu [:alwu] Assignee
	Comment 7 • 6 years ago • Edited

Target this bug on this release cycle (Fx76) so mark it as P1.

👁 Image	Alastor Wu [:alwu] Assignee
	Comment 8 • 6 years ago

👁 Image	Alastor Wu [:alwu] Assignee
	Updated • 6 years ago

👁 Image	Alastor Wu [:alwu] Assignee
	Comment 9 • 6 years ago

👁 Image	Pulsebot
	Comment 10 • 6 years ago

Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2511ace99c5e part1 : support `contain` and `length` for LinkedList. r=froydnj https://hg.mozilla.org/integration/autoland/rev/d3f1873dfae9 part2 : replace nsTArray with LinkedList. r=chunmin https://hg.mozilla.org/integration/autoland/rev/1185f5a8daf8 part3 : rename function names to explicitly mention that they're used for main controller. r=chunmin https://hg.mozilla.org/integration/autoland/rev/5241e4aab772 part4 : update main controller when controller changes its playback state to playing. r=chunmin https://hg.mozilla.org/integration/autoland/rev/d17830bcc177 part5 : add test. r=chunmin https://hg.mozilla.org/integration/autoland/rev/3d865b06d46d part6 : modify test. r=chunmin https://hg.mozilla.org/integration/autoland/rev/827124686e24 part7 : revert the workaround in 'browser_media_control_stop_timer.js'. r=chunmin

👁 Image	Noemi Erli[:noemi_erli]
	Comment 11 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/2511ace99c5e
https://hg.mozilla.org/mozilla-central/rev/d3f1873dfae9
https://hg.mozilla.org/mozilla-central/rev/1185f5a8daf8
https://hg.mozilla.org/mozilla-central/rev/5241e4aab772
https://hg.mozilla.org/mozilla-central/rev/d17830bcc177
https://hg.mozilla.org/mozilla-central/rev/3d865b06d46d
https://hg.mozilla.org/mozilla-central/rev/827124686e24

👁 Image	Ryan VanderMeulen [:RyanVM]
	Updated • 6 years ago

👁 Image	BMO Automation
	Updated • 6 years ago