[MediaControl-Linux] Implement `seek` for MPRIS

👁 Image	C.M.Chang[:chunmin] Reporter
	Description • 6 years ago • Edited

We should enable CanSeek for MPRIS if the media is seekable (and media session has an action handler for seekto).

On my Ubuntu 18.04, the seek bar is not enabled by default on the notification bar but it can be tested with a gnome extension like media-player-indicator.

👁 Image	C.M.Chang[:chunmin] Reporter
	Updated • 6 years ago

👁 Image	Marc Streckfuß [:MeFisto94]
	Updated • 5 years ago

👁 Image	Marc Streckfuß [:MeFisto94]
	Comment 1 • 5 years ago

What is the status on the media session side of things for Seeking and Position?

👁 Image	BMO Automation
	Updated • 3 years ago

👁 Image	Martin Stránský [:stransky] (ni? me)
	Updated • 2 years ago

👁 Image	Alex T Assignee
	Comment 2 • 2 years ago

👁 Image	C.M.Chang[:chunmin] Reporter
	Comment 3 • 2 years ago

Hey Alex, thanks for the contribution. We'll review this ASAP.

👁 Image	Alastor Wu [:alwu]
	Comment 4 • 1 year ago

There are some failures for your patches. You will need to fix them before landing the patches. The instruction of requesting permission is here, I'm happy to vouch you for the L1 permission :) If you have any question, feel free to NI me anytime! Thanks!

👁 Image	Alex T Assignee
	Updated • 1 year ago

👁 Image	Alastor Wu [:alwu]
	Comment 5 • 1 year ago

Alex, feel free to let me know when you fix those failures, then I will help you land those patches! Thanks!

👁 Image	Alex T Assignee
	Comment 6 • 1 year ago

(In reply to Alastor Wu [:alwu] from comment #5)

Alex, feel free to let me know when you fix those failures, then I will help you land those patches! Thanks!

I've fixed the failures related to my changes here, I'm unsure how to address the rest of them though.

👁 Image	Alex T Assignee
	Updated • 1 year ago

👁 Image	Martin Stránský [:stransky] (ni? me)
	Updated • 1 year ago

👁 Image	Alastor Wu [:alwu]
	Comment 7 • 1 year ago

Sorry for my late response. I think the only failure we want to address for your patch is TEST-UNEXPECTED-FAIL | dom/media/mediacontrol/tests/browser/browser_media_control_seek.js. I pushed another task to try and also saw same error.

I will leave my suggestion for that part on the Phabricator later.

👁 Image	Pulsebot
	Comment 8 • 1 year ago

Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f9755174e6f6 Implement Seek and SetPosition for MPRIS r=media-playback-reviewers,stransky,alwu,win-reviewers,gstoll

👁 Image	Sandor Molnar[:smolnar]
	Comment 9 • 1 year ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/f9755174e6f6

👁 Image	Martin Stránský [:stransky] (ni? me)
	Updated • 1 year ago

👁 Image	Alastor Wu [:alwu]
	Updated • 1 year ago

👁 Image	C.M.Chang[:chunmin] Reporter
	Updated • 1 year ago

👁 Image	Julien Cristau [:jcristau]
	Updated • 1 year ago