Add startpage.com as search engine to all locales

👁 Image	Ian Neal Assignee
	Description • 5 years ago

Now that startpage.com have provided a new SM specific URL we should add as an option to all locales.

👁 Image	Ian Neal Assignee
	Comment 1 • 5 years ago

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: No startpage.com search engine
Testing completed (on m-c, etc.): 2.53.4
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Tested on en-US, en-GB and pl locales.
At the moment only version which is localised is the Polish one (not sure where the description shows).
Whilst I was there I thought I'd the search engines in alphabetical order, I don't think that it makes any difference but makes it easier to know where to put additional engines.

👁 Image	Ian Neal Assignee
	Comment 2 • 5 years ago

Comment on attachment 9166091 [details] [diff] [review] Add startpage search Let's start with feedback as I want to make sure it behaves as it should on non-English locales / operating systems. At the moment, it seems to pick up the language from the OS rather than the application.

👁 Image	Frank-Rainer Grahl (:frg)
	Comment 3 • 5 years ago

Comment on attachment 9166091 [details] [diff] [review]
Add startpage search

As discussed over irc. The search works but is not location specific at the moment. startpage is investigating. f+ for the moment.

👁 Image	Ian Neal Assignee
	Comment 4 • 5 years ago

Updated to include Startpage in the search order for some more locales

👁 Image	Frank-Rainer Grahl (:frg)
	Comment 5 • 5 years ago

Comment on attachment 9182187 [details] [diff] [review]
Add startpage search v1.1

LGTM

👁 Image	Frank-Rainer Grahl (:frg)
	Updated • 5 years ago

👁 Image	Pulsebot
	Comment 6 • 5 years ago

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/c44151ad33d1
Add startpage.com as search engine to all locales. r=frg

👁 Image	Frank-Rainer Grahl (:frg)
	Updated • 5 years ago

👁 Image	Frank-Rainer Grahl (:frg)
	Comment 7 • 5 years ago

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/c220f4fd01f629c6fa232a068cfe1211a6a4629f