The Title of the Media played is not displayed correctly on soundcloud.com

👁 Image	Rares Doghi, Desktop QA Reporter
	Description • 5 years ago

[Affected versions]
Firefox 82.0b7

[Affected platforms]
Windows 10, Ubuntu

[Steps to reproduce]

1. Open the Firefox browser with a new profile and reach soundcloud.com
2. Perform a Search with "Eminem" and play the first song.
3. Pause/Play using the media key in order to see the Virtual Control interface.
4. Skip Next using the media control key from the keyboard or clicking the skip Next button from the Virtual control interface.

[Expected result]
The correct title of the song should be displayed in the virtual control interface when the user skips songs on soundcloud.com

[Actual result]
Only the first song title is displayed in the Virtual Control interface after the user skips a song.

👁 Image	Rares Doghi, Desktop QA Reporter
	Comment 1 • 5 years ago

I think the severity for this issue should be an S3 since it only happens on Soundcloud and only when you skip to the next song using the media control key or the virtual control interface.

👁 Image	Marcela (Please NI request to Brindusa Tot)
	Comment 2 • 5 years ago

Reproducible on Firefox 82.0b7 on Ubunto 18.04

👁 Image	Alastor Wu [:alwu] Assignee
	Comment 3 • 5 years ago

This is Soundcloud's issue, they didn't change the metadata when we switch to the next song. Therefore, we would keep using the default metadata, which is the title from the first page where sound is playing.

They use MediaSession API, but only set the action handlers for media keys and playback state. I will report this issue to them and ask them why they didn't update the metadata via MediaSession API as well.

👁 Image	Alastor Wu [:alwu] Assignee
	Comment 4 • 5 years ago

I've reported this issue to them via our contact window. Although this issue can also be fixed on our side, we can adjust default metadata when ever the website title changes. However, asking website to set their own metadata is still a better way to do so. I would make this as P3 and implement that when we have time.

👁 Image	Alastor Wu [:alwu] Assignee
	Updated • 5 years ago

👁 Image	Alastor Wu [:alwu] Assignee
	Comment 5 • 5 years ago

👁 Image	Alastor Wu [:alwu] Assignee
	Comment 6 • 5 years ago

Depends on D93670

👁 Image	Pulsebot
	Comment 7 • 5 years ago

Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3d884cf8885c part1 : update default metadata if needed when page title changes. r=chunmin,nika https://hg.mozilla.org/integration/autoland/rev/794802a37466 part2 : add a test case for updating default metadata when page title changes. r=chunmin

👁 Image	Andreea Pavel [:apavel]
	Comment 8 • 5 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/3d884cf8885c
https://hg.mozilla.org/mozilla-central/rev/794802a37466

👁 Image	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 5 years ago

What's the status of this issue on Beta/Release? Is this feature disabled there?

👁 Image	Alastor Wu [:alwu] Assignee
	Comment 10 • 5 years ago

This feature is already on by default on Fx82 Release, and I will ask for an uplift to fix this in Fx83 Beta as well. Thank for a remind.

👁 Image	Alastor Wu [:alwu] Assignee
	Comment 11 • 5 years ago

Comment on attachment 9181824 [details]
Bug 1669434 - part1 : update default metadata if needed when page title changes.

Beta/Release Uplift Approval Request

• User impact if declined: The wrong media title would be shown on the virtual control interface, when users are playing music on Soundcloud. (and probably on other websites as well)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment0.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): These patches didn't introduce any new feature or change the architecture, we would simply update the media controller interface again if a controlled page changes its title. Also come with an automation test.
• String changes made/needed: No

👁 Image	Alastor Wu [:alwu] Assignee
	Updated • 5 years ago

👁 Image	Brindusa Tot, DTE
	Updated • 5 years ago

👁 Image	Rares Doghi, Desktop QA Reporter
	Comment 12 • 5 years ago

This issue is Verified as fixed in our latest Nightly build 84.0a1 (2020-10-26) on Windows 10 and Ubuntu 20.04.

👁 Image	Pascal Chevrel (relman team) -> :pascalc
	Comment 13 • 5 years ago

Comment on attachment 9181824 [details]
Bug 1669434 - part1 : update default metadata if needed when page title changes.

Has tests and was verified on Nightly by our QA, this was set as P3/S3 when the feature was still disabled and it only affected Soundcloud, but this is now enabled on the release channel and probably affects other sites so let's take it in the next 83 beta 5, thanks.

👁 Image	Pascal Chevrel (relman team) -> :pascalc
	Updated • 5 years ago

👁 Image	Ryan VanderMeulen [:RyanVM]
	Comment 14 • 5 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/a2d8185dd2d3
https://hg.mozilla.org/releases/mozilla-beta/rev/849ac6970ef6

👁 Image	Rares Doghi, Desktop QA Reporter
	Comment 15 • 5 years ago

This issue is Verified as fixed in Beta 83.0b5 on Ubuntu 20.04 and Windows 10.