Let non-native theme ride to Beta and Release (in 89)

👁 Image	Chris Peterson [:cpeterson] Reporter
	Description • 5 years ago

We currently plan to let non-native theme ride the trains in 89. We don't need to do anything for this in 88 Nightly or Beta (though the Fission team might enable non-native theme early for macOS users in a Fission Beta experiment in 88 Beta).

👁 Image	Chris Peterson [:cpeterson] Reporter
	Comment 1 • 5 years ago

This bug no longer needs to block the Fission M7a Beta experiment. In bug 1697055, kmag enabled non-native theme for users in the Fission experiment.

Non-native theme will ship in 89, well before our Fission M8 Release experiment.

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Comment 2 • 5 years ago

Please ni? me on bugs you actually want me to take, otherwise I might miss them :)

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Comment 3 • 5 years ago

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Comment 4 • 5 years ago

ni? for https://phabricator.services.mozilla.com/D109555#3559654. In particular, the reasoning is that if something would cause us to turn off nnt by default on release, we probably would also want to do that for fissuon users? But again I can leave the code if you want.

👁 Image	Pulsebot
	Comment 5 • 5 years ago

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cd0820378114 Let non-native-theme ride the trains in Firefox 89. r=cpeterson,mstange

👁 Image	Chris Peterson [:cpeterson] Reporter
	Comment 6 • 5 years ago

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

ni? for https://phabricator.services.mozilla.com/D109555#3559654. In particular, the reasoning is that if something would cause us to turn off nnt by default on release, we probably would also want to do that for fissuon users? But again I can leave the code if you want.

LGMT. No need to keep the special case for Fission.

👁 Image	Cristian Brindusan [:cbrindusan]
	Comment 7 • 5 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/cd0820378114

👁 Image	Pascal Chevrel (relman team) -> :pascalc
	Updated • 5 years ago

👁 Image	Pascal Chevrel (relman team) -> :pascalc
	Comment 8 • 5 years ago

Hi Emilio, does it require a mention in our 89 release notes? If it does, could you request it please? Is that on all platforms?
Thanks

👁 Image	Chris Peterson [:cpeterson] Reporter
	Comment 9 • 5 years ago

@ Emilio, feel free to suggest any changes to my proposed wording below!

Release Note Request (optional, but appreciated)

[Why is this notable]: The non-native theme (for web form controls) will be visible to users. Also, it may cause webcompat issues if web pages make assumptions about the dimensions or styling of form controls.

[Suggested wording]: I think this feature is relevant for the release note's "New" section.

Introducing a non-native implementation of web form controls, which delivers a new modern design and some improvements to page load performance. Watch for layout bugs in web pages that make assumptions about the dimensions or styling of form controls.

[Links (documentation, blog post, etc)]: Not at this time. I'm talking with Proton PM about maybe mentioning non-native theme in a Proton UX blog post.

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Comment 10 • 5 years ago

Sounds good, thanks Chris.

👁 Image	Pascal Chevrel (relman team) -> :pascalc
	Comment 11 • 5 years ago

Added to nightly release notes with the suggested wording, thanks

👁 Image	Chris Peterson [:cpeterson] Reporter
	Comment 14 • 5 years ago

Pascal, the non-native theme is also relevant for Android's release notes for 89.0a1. Do I need to flag this bug in a special way to add the release note for both desktop and Android?

I see our release note on 89.0a1's Desktop Nightly release notes, but I don't see a page for Android Nightly's release notes:

https://www.mozilla.org/en-US/firefox/89.0a1/releasenotes/

btw, the Android Beta release notes are from the ancient Fennec 68.7beta and should probably be taken down:

https://www.mozilla.org/en-US/firefox/android/68.7beta/releasenotes/

👁 Image	Pascal Chevrel (relman team) -> :pascalc
	Comment 15 • 5 years ago

(In reply to Chris Peterson [:cpeterson] from comment #14)

Pascal, the non-native theme is also relevant for Android's release notes for 89.0a1. Do I need to flag this bug in a special way to add the release note for both desktop and Android?

I see our release note on 89.0a1's Desktop Nightly release notes, but I don't see a page for Android Nightly's release notes:

https://www.mozilla.org/en-US/firefox/89.0a1/releasenotes/

btw, the Android Beta release notes are from the ancient Fennec 68.7beta and should probably be taken down:

https://www.mozilla.org/en-US/firefox/android/68.7beta/releasenotes/

I am not sure who owns Android release notes these days, I'll investigate.

👁 Image	Daniel Holbert [:dholbert]
	Updated • 5 years ago

👁 Image	Pascal Chevrel (relman team) -> :pascalc
	Comment 16 • 5 years ago

This is in our 89 beta notes and should be in our final notes managed by our comms team.

👁 Image	Alice0775 White
	Updated • 2 years ago

👁 Image	Mathew Hodson
	Updated • 1 year ago