Fix some tests related to content-visibility so that it can be enabled

👁 Image	Daniel Holbert [:dholbert] Assignee
	Description • 3 years ago

See bug 1820058 comment 3; this bug is to fix up the tests mentioned there, to avoid unexpected test failures when content-visibility is enabled.

👁 Image	Daniel Holbert [:dholbert] Assignee
	Comment 1 • 3 years ago

We had 'invisible', but the correct keyword (and what we have implemented) is
'hidden'.

See list of values in the spec at
https://drafts.csswg.org/css-contain-2/#content-visibility

👁 Image	Daniel Holbert [:dholbert] Assignee
	Comment 2 • 3 years ago

Depends on D172135

👁 Image	Daniel Holbert [:dholbert] Assignee
	Comment 3 • 3 years ago

Depends on D172136

👁 Image	Daniel Holbert [:dholbert] Assignee
	Comment 4 • 3 years ago

Try run (with another patch to pref content-visibility on, demonstrating that we don't need any other fixups here, I think):
https://treeherder.mozilla.org/jobs?repo=try&revision=76674b8231c98c7743f6aca7016a0d5a76d9b44b

Try run without the pref flip, to make sure I didn't inadvertently build in some expectation that the pref is enabled:
https://treeherder.mozilla.org/jobs?repo=try&revision=6cfe208522f985ac344b3322bd44bb6d0753c910
(This one just started, I'll be sure it looks OK before landing.)

👁 Image	Phabricator Automation
	Updated • 3 years ago

👁 Image	Pulsebot
	Comment 5 • 3 years ago

Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e2672521d0ac part 1: Correct an obsolete 'content-visibility' keyword in the property_database.js file used by various mochitests. r=emilio https://hg.mozilla.org/integration/autoland/rev/116ca9c61aec part 2: Explicitly enable 'content-visibility' about:config pref for some WPT tests that use it, and update their expectations. r=emilio https://hg.mozilla.org/integration/autoland/rev/fe4dcfdb64df part 3: Update a DOM test to make it aware of ContentVisibilityAutoStateChangeEvent. r=emilio

👁 Image	Iulian Moraru
	Comment 6 • 3 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/e2672521d0ac
https://hg.mozilla.org/mozilla-central/rev/116ca9c61aec
https://hg.mozilla.org/mozilla-central/rev/fe4dcfdb64df