Remove a bunch of dead prefs from mobile.js

👁 Image	Gregory Pappas [:gregp] Assignee
	Description • 3 years ago

Noticed that mobile.js has multiple dozens of prefs that just don't do anything.

👁 Image	Gregory Pappas [:gregp] Assignee
	Comment 1 • 3 years ago

Depends on D180559

👁 Image	Phabricator Automation
	Updated • 3 years ago

👁 Image	Gregory Pappas [:gregp] Assignee
	Comment 2 • 3 years ago

Depends on D180594

👁 Image	Gregory Pappas [:gregp] Assignee
	Comment 3 • 3 years ago

Depends on D180595

👁 Image	Gregory Pappas [:gregp] Assignee
	Comment 4 • 3 years ago

Depends on D180596

👁 Image	Gregory Pappas [:gregp] Assignee
	Comment 5 • 3 years ago

Depends on D180597

👁 Image	Gregory Pappas [:gregp] Assignee
	Comment 6 • 3 years ago

Depends on D180598

👁 Image	Gregory Pappas [:gregp] Assignee
	Comment 7 • 3 years ago

Depends on D180599

👁 Image	Gregory Pappas [:gregp] Assignee
	Comment 8 • 3 years ago

Depends on D180600

👁 Image	Gregory Pappas [:gregp] Assignee
	Comment 9 • 3 years ago

Depends on D180601

👁 Image	Pulsebot
	Comment 10 • 3 years ago

Pushed by gp3033@protonmail.com: https://hg.mozilla.org/integration/autoland/rev/e6bb4d815f7c Remove unused browser.* prefs r=geckoview-reviewers,calu https://hg.mozilla.org/integration/autoland/rev/2af6113433c9 Remove unused network.* prefs r=geckoview-reviewers,m_kato https://hg.mozilla.org/integration/autoland/rev/6b289a4b002b Remove unused privacy.* prefs r=geckoview-reviewers,calu https://hg.mozilla.org/integration/autoland/rev/5c7a9f173117 Remove unused app.* prefs r=geckoview-reviewers,m_kato https://hg.mozilla.org/integration/autoland/rev/e5f493435a3a Remove unused accessibility.* prefs r=geckoview-reviewers,eeejay,m_kato https://hg.mozilla.org/integration/autoland/rev/51da430b2a24 Remove unused device.* prefs r=geckoview-reviewers,m_kato https://hg.mozilla.org/integration/autoland/rev/c0e6563d21b3 Remove unused media.* prefs r=geckoview-reviewers,m_kato https://hg.mozilla.org/integration/autoland/rev/3d003c94d27c Remove unused extensions.* prefs r=geckoview-reviewers,calu https://hg.mozilla.org/integration/autoland/rev/ad499e552dc4 Remove unused signon.* prefs r=geckoview-reviewers,m_kato

👁 Image	Iulian Moraru
	Comment 11 • 3 years ago

Backed out for causing xpcshell failures on test_UpdateUtils_updatechannel.js.

• Push with failures

• Failure log

• Backout link

[task 2023-06-17T19:53:31.080Z] 19:53:31 INFO - TEST-START | toolkit/modules/tests/xpcshell/test_UpdateUtils_updatechannel.js
[task 2023-06-17T19:53:31.121Z] 19:53:31 INFO - adb launch_application: am startservice -W -n 'org.mozilla.geckoview.test_runner/org.mozilla.geckoview.test_runner.XpcshellTestRunnerService$i0' -a android.intent.action.MAIN --es env0 XPCOM_DEBUG_BREAK=stack-and-abort --es env1 MOZ_CRASHREPORTER=1 --es env2 MOZ_CRASHREPORTER_NO_REPORT=1 --es env3 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env4 MOZ_DEVELOPER_REPO_DIR=/builds/worker/checkouts/gecko --es env5 MOZ_DEVELOPER_OBJ_DIR=/builds/worker/workspace/obj-build --es env6 MOZ_DISABLE_CONTENT_SANDBOX=1 --es env7 MOZ_FETCHES_DIR=/builds/worker/fetches --es env8 MOZ_DISABLE_SOCKET_PROCESS=1 --es env9 LD_LIBRARY_PATH=/data/local/tmp/test_root/xpcb --es env10 MOZ_LINKER_CACHE=/data/local/tmp/test_root/xpcb --es env11 GRE_HOME=/data/local/tmp/test_root/xpcb --es env12 XPCSHELL_TEST_PROFILE_DIR=/data/local/tmp/test_root/xpc/p/f797ba1a-b9a9-45a5-aae3-fd486a4c205b --es env13 HOME=/data/local/tmp/test_root/xpc/p --es env14 XPCSHELL_TEST_TEMP_DIR=/data/local/tmp/test_root/xpc/tmp/0c7b4176-7f9d-47b3-b624-76126329013e --es env15 MOZ_ANDROID_DATA_DIR=/data/local/tmp/test_root/xpcb --es env16 MOZ_IN_AUTOMATION=1 --es env17 MOZ_ANDROID_CPU_ABI=x86_64 --es env18 MOZHTTP2_PORT=39772 --es env19 MOZNODE_EXEC_PORT=39808 --es env20 MOZHTTP3_ECH= --es env21 TMPDIR=/data/local/tmp/test_root/xpc/p/f797ba1a-b9a9-45a5-aae3-fd486a4c205b --es env22 XPCSHELL_MINIDUMP_DIR=/data/local/tmp/test_root/xpc/minidumps/f797ba1a-b9a9-45a5-aae3-fd486a4c205b --es arg0 -g --es arg1 /data/local/tmp/test_root/xpcb --es arg2 --greomni --es arg3 /data/local/tmp/test_root/xpcb/geckoview-test_runner.apk --es arg4 -m --es arg5 -e --es arg6 'const _HEAD_JS_PATH = "/data/local/tmp/test_root/xpc/head.js";' --es arg7 -e --es arg8 'const _MOZINFO_JS_PATH = "/data/local/tmp/test_root/xpc/p/f797ba1a-b9a9-45a5-aae3-fd486a4c205b/mozinfo.json";' --es arg9 -e --es arg10 'const _PREFS_FILE = "/data/local/tmp/test_root/xpc/user.js";' --es arg11 -e --es arg12 'const _TESTING_MODULES_DIR = "/data/local/tmp/test_root/xpc/m";' --es arg13 -f --es arg14 /data/local/tmp/test_root/xpc/head.js --es arg15 -e --es arg16 'const _HEAD_FILES = ["/data/local/tmp/test_root/xpc/toolkit/modules/tests/xpcshell/head.js"];' --es arg17 -e --es arg18 'const _JSDEBUGGER_PORT = 0;' --es arg19 -e --es arg20 'const _TEST_CWD = "/data/local/tmp/test_root/xpc/toolkit/modules/tests/xpcshell";' --es arg21 -e --es arg22 'const _TEST_FILE = ["test_UpdateUtils_updatechannel.js"];' --es arg23 -e --es arg24 'const _TEST_NAME = "toolkit/modules/tests/xpcshell/test_UpdateUtils_updatechannel.js";' --es arg25 -e --es arg26 '_execute_test(); quit(0);' --ez use_multiprocess True --es out_file /data/local/tmp/test_root/xpc/logs/xpcshell-57eab1e3-fb71-4fbe-8f8f-3fd9049198d7.log
[task 2023-06-17T19:53:31.354Z] 19:53:31 INFO - remotexpcshelltests.py | toolkit/modules/tests/xpcshell/test_UpdateUtils_updatechannel.js | 11251 | Launched Test App
[task 2023-06-17T19:53:31.652Z] 19:53:31 INFO - remotexpcshelltests.py | toolkit/modules/tests/xpcshell/test_UpdateUtils_updatechannel.js | 11251 | Application ran for: 0:00:00.572179
[task 2023-06-17T19:53:31.713Z] 19:53:31 WARNING - TEST-UNEXPECTED-FAIL | toolkit/modules/tests/xpcshell/test_UpdateUtils_updatechannel.js | xpcshell return code: 0
[task 2023-06-17T19:53:31.713Z] 19:53:31 INFO - TEST-INFO took 634ms
[task 2023-06-17T19:53:31.713Z] 19:53:31 INFO - >>>>>>>
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - running event loop
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - toolkit/modules/tests/xpcshell/test_UpdateUtils_updatechannel.js | Starting test_updatechannel
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - (xpcshell/head.js) | test test_updatechannel pending (2)
[task 2023-06-17T19:53:31.714Z] 19:53:31 WARNING - TEST-UNEXPECTED-FAIL | toolkit/modules/tests/xpcshell/test_UpdateUtils_updatechannel.js | test_updatechannel - [test_updatechannel : 24] "default" == "undefined"
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - test_UpdateUtils_updatechannel.js:test_updatechannel:24
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - /data/local/tmp/test_root/xpc/head.js:_run_next_test/<:1747
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - /data/local/tmp/test_root/xpc/head.js:_run_next_test:1747
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - /data/local/tmp/test_root/xpc/head.js:run:796
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - /data/local/tmp/test_root/xpc/head.js:_do_main:237
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - /data/local/tmp/test_root/xpc/head.js:_execute_test:584
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - -e:null:1
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - exiting test
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2023-06-17T19:53:31.714Z] 19:53:31 INFO - Unexpected exception NS_ERROR_ABORT:
[task 2023-06-17T19:53:31.715Z] 19:53:31 INFO - _abort_failed_test@/data/local/tmp/test_root/xpc/head.js:857:20
[task 2023-06-17T19:53:31.715Z] 19:53:31 INFO - do_report_result@/data/local/tmp/test_root/xpc/head.js:966:5
[task 2023-06-17T19:53:31.715Z] 19:53:31 INFO - Assert<@/data/local/tmp/test_root/xpc/head.js:70:21
[task 2023-06-17T19:53:31.715Z] 19:53:31 INFO - Assert.prototype.report@resource://testing-common/Assert.sys.mjs:240:10
[task 2023-06-17T19:53:31.715Z] 19:53:31 INFO - equal@resource://testing-common/Assert.sys.mjs:282:8
[task 2023-06-17T19:53:31.715Z] 19:53:31 INFO - test_updatechannel@test_UpdateUtils_updatechannel.js:24:10
[task 2023-06-17T19:53:31.715Z] 19:53:31 INFO - _run_next_test/<@/data/local/tmp/test_root/xpc/head.js:1747:22
[task 2023-06-17T19:53:31.715Z] 19:53:31 INFO - _run_next_test@/data/local/tmp/test_root/xpc/head.js:1747:38
[task 2023-06-17T19:53:31.715Z] 19:53:31 INFO - run@/data/local/tmp/test_root/xpc/head.js:796:9
[task 2023-06-17T19:53:31.715Z] 19:53:31 INFO - _do_main@/data/local/tmp/test_root/xpc/head.js:237:6
[task 2023-06-17T19:53:31.715Z] 19:53:31 INFO - _execute_test@/data/local/tmp/test_root/xpc/head.js:584:5
[task 2023-06-17T19:53:31.715Z] 19:53:31 INFO - @-e:1:1
[task 2023-06-17T19:53:31.715Z] 19:53:31 INFO - exiting test
[task 2023-06-17T19:53:31.715Z] 19:53:31 INFO - <<<<<<<
[task 2023-06-17T19:53:31.779Z] 19:53:31 INFO - Cleaning up profile for /builds/worker/workspace/build/tests/xpcshell/tests/toolkit/modules/tests/xpcshell/test_UpdateUtils_updatechannel.js folder: /data/local/tmp/test_root/xpc/p/f797ba1a-b9a9-45a5-aae3-fd486a4c205b
[task 2023-06-17T19:53:31.956Z] 19:53:31 INFO - TEST-START | netwerk/test/unit/test_http2-proxy.js

👁 Image	Gregory Pappas [:gregp] Assignee
	Comment 12 • 3 years ago

Thanks, working on it.

👁 Image	Pulsebot
	Comment 13 • 3 years ago

Pushed by gp3033@protonmail.com: https://hg.mozilla.org/integration/autoland/rev/6998c59a147a Remove unused browser.* prefs r=geckoview-reviewers,calu https://hg.mozilla.org/integration/autoland/rev/8b7147441be6 Remove unused network.* prefs r=geckoview-reviewers,m_kato https://hg.mozilla.org/integration/autoland/rev/d434e683e7fe Remove unused privacy.* prefs r=geckoview-reviewers,calu https://hg.mozilla.org/integration/autoland/rev/e2e89843641e Remove unused app.* prefs r=geckoview-reviewers,m_kato https://hg.mozilla.org/integration/autoland/rev/458cab830133 Remove unused accessibility.* prefs r=geckoview-reviewers,eeejay,m_kato https://hg.mozilla.org/integration/autoland/rev/16f284b3d52b Remove unused device.* prefs r=geckoview-reviewers,m_kato https://hg.mozilla.org/integration/autoland/rev/ee4e1fab5ea7 Remove unused media.* prefs r=geckoview-reviewers,m_kato https://hg.mozilla.org/integration/autoland/rev/eac996db49d2 Remove unused extensions.* prefs r=geckoview-reviewers,calu https://hg.mozilla.org/integration/autoland/rev/72d2cda2651d Remove unused signon.* prefs r=geckoview-reviewers,m_kato

👁 Image	Sandor Molnar[:smolnar]
	Comment 14 • 2 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/6998c59a147a
https://hg.mozilla.org/mozilla-central/rev/8b7147441be6
https://hg.mozilla.org/mozilla-central/rev/d434e683e7fe
https://hg.mozilla.org/mozilla-central/rev/e2e89843641e
https://hg.mozilla.org/mozilla-central/rev/458cab830133
https://hg.mozilla.org/mozilla-central/rev/16f284b3d52b
https://hg.mozilla.org/mozilla-central/rev/ee4e1fab5ea7
https://hg.mozilla.org/mozilla-central/rev/eac996db49d2
https://hg.mozilla.org/mozilla-central/rev/72d2cda2651d

👁 Image	Gregory Pappas [:gregp] Assignee
	Updated • 5 months ago