Closed
Bug 1962246
Opened 1 year ago
Closed 1 year ago
Tidy up install-plugin dialog for cZ
Tidy up install-plugin dialog for cZ
Bug Flags:
|
8.14 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
| Assignee | |
Description•1 year ago
|
Lots of unused code / old ways of doing things in the install-plugin dialog e.g. hookEvent
Whilst here reformatted the XUL
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.22pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9480671 -
Flags: review?(frgrahl)
Attachment #9480671 -
Flags: approval-comm-release?
Updated•1 year ago
|
Comment 2•1 year ago
|
Comment on attachment 9480671 [details] [diff] [review]
1962246-irc-install-plugin-25322.patch
lgtm r/a+
Attachment #9480671 -
Flags: review?(frgrahl)
Attachment #9480671 -
Flags: review+
Attachment #9480671 -
Flags: approval-comm-release?
Attachment #9480671 -
Flags: approval-comm-release+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/dcf4a0ddb029
Tidy up install-plugin dialog for cZ. r=frg DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Comment 4•7 months ago
|
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/ef33b8451f822249d2845929b38c787828671963
Tidy up install-plugin dialog for cZ. r=frg a=frg
You need to log in
before you can comment on or make changes to this bug.