VOOZH about

URL: https://bugzilla.mozilla.org/show_bug.cgi?id=1971036

⇱ 1971036 - Fix advanceKeyboardFocus in cZ


Closed Bug 1971036 Opened 1 year ago Closed 10 months ago

Fix advanceKeyboardFocus in cZ

Fix advanceKeyboardFocus in cZ
SeaMonkey
Chat
Trunk
All
All
defect
RESOLVED FIXED
RESOLVED
FIXED
Future
Tracking Status
seamonkey2.53 + fixed
Tracking Status
seamonkey2.53
seamonkey2.57esr
---
SM2.53.22
QA Whiteboard:
---
Change Request:
---
Bug Flags:
Signature:
None
This bug is publicly visible.

 
Assignee

Description

1 year ago

I've spotted that the function advanceKeyboardFocus is comparing against a non-existant variable (userList) so this should be fixed.
Whilst here tidy up some other code that looks up the element "user-list" which is already stored in client.list so we should just use that instead.

Assignee

Comment 1

1 year ago

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: advancing focus via F6 doesn't work properly
Testing completed (on m-c, etc.): 2.53.22pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9493473 - Flags: review?(frgrahl)
Attachment #9493473 - Flags: approval-comm-release?
Whiteboard: SM2.53.22

Comment on attachment 9493473 [details] [diff] [review]
1971036-irc-fix-userList-25322.patch

LGTM r/a+

Unrelated: Seems only isMac is used in handlers.js. Room for a later cleanup.

Attachment #9493473 - Flags: review?(frgrahl)
Attachment #9493473 - Flags: review+
Attachment #9493473 - Flags: approval-comm-release?
Attachment #9493473 - Flags: approval-comm-release+

Comment 3

10 months ago

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/f473a6263690
Fix advanceKeyboardFocus in cZ. r=frg DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.