Null check this.browser in context menu
|
1.08 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
| Assignee | |
Description•1 year ago
|
Potentially this.browser could be null in a context menu, so we should check it before trying to look at properties / attributes.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: context menu is not properly initialised
Testing completed (on m-c, etc.): 2.53.22pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Updated•10 months ago
|
Comment 2•10 months ago
|
Comment on attachment 9493475 [details] [diff] [review]
1971038-context-browser-null-25322.patch
LGTM r/a+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/1c858aa5f95e
Null check this.browser in context menu. r=frg DONTBUILD
Comment 4•7 months ago
|
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/91d3ef0decf68e38f2e07f34b4e6a9402ffcde33
Null check this.browser in context menu. r=frg a=frg