VOOZH about

URL: https://bugzilla.mozilla.org/show_bug.cgi?id=1973397

⇱ 1973397 - Move scrollToElement function from output-window.js to static.js in cZ


Closed Bug 1973397 Opened 1 year ago Closed 10 months ago

Move scrollToElement function from output-window.js to static.js in cZ

Move scrollToElement function from output-window.js to static.js in cZ
SeaMonkey
Chat
Trunk
All
All
RESOLVED FIXED
RESOLVED
FIXED
Future
Tracking Status
seamonkey2.53 + fixed
Tracking Status
seamonkey2.53
seamonkey2.57esr
---
SM2.53.22
QA Whiteboard:
---
Change Request:
---
Bug Flags:
Signature:
None
This bug is publicly visible.

 
Assignee

Description

1 year ago

Move the scrollToElement function from output-window.js to static.js and tidy up some of the code.

Assignee

Comment 1

1 year ago

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.22pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9496176 - Flags: review?(frgrahl)
Attachment #9496176 - Flags: approval-comm-release?
Assignee

Comment 2

11 months ago

Rebased patch following changes to patch for bug 1973395 and some tidying up of code.

Attachment #9496176 - Attachment is obsolete: true
Attachment #9496176 - Flags: review?(frgrahl)
Attachment #9496176 - Flags: approval-comm-release?
Attachment #9497902 - Flags: review?(frgrahl)
Attachment #9497902 - Flags: approval-comm-release?
Whiteboard: SM2.53.22

Comment on attachment 9497902 [details] [diff] [review]
1973397-irc-move-scrollTo-v1_1-25322.patch

LGTM r/a+

Attachment #9497902 - Flags: review?(frgrahl)
Attachment #9497902 - Flags: review+
Attachment #9497902 - Flags: approval-comm-release?
Attachment #9497902 - Flags: approval-comm-release+

Comment 4

10 months ago

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/53fda220d1db
Move scrollToElement function from output-window.js to static.js in cZ. r=frg DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/e8c86ba9fe01ca4560055a632188fdf555d64835
Move scrollToElement function from output-window.js to static.js in cZ. r=frg a=frg

Target Milestone: --- → Future
You need to log in before you can comment on or make changes to this bug.