getAllDuplicateTabsToClose is quadratic on the number of tabs

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Description • 4 months ago

See bug 1820171 comment 14 for a profile that shows massive time spent there just doing url comparisons.

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Comment 1 • 4 months ago

No behavior change.

👁 Image	Phabricator Automation
	Updated • 4 months ago

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Comment 2 • 4 months ago

On by default for quite a while.

👁 Image	Dão Gottwald [:dao]
	Updated • 4 months ago

👁 Image	Oriol Brufau [:Oriol]
	Updated • 4 months ago

👁 Image	Pulsebot
	Comment 3 • 4 months ago

Pushed by ealvarez@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/880bde06807a https://hg.mozilla.org/integration/autoland/rev/db74d15e5f2a Make getAllDuplicateTabsToClose faster with tons of tabs. r=dao,chutten,tabbrowser-reviewers https://github.com/mozilla-firefox/firefox/commit/409e9501b8a9 https://hg.mozilla.org/integration/autoland/rev/4ea392bd4ea9 Remove duplicate tabs pref. r=tabbrowser-reviewers,jsudiaman

👁 Image	Sandor Molnar[:smolnar]
	Comment 4 • 4 months ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/db74d15e5f2a
https://hg.mozilla.org/mozilla-central/rev/4ea392bd4ea9

👁 Image	Brindusa Tot, DTE
	Updated • 3 months ago