VOOZH about

URL: https://bugzilla.mozilla.org/show_bug.cgi?id=2018257

⇱ 2018257 - Temporarily revert changes which cleaned up messages in the ContentSearchParent


Closed Bug 2018257 Opened 3 months ago Closed 3 months ago

Temporarily revert changes which cleaned up messages in the ContentSearchParent

Temporarily revert changes which cleaned up messages in the ContentSearchParent
Firefox
Search
unspecified
Unspecified
Unspecified
task
Points:
---
RESOLVED FIXED
RESOLVED
FIXED
150 Branch
Iteration:
---
a11y-review
Accessibility Severity
Performance Impact
Webcompat Priority
Webcompat Score
Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox148 --- unaffected
firefox149 + fixed
firefox150 + fixed
Tracking Status
relnote-firefox
firefox-esr115
firefox-esr140
firefox-esr153
firefox148
firefox149
firefox150
firefox152
firefox153
firefox154
---
QA Whiteboard:
[search] [qa-triage-done-c150/b149]
Has STR:
---
Change Request:
---
Bug Flags:
Signature:
None
This bug is publicly visible.

 

These were removed in bug 2003294, but for bug 2017049 we may need to restore them.

This will make it easier for the work in bug 2017049.

This reverts commit aca14b8e67152e57d223b50bdf3dba99f4324d9e.

This will make it easier for the work in bug 2017049.

This reverts commit 8943ca67c923f392cbd8321c402ac4f434cd9a62.

Attachment #9546854 - Attachment description: WIP: Bug 2018257 - Undo simplification changes in ContentSearchParent that were done in bug 2003294. → Bug 2018257 - Undo simplification changes in ContentSearchParent that were done in bug 2003294. r?#search-reviewers!
Attachment #9546855 - Attachment description: WIP: Bug 2018257 - Restore messages from ContentSearchParent that were removed in bug 2003294 and used for the non-handoff searchbar. → Bug 2018257 - Restore messages from ContentSearchParent that were removed in bug 2003294 and used for the non-handoff searchbar. r?#search-reviewers!

[Tracking Requested - why for this release]:

We removed support for the non-handoff version of the New Tab search input based on the fact that it was a non-default, non-exposed, and essentially unsupported configuration - and the number of clients making searches using that mode was so small (see bug 1999334 comment 5). We've now gathered enough evidence and feedback to suggest that a significant portion of these users was using the unsupported non-handoff settings for accessibility reasons, and that the handoff mode is not accessible for them. PM has decided to let this preference limp along for a few releases further until we can complete the inline search input experience (MCAB), to reduce user-pain.

We're going to see if we can get this reversion / revival of the pref into the next planned dot release after Firefox 148 hits the release channel.

Comment 4

3 months ago
Pushed by csabou@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ae73f4663611 https://hg.mozilla.org/mozilla-central/rev/4de45c6a16d1 Undo simplification changes in ContentSearchParent that were done in bug 2003294. r=search-reviewers,mcheang https://github.com/mozilla-firefox/firefox/commit/4cb1ee949645 https://hg.mozilla.org/mozilla-central/rev/63c0c4214451 Restore messages from ContentSearchParent that were removed in bug 2003294 and used for the non-handoff searchbar. r=search-reviewers,mcheang

Comment 5

3 months ago
bugherder
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch

This will make it easier for the work in bug 2017049.

This undoes the work in commit aca14b8e67152e57d223b50bdf3dba99f4324d9e, accounting for changes made since.

Original Revision: https://phabricator.services.mozilla.com/D284294

Attachment #9547637 - Flags: approval-mozilla-beta?

This will make it easier for the work in bug 2017049.

This undoes the work in commit 8943ca67c923f392cbd8321c402ac4f434cd9a62, accounting for changes made since.

Original Revision: https://phabricator.services.mozilla.com/D284295

Attachment #9547638 - Flags: approval-mozilla-beta?

:mconley, could you add a release uplift request when you have a moment?
We can aim to include it in the Fx148 planned dot release.

Flags: needinfo?(mconley)

It turns out these patches do not need to be uplifted. Bug 2003294, which removed the code that this bug puts back landed in 149, which is currently in Beta.

Flags: needinfo?(mconley)
Attachment #9547637 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9547638 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [search] [qa-triage-done-c150/b149]
No longer depends on: 2003294
See Also: → 2003294

@Mathew: It is a dependency, as this wouldn't have been necessary.

You need to log in before you can comment on or make changes to this bug.