VOOZH about

URL: https://bugzilla.mozilla.org/show_bug.cgi?id=2036482

⇱ 2036482 - [Cocoa] Have PointerLock use native APIs


Closed Bug 2036482 Opened 1 month ago Closed 1 month ago

[Cocoa] Have PointerLock use native APIs

[Cocoa] Have PointerLock use native APIs
Core
Widget: Cocoa
unspecified
Unspecified
Unspecified
enhancement
Points:
---
RESOLVED FIXED
RESOLVED
FIXED
152 Branch
Iteration:
---
a11y-review
Accessibility Severity
Performance Impact
Size Estimate
Webcompat Priority
Webcompat Score
Tracking Status
firefox151 --- fixed
firefox152 --- fixed
Tracking Status
relnote-firefox
thunderbird_esr115
thunderbird_esr140
firefox-esr115
firefox-esr140
firefox-esr153
firefox151
firefox152
firefox153
firefox154
---
QA Whiteboard:
---
Has STR:
---
Change Request:
---
Bug Flags:
Signature:
None
This bug is publicly visible.

 
Assignee

Description

1 month ago
No description provided.
Severity: -- → S3
Attachment #9575979 - Attachment description: WIP: Bug 2036482 - [Cocoa] Have PointerLock use native APIs; → Bug 2036482 - [Cocoa] Have PointerLock use native APIs;
Assignee: nobody → echen
Status: NEW → ASSIGNED
Assignee

Updated

1 month ago
Blocks: 1829401
Assignee

Comment 2

1 month ago

Hi Jens, this is the pre-requirement of implementing pointer lock unadjuestedmovement support on macOS (bug 1829401).
Could you help to find someone reviewing widget changes? I flag :mstange as well since he has reviewed some patches of bug 1829401, but I am not sure if he would review this as well or maybe someone from your team can help. Thanks!

Flags: needinfo?(jstutte)
Assignee

Comment 3

1 month ago

nm, mstange has reviewed. :)

Flags: needinfo?(jstutte)

Comment 5

1 month ago
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9ea37a9b83fa https://hg.mozilla.org/integration/autoland/rev/9e9ea9f30d31 Revert "Bug 2036482 - [Cocoa] Have PointerLock use native APIs; r=smaug,mstange,mac-reviewers" for causing failures at nsCocoaWindow.

(In reply to Edgar Chen [:edgar] from comment #3)

nm, mstange has reviewed. :)

Yeah, :spohl told me he was faster...

Assignee

Comment 8

1 month ago

(In reply to Atila Butkovits from comment #6)

Backed out for causing failures at nsCocoaWindow.

Backout link: https://hg.mozilla.org/integration/autoland/rev/9e9ea9f30d31

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=0a29d021c3c2354558c8aa036d0b0d4d4c8a4587&selectedTaskRun=H3OLGa_lRL-HQ9G5R_W4Fw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=564415579&repo=autoland&task=H3OLGa_lRL-HQ9G5R_W4Fw.0&lineNumber=37998

Okay, it turns out the assertion I added is too strict. The LockNativePointer() can be called multiple times while pointer lock element is changed, this is the behavior that we have right now, and I don't want to change that at the moment. I guess we would need some tweak later to avoid that.

Flags: needinfo?(echen)
Assignee

Updated

1 month ago
Blocks: 1870114
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: The is the pre-requirement to implement pointer lock unadjustedMovement on macOS.
  • Code covered by automated testing?: no
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing: None
  • Risk associated with taking this patch: low
  • Explanation of risk level: The pref is enabled only on Nightly for now.
  • String changes made/needed?: None
  • Is Android affected?: yes
Attachment #9583604 - Flags: approval-mozilla-beta?
Attachment #9583604 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee

Updated

27 days ago
Regressions: 2041246
You need to log in before you can comment on or make changes to this bug.