Switching main window between active and inactive doesn't update the title bar active state

👁 Image	horvathd Reporter
	Description • 15 years ago

User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:2.0b9pre) Gecko/20110103 Firefox/4.0b9pre Build Identifier: 20110103030359 If I hide the menu bar, and I open an another program with a non maximized window then the title bar of Firefox doesn't change to inactive automatically, only if I move the cursor over the title bar. Also when I click back to Firefox then it doesn't change back to active. Reproducible: Always Steps to Reproduce: 1. Open firefox 2. Open another software with a non maximized window. 3. Make Firefox the active window 4. Click on the other program on the taskbar to make it active Actual Results: Firefox' title bar doesn't change to inactive Expected Results: It should change to inactive But there are exceptions when the change is working. 1. Text is selected in Firefox, 2. The cursor is in a textbox in Firefox.

👁 Image	Jim Mathies [:jimm]
	Comment 1 • 15 years ago

What windows theme are you using?

👁 Image	horvathd Reporter
	Comment 2 • 15 years ago

The default Luna theme. I checked with Firefox beta 8 and using this there is no problem.

👁 Image	Jim Mathies [:jimm]
	Comment 3 • 15 years ago

confirmed, this should block.

👁 Image	Jim Mathies [:jimm]
	Updated • 15 years ago

👁 Image	(mostly gone) XtC4UaLL [:xtc4uall]
	Updated • 15 years ago

👁 Image	Robert O'Callahan (:roc) (email my personal email if necessary) Assignee
	Updated • 15 years ago

👁 Image	David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)
	Updated • 15 years ago

👁 Image	Jim Mathies [:jimm]
	Comment 4 • 15 years ago

Can anyone else confirm this goes away after the browser sits open for about a minute?

👁 Image	Jim Mathies [:jimm]
	Comment 5 • 15 years ago

Ah, never mind. If you have the cursor focus in the search edit, the problem goes away. Clearly some sort of invalidation/repainting problem.

👁 Image	Jim Mathies [:jimm]
	Comment 6 • 15 years ago

Regression range - 12/27 -> 12/28: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=24b63f638579&tochange=e928817fb4e9

👁 Image	Jim Mathies [:jimm]
	Comment 7 • 15 years ago

(In reply to comment #6) > Regression range - 12/27 -> 12/28: > > http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=24b63f638579&tochange=e928817fb4e9 Confirmed, backing out part 2 from bug 615870 fixes this - Part 2: Track per-display-root-frame 'update layer tree' state bit. r=tnikkel a=b-f

👁 Image	Benjamin Smedberg
	Comment 8 • 15 years ago

tn, can you take this?

👁 Image	Timothy Nikkel (:tnikkel)
	Comment 9 • 15 years ago

Any time we get a paint event that wasn't preceded by an nsIFrame::Invalidate call we will try to do an empty transaction. I bet Windows sends us a paint event when we become inactive?

👁 Image	Robert O'Callahan (:roc) (email my personal email if necessary) Assignee
	Comment 10 • 15 years ago

I bet PresShell::DocumentStatesChanged needs to mark the layer tree as needing an update. Or maybe FrameLayerBuilder::InvalidateAllLayers/InvalidateAllThebesLayerContents/InvalidateThebesLayersInSubtree should all ensure the layer tree gets updated at the next paint.

👁 Image	Jim Mathies [:jimm]
	Comment 11 • 15 years ago

(In reply to comment #9) > Any time we get a paint event that wasn't preceded by an nsIFrame::Invalidate > call we will try to do an empty transaction. I bet Windows sends us a paint > event when we become inactive? We generate this in widget when we receive an activation state change. The nc areas we paint are invalidated.

👁 Image	Robert O'Callahan (:roc) (email my personal email if necessary) Assignee
	Comment 13 • 15 years ago

Does this fix it?

👁 Image	Robert O'Callahan (:roc) (email my personal email if necessary) Assignee
	Comment 14 • 15 years ago

I think we should do something here even if it doesn't fix this bug. Maybe instead of all this leading down to FrameLayerBuilder::InvalidateAllThebesLayerContents, we should call root->InvalidateFrameSubtree() (which didn't exist when this code was written) and remove FrameLayerBuilder::InvalidateAllThebesLayerContents completely.

👁 Image	Timothy Nikkel (:tnikkel)
	Comment 15 • 15 years ago

Yeah, that fixes it.

👁 Image	Robert O'Callahan (:roc) (email my personal email if necessary) Assignee
	Comment 16 • 15 years ago

Well then, this should fix it too.

👁 Image	Robert O'Callahan (:roc) (email my personal email if necessary) Assignee
	Comment 17 • 15 years ago

👁 Image	Timothy Nikkel (:tnikkel)
	Updated • 15 years ago

👁 Image	Timothy Nikkel (:tnikkel)
	Comment 18 • 15 years ago

Comment on attachment 509239 [details] [diff] [review] Remove unused API I think you might need to remove more code. I think there is one instance of InvalidateAllThebesLayerContents in a comment that this patch does not remove.

👁 Image	Robert O'Callahan (:roc) (email my personal email if necessary) Assignee
	Updated • 15 years ago

👁 Image	Asa Dotzler [:asa]
	Updated • 15 years ago

👁 Image	Robert O'Callahan (:roc) (email my personal email if necessary) Assignee
	Comment 19 • 15 years ago

👁 Image	Robert O'Callahan (:roc) (email my personal email if necessary) Assignee
	Comment 20 • 15 years ago

(In reply to comment #18) > Comment on attachment 509239 [details] [diff] [review] > Remove unused API > > I think you might need to remove more code. I think there is one instance of > InvalidateAllThebesLayerContents in a comment that this patch does not remove. Where?

👁 Image	Timothy Nikkel (:tnikkel)
	Comment 21 • 15 years ago

http://mxr.mozilla.org/mozilla-central/source/layout/base/FrameLayerBuilder.cpp#746 I don't see that in your diff.

👁 Image	Robert O'Callahan (:roc) (email my personal email if necessary) Assignee
	Comment 22 • 15 years ago

Sorry, I had updated my patch locally and forgot to upload it.

👁 Image	Steve Scott (pxbugz)
	Comment 23 • 15 years ago

Verified fixed in Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110204 Firefox/4.0b12pre

👁 Image	u279076
	Updated • 15 years ago

👁 Image	Timothy Nikkel (:tnikkel)
	Updated • 15 years ago

👁 Image	Timothy Nikkel (:tnikkel)
	Updated • 15 years ago

👁 Image	Timothy Nikkel (:tnikkel)
	Updated • 15 years ago

👁 Image	David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)
	Comment 25 • 15 years ago

Second patch landed: http://hg.mozilla.org/mozilla-central/rev/3268bdbd64c4