we should remove "font.size.unit" in nsPresContext.cpp, or fix other code that uses "font.size.*" to use it

👁 Image	(not reading, please use seth@sspitzer.org instead) Reporter
	Description • 24 years ago

we should remove "font.size.unit" in nsPresContext.cpp, or fix other code that uses "font.size." to use it that pref is to allow users to say their fonts are in pixels (px) or points (pt) there's a whole bunch of other font code that looks like it is assuming fonts are in pixels. if a user set "font.size.unit", all that other code would break. sorry asa, I wanted to assign this to erik, but he's gone.

👁 Image	rbs
	Updated • 24 years ago

👁 Image	Asa Dotzler [:asa]
	Comment 1 • 24 years ago

->layout

👁 Image	David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)
	Comment 2 • 24 years ago

->i18n

👁 Image	nhottanscp
	Comment 3 • 24 years ago

Reassign to yokoyama, cc to shanjian, ftang.

👁 Image	Roy Yokoyama
	Updated • 24 years ago

👁 Image	rbs
	Comment 4 • 24 years ago

I suggest to combine the value and the unit as in CSS, i.e., prefs values can now be specified as font.size = '10px'. This is easy to remember and less error-prone now that the CSS syntax is getting entrenched in people's habits. Then the nsPresContext.cpp code can be changed to RFind() 'px' or 'pt' (this is the only place to do so, hence less invasive). And to remind people to explicitly set the unit, an assertion could be fired when a value without unit is found, but a value without unit would be assumed to be in pixel. How does this sound. I am in the midst of font changes (bug 74186 and friends) and can easily incorpoprate this in my changes.

👁 Image	Roy Yokoyama
	Comment 5 • 24 years ago

ftang, shanjian: can you comment on rbs's?

👁 Image	Hixie (not reading bugmail)
	Comment 6 • 24 years ago

Sounds good to me, if we have to continue supporting 'pt' at all. :-)

👁 Image	Andreas Becker
	Comment 7 • 23 years ago

Changing QA contact to bobj for now. Bob, please re-assign further as you see is appropriate.

👁 Image	Phil Ringnalda (:philor)
	Updated • 16 years ago

👁 Image	Nicholas Nethercote [inactive] Assignee
	Comment 8 • 8 years ago

The default value is 'px'. The alternative value is 'pt', but it's not clear that changing it to 'pt' will actually work sensibly. It was first suggested that this pref be removed 17 years ago, and it doesn't appear to have become more useful since then. It's not set anywhere. Let's remove it.

👁 Image	Nicholas Nethercote [inactive] Assignee
	Updated • 8 years ago

👁 Image	Nicholas Nethercote [inactive] Assignee
	Updated • 8 years ago

👁 Image	Nicholas Nethercote [inactive] Assignee
	Comment 9 • 8 years ago

Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fab9b498d88242be230e16e9d7d20e7fed287687

👁 Image	David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)
	Updated • 8 years ago

👁 Image	Nicholas Nethercote [inactive] Assignee
	Comment 10 • 8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/6fafc2b0045ee26e4bb4b85b03f791d353d9198f Bug 90440 - Remove the font.size.unit pref. r=dbaron.

👁 Image	Andrei Ciure[:aciure]
	Comment 11 • 8 years ago
bugherder

👁 Image	Gregory Pappas [:gregp]
	Updated • 2 years ago

👁 Image	Gregory Pappas [:gregp]
	Updated • 2 years ago