VOOZH about

URL: https://huggingface.co/ByteDance/Ouro-1.4B-Thinking/discussions/6

โ‡ฑ ByteDance/Ouro-1.4B-Thinking ยท Fix default RoPE init function reference in OuroRotaryEmbedding


Fix default RoPE init function reference in OuroRotaryEmbedding

#6
by wanglne - opened

This PR fixes a NameError in OuroRotaryEmbedding.init when rope_type == "default".
compute_default_rope_parameters is defined as a static method inside OuroRotaryEmbedding, but the initializer currently references it as a global function:
rope_init_fn: Callable = compute_default_rope_parameters
This causes:
NameError: name 'compute_default_rope_parameters' is not defined
This PR changes it to:
rope_init_fn: Callable = self.compute_default_rope_parameters
After this change, the model can proceed past RoPE initialization.

ridger changed pull request status to merged

ยท Sign up or log in to comment