Talk:Item modifier

The way I see it, loot functions are JSON structures used to modify items and item stacks in loot tables and item modifiers; item modifiers are files that invoke loot functions. This article currently documents both item modifiers and loot functions, but since loot functions are used in more contexts, I think it should feature as the article's main title. Item modifiers can be mentioned specifically under the "Usage" section ("Item modifier" may redirect to this section specifically).

If anyone is unsure about the name "loot function", it should be noted that "loot function" is a phrase repeatedly used by Mojang in their snapshot articles on minecraft.net, and is therefore about as canonical as you can get. – ZacNVR (talk) 06:41, 15 April 2024 (UTC)

👁 Image
 Oppose. The term "loot function" is not widely used in the data pack community. Currently each file type in a data pack has their own wiki page. We also have Predicate and not Loot condition. The Loot table page right now mentions "Invokes item modifiers, also called loot functions, in order" and links to this page, this is clear enough in my opinion. — Misode (talk) 00:54, 16 April 2024 (UTC)

Fair enough, and I imagine you're more in the loop regarding the data pack community than I am. But if "item modifier" is preferred then plenty of other articles need fixing, including the item modifier article itself, which links "item function" and "loot function" to loot table. Also, Loot table § History features loot-function-related changes prior to the addition of dedicated item modifier files.

To be clear, it's fine if these articles need changing, but I want to make sure that this problem doesn't go unaddressed. – ZacNVR (talk) 06:43, 17 April 2024 (UTC)

I realize that the problem I raised applies regardless of whether this article ends up "item modifier" or "loot function". I guess my point of this discussion then is more so achieving consistency on the wiki in a way that makes the most sense. – ZacNVR (talk) 07:03, 17 April 2024 (UTC)

I don't think even Mojang uses the terms consistently, in my opinion they're interchangeable. I remember an earlier discussion on the loot table talk page. It was mostly regarding the "entry" term, but in general: "The wording of the wiki should, in most cases, be the one that is accurate while still being easy to understand, not bent over backwards to appease the wording in the source code"

Relevant to item modifiers and predicates, ExpertCoder14 concluded with: "My proposal is that we include the technical term alongside the common term [...] Predicates, technically known as loot conditions [...] The same can be done with item modifiers". I think this is a good guideline to use here. — Misode (talk) 22:25, 17 April 2024 (UTC)

Personally, 👁 Image
 Unsure and more or less indifferent, especially after Misode's comment. Would still appreciate more opinions, even if it's just unanimously hammering in "item modifier". – ZacNVR (talk) 07:06, 17 April 2024 (UTC)

👁 Image
 Oppose. "loot functions are used in more contexts" is not correct. Loot functions only exist in item modifiers. In fact, loot tables invoke item modifiers rather than loot functions. The "functions" in loot table is an array of item modifiers (each element in the array can be an array or an object), rather than an array of single functions.--Chixvv (talk) 15:03, 19 August 2024 (UTC)