VOOZH about

URL: https://phabricator.services.mozilla.com/D264933

⇱ ⚙ D264933 Bug 1988716 - Part 1: Make inference process distinguishable in our power usage data. r=florian,chutten

Paths

Bug 1988716 - Part 1: Make inference process distinguishable in our power usage data. r=florian,chutten
ClosedPublic

Authored by bas on Sep 16 2025, 12:22 PM.
Referenced Files
F72953333: D264933.1781825241.diff
Wed, Jun 17, 11:27 PM
F72947843: D264933.1781822167.diff
Wed, Jun 17, 10:36 PM
F72945037: D264933.1781821975.diff
Wed, Jun 17, 10:32 PM
F72944988: D264933.1781821972.diff
Wed, Jun 17, 10:32 PM
Unknown Object (File)
Thu, Jun 4, 10:15 AM
Unknown Object (File)
Thu, Jun 4, 7:14 AM
Unknown Object (File)
Thu, Jun 4, 6:28 AM
Unknown Object (File)
Thu, Jun 4, 5:21 AM
Subscribers

Diff Detail

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Comment Actions

This revision changes how Firefox collects data, so it needs a #data-classification tag.

If you (the patch author) are adding new or modifying existing data collection, you and your reviewer(s) should judge how sensitive this data is, using the data collection categories Mozilla uses. If the data you are collecting fits in either the Category 1 “technical data” or Category 2 “interaction data” described there, please add the #data-classification-low tag. If it’s any other category, or you and your reviewer(s) disagree, please add the #data-classification-high tag, and go through the sensitive data collection review process. If you think that the data in question fits in “technical” or “interaction” data but would benefit from additional review, you can also explicitly choose to use the #data-classification-high tag and thereby opt in to the sensitive data collection review process.

When using Glean for the data collection, the data classification of the new or expanded data collections should match the property in the metric definitions.

If you are removing data collection, or are making mechanical changes to these files that do not add or modify what data is collected, change when or how it is collected, please add the data-classification-unnecessary tag.

If you are unsure or feel uncomfortable making this assessment yourself, please ask the data-stewards group for help.

Whichever tag is used, please leave a comment explaining this choice. Note that Lando will not be able to land this revision until the revision has one of these tags and you remove the #needs-data-classification tag.

Finally, you as a patch author are encouraged to add the right tags yourself, but your reviewers are responsible for making sure the right tag is used.

chutten added 1 blocking reviewer(s): florian.
chutten edited projects, added Restricted Project; removed Restricted Project.
florian requested changes to this revision.Sep 19 2025, 9:02 AM
florian added inline comments.
toolkit/components/glean/ipc/FOGIPC.cpp
337

Why do you need this prefix check? Existing code looks for the exact string: https://searchfox.org/firefox-main/rev/bd4c9573f3f4304df50e943f4358a7af7688b4c0/dom/onnx/InferenceSession.cpp#213-219

I would keep checking for the web remote type first as that should be the common case, then add an to set gThisProcessType.

toolkit/components/processtools/metrics.yaml
60

This is the only change you need to have the per-process data. Everything else in the patch is to have per-thread data (Nightly only).

210

Have you checked that the thread names used by the inference process are part of this list? If they are not, all you'll get is a large number in the bucket.

This revision now requires changes to proceed.Sep 19 2025, 9:02 AM
bas requested review of this revision.Oct 6 2025, 3:28 PM
bas updated this revision to Diff 1134213.
bas marked an inline comment as done.Oct 6 2025, 8:05 PM
This revision is now accepted and ready to land.Oct 6 2025, 9:12 PM
Comment Actions

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of , , , , . Tip: this Firefox add-on makes it easy!

bas marked 2 inline comments as done.Oct 7 2025, 4:19 PM
This revision is now accepted and ready to land.Oct 7 2025, 6:52 PM
Comment Actions

The analysis task source-test-mozlint-mingw-cap failed, but we could not detect any defect.
Please check this task manually.

If you see a problem in this automated review, please report it here.

Revision Contents

PathSize
toolkit/
components/
glean/
ipc/
12 lines
processtools/
4 lines
CommitTreeParentsAuthorSummaryDate
93e210ba11014ddec26eb986Bas Schouten
Bug 1988716 - Part 1: Make inference process distinguishable in our power usage… (Show More…)

Diff 1135938

toolkit/components/glean/ipc/FOGIPC.cpp

Loading...

toolkit/components/processtools/metrics.yaml

Loading...