VOOZH about

URL: https://phabricator.services.mozilla.com/D288519

⇱ ⚙ D288519 Bug 2012213 — add hideCheckmark option to ConfirmationHint.show to show or hide checkmark

Paths

Bug 2012213 — add hideCheckmark option to ConfirmationHint.show to show or hide checkmark
ClosedPublic

Authored by kpatenio on Mar 18 2026, 8:29 PM.
Referenced Files
Unknown Object (File)
Mon, Jun 8, 5:17 AM
Unknown Object (File)
Mon, Jun 8, 2:55 AM
Unknown Object (File)
Mon, Jun 8, 2:04 AM
Unknown Object (File)
Sun, Jun 7, 10:47 PM
Unknown Object (File)
Sun, Jun 7, 8:58 PM
Unknown Object (File)
Sun, Jun 7, 7:09 PM
Unknown Object (File)
Sun, Jun 7, 6:54 PM
Unknown Object (File)
Sun, Jun 7, 6:02 PM
Subscribers

Details

Test Plan

Ways to test confirmation hints:

Pinned! + Right-click the tab to unpin it.
This is a confirmation hint with an added description. Easiest way to test is by pasting this script in Browser Toolbox.

// Show hint after 5 seconds
setTimeout(() => {
 ConfirmationHint.show(gBrowser.selectedTab, "confirmation-hint-pin-tab", {
 descriptionId: "confirmation-hint-pin-tab-description",
 });
}, 5000);

Saved to bookmarks
Can also be triggered with a script similar to above. But to display naturally:

  1. Ensure is set to 0
  2. Go to any page
  3. Save as a bookmark
  4. Confirmation hint "Saved to bookmarks" should appear (max 3 times unless pref is reset)

VPN is off for this site
Requires access to the built-in VPN via enrolment in experiment. Can also be triggered with a script similar to above. But to display naturally:

  1. Ensure VPN is active / on
  2. Set a site exclusion (panel toggle or about:preferences)
  3. Open a new tab navigating to excluded site
  4. Confirmation hint should appear for that site

Diff Detail

Event Timeline

kpatenio created this revision.
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Mar 18 2026, 8:51 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
kpatenio retitled this revision from WIP: Bug 2012213 — add isCheckmarkVisible option to ConfirmationHint.show to show or hide checkmark to Bug 2012213 — add isCheckmarkVisible option to ConfirmationHint.show to show or hide checkmark.
kpatenio edited the test plan for this revision. (Show Details)
rking added a subscriber: rking.
Comment Actions

Looks good! Confirmed that the checkmark can now be hidden by passing , making it unnecessary to add styling for our single message id in . Just one question added inline- it seems to be working as-is, so I'm assuming this doesn't need changes, but would like clarity regardless.

browser/base/content/browser.js
4721–4732

If the user doesn't pass any object after and , will it default to an empty object and ignore the default value for ?

kpatenio added inline comments.
browser/base/content/browser.js
4721–4732

Yes, it defaults to an empty object if no options param is passed at all. is applied afterwards due to destructuring if we don't pass a option. I opted for destructuring to avoid overwriting the default options object (and thus losing ) if we pass in our own options object.

dao requested changes to this revision.Apr 1 2026, 2:12 PM
dao added a subscriber: dao.
dao added inline comments.
browser/base/content/browser.js
4721–4732

nit: how about renaming the option to and letting it default to ?

browser/themes/shared/customizableui/panelUI-shared.css
413–414

With this patch on Linux, when there's a description, it doesn't seem to line up with the message. I suppose you need to adjust the margin on both elements?

This revision now requires changes to proceed.Apr 1 2026, 2:12 PM
kpatenio updated this revision to Diff 1244331.
kpatenio retitled this revision from Bug 2012213 — add isCheckmarkVisible option to ConfirmationHint.show to show or hide checkmark to WIP: Bug 2012213 — add hideCheckmark option to ConfirmationHint.show to show or hide checkmark.
kpatenio edited the summary of this revision. (Show Details)
kpatenio marked 2 inline comments as done.
Comment Actions

Rebased and renamed to . Setting back to WIP to do more testing on a Linux build.

kpatenio updated this revision to Diff 1273118.
kpatenio edited the summary of this revision. (Show Details)
kpatenio updated this revision to Diff 1273165.
kpatenio retitled this revision from WIP: Bug 2012213 — add hideCheckmark option to ConfirmationHint.show to show or hide checkmark to Bug 2012213 — add hideCheckmark option to ConfirmationHint.show to show or hide checkmark.
Comment Actions

Updated to fix a misalignment between the confirmation hint message and description. Apparently occurs on macOS too.

Here's a couple screenshots showing the before and after.

macOS before:

macOS after:

linux before:

linux after:

Itiel added inline comments.
browser/themes/shared/customizableui/panelUI-shared.css
479

Could be a nice opportunity to swap this with a space token

kpatenio marked an inline comment as done.
Comment Actions
browser/themes/shared/customizableui/panelUI-shared.css
479

Good idea. seems to be the closest.

This revision is now accepted and ready to land.May 13 2026, 4:17 PM
Comment Actions

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of , , , , . Tip: this Firefox add-on makes it easy!

Revision Contents

PathSize
browser/
base/
content/
31 lines
components/
ipprotection/
1 line
themes/
shared/
customizableui/
25 lines
CommitTreeParentsAuthorSummaryDate
5c7cd998557c0132ee08e55bkpatenio
Bug 2012213 — add hideCheckmark option to ConfirmationHint.show to show or hide… (Show More…)

Diff 1274177

browser/base/content/browser.js

Loading...

browser/components/ipprotection/IPProtectionToolbarButton.sys.mjs

Loading...

browser/themes/shared/customizableui/panelUI-shared.css

Loading...