This revision changes how Firefox collects data, so it needs a #data-classification tag.

If you (the patch author) are adding new or modifying existing data collection, you and your reviewer(s) should judge how sensitive this data is, using the data collection categories Mozilla uses. If the data you are collecting fits in either the Category 1 “technical data” or Category 2 “interaction data” described there, please add the #data-classification-low tag. If it’s any other category, or you and your reviewer(s) disagree, please add the #data-classification-high tag, and go through the sensitive data collection review process. If you think that the data in question fits in “technical” or “interaction” data but would benefit from additional review, you can also explicitly choose to use the #data-classification-high tag and thereby opt in to the sensitive data collection review process.

When using Glean for the data collection, the data classification of the new or expanded data collections should match the property in the metric definitions.

If you are removing data collection, or are making mechanical changes to these files that do not add or modify what data is collected, change when or how it is collected, please add the data-classification-unnecessary tag.

If you are unsure or feel uncomfortable making this assessment yourself, please ask the data-stewards group for help.

Whichever tag is used, please leave a comment explaining this choice. Note that Lando will not be able to land this revision until the revision has one of these tags and you remove the #needs-data-classification tag.

Finally, you as a patch author are encouraged to add the right tags yourself, but your reviewers are responsible for making sure the right tag is used.

Code analysis found 1 defect in diff 1247840:

• 1 defect found by clang-format (Mozlint)

You can run this analysis locally with:

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1247840.

This revision is now going through the sensitive data review process. As a patch author, please follow the steps described in that process by:

1. Documenting the details of the implementation, intended use, and value to users for future reference and efficient review.

2. Attach a filled in copy of the request template to the bug, marking the content type as text/plain.

3. Emailing the data-review@mozilla.com list with the details from step (1) and (2)

More details on the rest of the process are on the wiki.

Someone from the data-stewards group should approve this revision for landing if/when the review process is complete and approval is given.

LGTM, but I added a couple comments to consider.

Code analysis found 1 defect in diff 1253231:

• 1 defect found by clang-format (Mozlint)

You can run this analysis locally with:

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1253231.

Accept data classification high as data steward. This collection has been approved through the sensitive data collection review process.

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of , , , , . Tip: this Firefox add-on makes it easy!