VOOZH about

URL: https://phabricator.services.mozilla.com/D297657

⇱ ⚙ D297657 Bug 1990613 - Fenix: Replace `GlobalScope` with a structured `applicationScope`.


Bug 1990613 - Fenix: Replace `GlobalScope` with a structured `applicationScope`.
Needs ReviewPublic

Authored by mcarare on Apr 30 2026, 3:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 12, 3:31 PM
Unknown Object (File)
Sun, May 31, 11:27 AM
Unknown Object (File)
Sun, May 31, 7:35 AM
Unknown Object (File)
Sat, May 30, 6:20 PM
Unknown Object (File)
Thu, May 28, 12:43 AM
Unknown Object (File)
Thu, May 21, 4:36 AM
Unknown Object (File)
Tue, May 19, 7:57 PM
Unknown Object (File)
May 18 2026, 7:56 PM
Subscribers

Details

Reviewers
None
Group Reviewers
android-reviewers
Bugzilla Bug ID
1990613
Summary

Key changes:

  • Introduced a central in tied to the application lifetime using and a global .
  • Injected into and to provide a managed scope for background tasks.
  • Refactored , , , and to use the provided instead of .
  • Updated and to accept a for asynchronous operations.
  • Updated various fragments (, , , , , and ) to pass the application scope to their respective controllers/bindings.
    • Also fix queueEngineWarmup accidentally returning a lambda instead of executing the runOnVisualCompleteness block, due to an erroneous function body syntax. The engine warmup was silently never being scheduled at visual completeness.

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Comment Actions

Code analysis found 1 defect in diff 1291834:

  • 1 defect found by android-fenix (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:


If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1291834.

Revision Contents

PathSize
mobile/
android/
fenix/
app/
src/
main/
java/
org/
mozilla/
fenix/
76 lines
6 lines
addons/
1 line
1 line
browser/
1 line
components/
18 lines
3 lines
crashes/
5 lines
home/
1 line
perf/
9 lines
17 lines
settings/
1 line
share/
11 lines
20 lines
snackbar/
9 lines
test/
java/
org/
mozilla/
fenix/
crashes/
5 lines
perf/
18 lines
share/
43 lines
snackbar/
47 lines
config/
2 lines
CommitTreeParentsAuthorSummaryDate
4adc2acef37c4695d7be03d90b534ae76a57mcarare
Bug 1990613 - Fenix: Replace `GlobalScope` with a structured `applicationScope`. (Show More…)
Apr 22 2026, 2:05 PM

Diff 1291971

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FenixApplication.kt

Loading...

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt

Loading...

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/AddonInternalSettingsFragment.kt

Loading...

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/WebExtensionActionPopupFragment.kt

Loading...

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt

Loading...

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Components.kt

Loading...

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt

Loading...

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/crashes/CrashReporterController.kt

Loading...

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt

Loading...

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/perf/StartupTypeTelemetry.kt

Loading...

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/perf/StorageStatsMetrics.kt

Loading...

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt

Loading...

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/share/ShareController.kt

Loading...

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/share/ShareFragment.kt

Loading...

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/snackbar/SnackbarBinding.kt

Loading...

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/crashes/CrashReporterControllerTest.kt

Loading...

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/perf/StartupTypeTelemetryTest.kt

Loading...

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/share/ShareControllerTest.kt

Loading...

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/snackbar/SnackbarBindingTest.kt

Loading...

mobile/android/fenix/config/detekt-baseline.xml

Loading...