Differential D297657

Bug 1990613 - Fenix: Replace `GlobalScope` with a structured `applicationScope`.
Needs ReviewPublic
Actions

Authored by mcarare on Apr 30 2026, 3:20 PM.

Details

Reviewers

None

Group Reviewers

android-reviewers

Bugzilla Bug ID

1990613

Summary

Key changes:

Introduced a central in tied to the application lifetime using and a global .
Injected into and to provide a managed scope for background tasks.
Refactored , , , and to use the provided instead of .
Updated and to accept a for asynchronous operations.
Updated various fragments (, , , , , and ) to pass the application scope to their respective controllers/bindings.
- Also fix queueEngineWarmup accidentally returning a lambda instead of executing the runOnVisualCompleteness block, due to an erroneous function body syntax. The engine warmup was silently never being scheduled at visual completeness.

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland
Branch: HEAD

Event Timeline

mcarare created this revision.Apr 30 2026, 3:20 PM

Herald added a project: secure-revision. · View Herald TranscriptApr 30 2026, 3:20 PM

mcarare added a child revision: D297658: Bug 1990613 - AC samples: Refactor sample applications to use structured `CoroutineScope` instead of `GlobalScope`..Apr 30 2026, 3:20 PM

phab-bot published this revision for review.Apr 30 2026, 3:21 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: android-reviewers. · View Herald TranscriptApr 30 2026, 3:21 PM

Herald added a reviewer: android-addons-reviewers. · View Herald Transcript

Harbormaster failed remote builds in B959262: Diff 1262995!Apr 30 2026, 4:33 PM

robwu removed a reviewer: android-addons-reviewers.Tue, May 19, 1:18 PM

mcarare updated this revision to Diff 1291834.Thu, Jun 4, 10:31 AM

reviewbot added a subscriber: reviewbot.Thu, Jun 4, 11:20 AM

Comment Actions

Code analysis found 1 defect in diff 1291834:

1 defect found by android-fenix (Mozlint)

IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1291834.

Harbormaster failed remote builds in B981290: Diff 1291834!Thu, Jun 4, 11:20 AM

mcarare updated this revision to Diff 1291971.Thu, Jun 4, 12:39 PM

mcarare added a child revision: D304727: Bug 1990613 - AC: Refactor multiple components to replace GlobalScope and coroutineContext with an explicit, application-provided CoroutineScope..

Harbormaster completed remote builds in B981396: Diff 1291971.Thu, Jun 4, 1:35 PM

Revision Contents
Changeset List

Path

Size

mobile/

android/

fenix/

app/

src/

main/

java/

org/

mozilla/

fenix/

FenixApplication.kt

76 lines

HomeActivity.kt

6 lines

addons/

AddonInternalSettingsFragment.kt

1 line

WebExtensionActionPopupFragment.kt

1 line

browser/

BaseBrowserFragment.kt

1 line

components/

Components.kt

18 lines

Core.kt

3 lines

crashes/

CrashReporterController.kt

5 lines

home/

HomeFragment.kt

1 line

perf/

StartupTypeTelemetry.kt

9 lines

StorageStatsMetrics.kt

17 lines

settings/

SettingsFragment.kt

1 line

share/

ShareController.kt

11 lines

ShareFragment.kt

20 lines

snackbar/

SnackbarBinding.kt

9 lines

test/

java/

org/

mozilla/

fenix/

crashes/

CrashReporterControllerTest.kt

5 lines

perf/

StartupTypeTelemetryTest.kt

18 lines

share/

ShareControllerTest.kt

43 lines

snackbar/

SnackbarBindingTest.kt

47 lines

config/

detekt-baseline.xml

2 lines

Commit	Tree	Parents	Author	Summary	Date
4adc2acef37c	4695d7be03d9	0b534ae76a57	mcarare	Bug 1990613 - Fenix: Replace `GlobalScope` with a structured `applicationScope`. (Show More…)	Apr 22 2026, 2:05 PM

	Status	Author
Needs Review	mcarare	D297659 Bug 1990613 - AC: Refactor multiple components to replace `GlobalScope` and `coroutineContext` with an explicit, application-provided `CoroutineScope`.
Needs Review	mcarare	D297658 Bug 1990613 - AC samples: Refactor sample applications to use structured `CoroutineScope` instead of `GlobalScope`.
Abandoned	mcarare	D304728 Bug 1990613 - AC samples: Refactor sample applications to use structured CoroutineScope instead of GlobalScope.
Abandoned	mcarare	D304727 Bug 1990613 - AC: Refactor multiple components to replace GlobalScope and coroutineContext with an explicit, application-provided CoroutineScope.
Needs Review	mcarare	D297657 Bug 1990613 - Fenix: Replace `GlobalScope` with a structured `applicationScope`.
Needs Review	mcarare	D297656 Bug 1990613 - Focus: Introduce a structured `applicationScope` to `FocusApplication` and `Components` to replace the use of `GlobalScope` and `lifecycleScope` for global background tasks.

D306452 Bug 2032561 - Part 1: Collect telemetry using the existing metrics added for VPN
·Reviewers: android-reviewers, jonalmeida, mavduevskiy
Wed, Jun 17, 11:19 PM
Author: gmalekpour
D304963 Bug 2022968 - Part 2: Add uninstallation app shortcut and integrate native AppUninstaller workflow
·Reviewers: android-reviewers, android-l10n-reviewers, flod, twhite
Wed, Jun 17, 1:30 PM
Author: alastun
D306929 Bug 2046681 - Tab strip gradient should fill the status bar
·Reviewers: android-reviewers, petru
Wed, Jun 17, 5:35 AM
Author: gl
D307122 WIP: Bug 2046172 - Create the new UI and remove old bookmarks search code
·No Reviewers
Tue, Jun 16, 9:10 PM
Author: npoon
D298633 Bug 2037184 - IP-Protection: implement the kotlin glue for GPI AuthProvider
·Reviewers: sstreich, geckoview-reviewers, geckoview-api-reviewers, jonalmeida, mavduevskiy
Tue, Jun 16, 5:43 PM
Author: baku
D302177 Bug 2032561 - Part 1: Send IP Protection related telemetry
·Reviewers: android-reviewers
Mon, Jun 15, 6:37 PM
Author: mavduevskiy
D300589 Bug 1813771 - Fixes stale uiMode value during onResume calls in some circumstances r?#android-reviewers
·Reviewers: android-reviewers
Mon, Jun 15, 1:31 PM
Author: JasonHK
D297659 Bug 1990613 - AC: Refactor multiple components to replace `GlobalScope` and `coroutineContext` with an explicit, application-provided `CoroutineScope`.
·Reviewers: android-reviewers
Thu, Jun 4, 12:48 PM
Author: mcarare
D300500 Bug 1921161 - Implement browser shortcut that is web content doesn't prevent shortcut such as Ctrl+R. r=#android-reviewers!
·Reviewers: android-reviewers, jonalmeida
Thu, Jun 4, 2:13 AM
Author: m_kato

Diff 1291971

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FenixApplication.kt

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/AddonInternalSettingsFragment.kt

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/WebExtensionActionPopupFragment.kt

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Components.kt

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/crashes/CrashReporterController.kt

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/perf/StartupTypeTelemetry.kt

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/perf/StorageStatsMetrics.kt

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/share/ShareController.kt

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/share/ShareFragment.kt

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/snackbar/SnackbarBinding.kt

View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/crashes/CrashReporterControllerTest.kt

View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/perf/StartupTypeTelemetryTest.kt

View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/share/ShareControllerTest.kt

View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/snackbar/SnackbarBindingTest.kt

View Options

mobile/android/fenix/config/detekt-baseline.xml

Privacy · Cookies · Legal

URL: https://phabricator.services.mozilla.com/D297657

⇱ ⚙ D297657 Bug 1990613 - Fenix: Replace `GlobalScope` with a structured `applicationScope`.

Bug 1990613 - Fenix: Replace `GlobalScope` with a structured `applicationScope`.
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1291971

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FenixApplication.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/AddonInternalSettingsFragment.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/WebExtensionActionPopupFragment.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Components.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/crashes/CrashReporterController.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/perf/StartupTypeTelemetry.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/perf/StorageStatsMetrics.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/share/ShareController.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/share/ShareFragment.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/snackbar/SnackbarBinding.kt

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/crashes/CrashReporterControllerTest.kt

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/perf/StartupTypeTelemetryTest.kt

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/share/ShareControllerTest.kt

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/snackbar/SnackbarBindingTest.kt

mobile/android/fenix/config/detekt-baseline.xml

URL: https://phabricator.services.mozilla.com/D297657

⇱ ⚙ D297657 Bug 1990613 - Fenix: Replace `GlobalScope` with a structured `applicationScope`.

Bug 1990613 - Fenix: Replace `GlobalScope` with a structured `applicationScope`.Needs ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1291971

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FenixApplication.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/AddonInternalSettingsFragment.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/WebExtensionActionPopupFragment.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Components.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/crashes/CrashReporterController.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/perf/StartupTypeTelemetry.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/perf/StorageStatsMetrics.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/share/ShareController.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/share/ShareFragment.kt

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/snackbar/SnackbarBinding.kt

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/crashes/CrashReporterControllerTest.kt

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/perf/StartupTypeTelemetryTest.kt

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/share/ShareControllerTest.kt

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/snackbar/SnackbarBindingTest.kt

mobile/android/fenix/config/detekt-baseline.xml

Bug 1990613 - Fenix: Replace `GlobalScope` with a structured `applicationScope`.
Needs ReviewPublic
Actions

Revision Contents
Changeset List