Differential D298808
Bug 2025868 - Dont restrict searchmode queries. r=Mak Needs ReviewPublic Authored by daleharvey on May 6 2026, 12:32 PM. Tags None Referenced Files
Subscribers
Details
Diff Detail
Event Timelinedaleharvey planned changes to this revision.May 6 2026, 12:32 PM daleharvey created this revision. phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".May 6 2026, 12:33 PM phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. daleharvey requested review of this revision.Mon, Jun 1, 9:02 PM daleharvey updated this revision to Diff 1288803. daleharvey retitled this revision from WIP: Bug 2025868 - WIP - Dont restrict searchmode in scotchBonnet v2 to Bug 2025868 - Dont restrict searchmode queries. r=Mak. daleharvey added a reviewer: mak. daleharvey added a comment.Mon, Jun 1, 9:04 PM Comment ActionsNot expecting to land this straight away, mostly for feedback on the approach, the general idea is that search mode becomes "temporarily change the default engine" and not have quite large changes in behaviour that are not always obvious mak requested changes to this revision.Mon, Jun 8, 5:29 PM Comment ActionsThe approach may be ok, I'm mostly worried about 2 things:
This revision now requires changes to proceed.Mon, Jun 8, 5:29 PM daleharvey requested review of this revision.Tue, Jun 9, 11:03 AM daleharvey updated this revision to Diff 1295024. daleharvey added a comment.Tue, Jun 9, 11:12 AM Comment Actions
Yeh agree this doesn't make sense for local search mode where the conceptual model of "temporarily changing your default engine" doesn't apply anyway so have restricted this behaviour to engine search modes only. daleharvey added a comment.Tue, Jun 9, 11:17 AM Comment ActionsI have also put this behind a new pref, there were some concerns about it affecting telemetry so want to be prudent, at this point it is for Paul to evaluate and test before we plan for release, these should be shortlived prefs. Harbormaster completed remote builds in B983792: Diff 1295035.
Revision Contents
Diff 1295035 | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
VOOZH | about |