Differential D299174
Bug 2022527 - Remove the hack from bug 2007147. r?dao AcceptedPublic Authored by mbeier on May 7 2026, 4:56 PM. Referenced Files
Subscribers
Details
Summary Changing the popupshowing listeners to contextmenu is necessary because one of them hides the view which calls hidePopover on the urlbar, preventing the context menu from showing because of bug 2037468. Using a contextmenu listener instead calls hidePopover before the contextmenu starts showing, avoiding the bug.
Diff Detail
Event Timelinembeier created this revision.May 7 2026, 4:56 PM phab-bot published this revision for review.May 7 2026, 4:56 PM phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)". phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. dao accepted this revision.Fri, May 29, 5:27 AM dao added a project: testing-exception-unchanged (Doesn't change behavior for users). dao added inline comments.
This revision is now accepted and ready to land.Fri, May 29, 5:27 AM mbeier added a comment.Fri, May 29, 2:57 PM Comment ActionsOne test is now failing (browser/components/urlbar/tests/browser-searchMode/browser_indicator.js). I believe this is caused by bug 2043545 so I'll wait until that's fixed. mbeier marked an inline comment as done.Fri, May 29, 2:58 PM Comment Actions Code analysis found 2 defects in diff 1286744:
IMPORTANT: Found 2 defects (error level) that must be fixed before landing.
You can run this analysis locally with: If you see a problem in this automated review, please report it here. You can view these defects in the Diff Detail section of Phabricator diff 1286744.
Revision Contents
Diff 1286744 browser/components/urlbar/tests/browser/searchbar/browser_searchbar_customizing_nobreakout.jsLoading... | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
VOOZH | about |