VOOZH about

URL: https://phabricator.services.mozilla.com/D304500

⇱ ⚙ D304500 Bug 2039181 - Add text color in VPN panel elements for HCM improvements. r=#ip-protection-reviewers


Bug 2039181 - Add text color in VPN panel elements for HCM improvements. r=#ip-protection-reviewers
ClosedPublic

Authored by mhynson on Wed, Jun 3, 3:42 PM.
Referenced Files
Unknown Object (File)
Tue, Jun 16, 1:58 PM
Unknown Object (File)
Fri, Jun 12, 4:59 PM
Unknown Object (File)
Wed, Jun 10, 9:14 PM
Unknown Object (File)
Wed, Jun 10, 2:14 PM
Unknown Object (File)
Wed, Jun 10, 8:10 AM
Unknown Object (File)
Wed, Jun 10, 2:45 AM
Unknown Object (File)
Sun, Jun 7, 7:11 PM
F71957354: BUG-2039181--BEFORE-AFTER--NOVA.jpg
Thu, Jun 4, 3:01 PM
Subscribers

Details

Test Plan
  • Enable HCM mode in Windows
  • Enable VPN
  • Open the panel in an unauthenticated state.
  • Verify the text colors align with the Figma.
  • It'll also be good to verify colors without HCM enabled to ensure there are no regressions.

Diff Detail

Event Timeline

phab-bot published this revision for review.Wed, Jun 3, 3:42 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Comment Actions

qreviews — no inline findings

Auto-reviewed because risk and complexity scored below the threshold of 3.

Scores

  • Risk: 1/10
  • Complexity: 1/10

Risk factors

  • CSS-only changes affecting UI styling with no executable code logic
  • Changes are purely additive (text color properties) with no removal or behavioral modification
  • Both files are theme/styling files with well-established patterns and no security/permissions implications
  • Existing tests cover both modified files per searchfox

Complexity factors

  • Only 5 lines of code added across 2 files
  • Trivial styling additions: single property assignments to existing CSS selectors
  • No new abstractions, control flow, or architectural changes
  • Changes follow established CSS patterns already used in the same files

No inline findings raised at the bot's confidence threshold.


*Advisory only — posted by qreviews using . Does not accept, reject, or request changes.*

mhynson edited the test plan for this revision. (Show Details)
kpatenio added a subscriber: kpatenio.
Comment Actions

Thanks for picking this up @mhynson. Do you mind attaching screenshots of the before/after changes on Windows with the Nova pref enabled? I don't expect major changes, if any. Just thinking it'd be nice to double check and compare to the spec as a precaution.

Comment Actions

It looks like Nova handles this natively. Here are before and after pics. I'll abandon this review @kpatenio

Comment Actions

Reopening revision after conversation with @kpatenio. This will be good to still land prior to Nova being fully released.

dao added a subscriber: dao.
dao added inline comments.
browser/components/ipprotection/content/ipprotection-content.css
110

Wrap this in so it will be removed with Nova?

browser/themes/shared/customizableui/panelUI-shared.css
2514–2516

ditto

This revision is now accepted and ready to land.Wed, Jun 10, 10:20 PM
Comment Actions

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of , , , , . Tip: this Firefox add-on makes it easy!

mhynson edited the summary of this revision. (Show Details)
mhynson marked 2 inline comments as done.

Revision Contents

PathSize
browser/
components/
ipprotection/
content/
3 lines
themes/
shared/
customizableui/
6 lines
CommitTreeParentsAuthorSummaryDate
6ba66c5fecd4c22b18f4ce83Michael Hynson
Bug 2039181 - Add text color in VPN panel elements for HCM improvements. r=ip… (Show More…)

Diff 1299207

browser/components/ipprotection/content/ipprotection-content.css

Loading...

browser/themes/shared/customizableui/panelUI-shared.css

Loading...