Differential D304500
Bug 2039181 - Add text color in VPN panel elements for HCM improvements. r=#ip-protection-reviewers ClosedPublic Authored by mhynson on Wed, Jun 3, 3:42 PM. Referenced Files
Details
Test Plan
Diff Detail
Event Timelinemhynson created this revision.Wed, Jun 3, 3:42 PM phab-bot published this revision for review.Wed, Jun 3, 3:42 PM phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)". phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. Comment Actions qreviews — no inline findings Auto-reviewed because risk and complexity scored below the threshold of 3. Scores
Risk factors
Complexity factors
No inline findings raised at the bot's confidence threshold. *Advisory only — posted by qreviews using . Does not accept, reject, or request changes.* mhynson edited the test plan for this revision. (Show Details) mhynson attached a referenced file: F71878038: BUG-2039181--BEFORE-AFTER.jpg. (Show Details)Wed, Jun 3, 4:26 PM kpatenio accepted this revision.Wed, Jun 3, 10:56 PM Comment Actionsmhynson planned changes to this revision.Thu, Jun 4, 2:53 PM mhynson added a comment.EditedThu, Jun 4, 3:01 PM Comment ActionsIt looks like Nova handles this natively. Here are before and after pics. I'll abandon this review @kpatenio mhynson abandoned this revision.Thu, Jun 4, 3:06 PM mhynson reclaimed this revision.Thu, Jun 4, 9:03 PM Comment ActionsReopening revision after conversation with @kpatenio. This will be good to still land prior to Nova being fully released. This revision is now accepted and ready to land.Wed, Jun 10, 10:20 PM Comment Actions This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of , , , , . Tip: this Firefox add-on makes it easy! mhynson edited the summary of this revision. (Show Details) mhynson marked 2 inline comments as done. kpatenio edited projects, added testing-exception-ui (Only changes ui styling, images, or localized strings); removed needs-testing-tag.Fri, Jun 12, 4:25 PM This revision was landed with ongoing or failed builds.Fri, Jun 12, 9:04 PM Closed by commit rFIREFOXAUTOLAND6ba66c5fecd4: Bug 2039181 - Add text color in VPN panel elements for HCM improvements. r=ip… (authored by mhynson). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 1299207 |
