Differential D306336
Bug 2045752 - Part 2: Refactor color tokens with nativeTheme r?#recomp-reviewers AcceptedPublic Authored by mstriemer on Thu, Jun 11, 11:57 PM. Referenced Files None
Details
Summary This adds some nativeTheme values for Nova since those were looking a
Diff Detail
Event Timelinemstriemer created this revision.Thu, Jun 11, 11:57 PM phab-bot published this revision for review.Thu, Jun 11, 11:57 PM phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)". phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. Herald added 1 blocking reviewer(s): reusable-components-reviewers-rotation. · View Herald Transcript phab-bot removed a reviewer: reusable-components-reviewers-rotation. phab-bot added a subscriber: reusable-components-reviewers-rotation. tgiles accepted this revision.Fri, Jun 12, 7:56 PM tgiles added a project: testing-exception-ui (Only changes ui styling, images, or localized strings). Comment ActionsThanks for cleaning this up as well! This revision is now accepted and ready to land.Fri, Jun 12, 7:56 PM Comment Actions Code analysis found 1 defect in diff 1302606:
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.
You can run this analysis locally with: If you see a problem in this automated review, please report it here. You can view these defects in the Diff Detail section of Phabricator diff 1302606.
Revision Contents
Diff 1302606 toolkit/themes/shared/design-system/src/tokens/components/button.nova.tokens.jsonLoading... |
 |
VOOZH | about |