Differential D306508

Bug 2013800 - add certificate error overrides using information from the parent process r?nika
AcceptedPublic
Actions

Authored by keeler on Fri, Jun 12, 6:58 PM.

Details

Reviewers

nika

Bugzilla Bug ID

2013800

Test Plan

https://treeherder.mozilla.org/jobs?repo=try&revision=672c104f9ac8a00f70ca44b0cff7d6123520ed3a

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland
Branch: HEAD

Event Timeline

keeler created this revision.Fri, Jun 12, 6:58 PM

Herald added a project: secure-revision. · View Herald TranscriptFri, Jun 12, 6:58 PM

phab-bot published this revision for review.Fri, Jun 12, 6:58 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

keeler edited the test plan for this revision. (Show Details)Fri, Jun 12, 10:16 PM

nika requested changes to this revision.Mon, Jun 15, 11:12 PM

nika added inline comments.

dom/base/Document.cpp
1526–1528	I don't think you need this assertion, the should still exist within the parent process.
dom/ipc/WindowGlobalParent.cpp
1600–1660	I might factor this out into 2 functions so that you don't need to call on every code path, IMO it makes it easier to read/follow.
1602–1605	You should use so that it works for documents loaded in the parent process too (https://searchfox.org/firefox-main/rev/54a6ea0101243dbe68cd7d5a4402696342cd3694/dom/ipc/WindowGlobalParent.cpp#840-848)

This revision now requires changes to proceed.Mon, Jun 15, 11:12 PM

keeler planned changes to this revision.Wed, Jun 17, 10:32 PM

keeler marked 3 inline comments as done.

keeler added inline comments.

dom/ipc/WindowGlobalParent.cpp
1602–1605	Ok!

keeler requested review of this revision.Wed, Jun 17, 10:57 PM

keeler updated this revision to Diff 1303016.

keeler marked an inline comment as done.

keeler planned changes to this revision.Wed, Jun 17, 10:59 PM

keeler requested review of this revision.Wed, Jun 17, 11:09 PM

keeler updated this revision to Diff 1303020.

Harbormaster failed remote builds in B989688: Diff 1303016!Wed, Jun 17, 11:12 PM

nika accepted this revision.Wed, Jun 17, 11:21 PM

This revision is now accepted and ready to land.Wed, Jun 17, 11:21 PM

Herald added a project: needs-testing-tag. · View Herald TranscriptWed, Jun 17, 11:21 PM

Comment Actions

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of , , , , . Tip: this Firefox add-on makes it easy!

keeler edited projects, added testing-exception-unchanged (Doesn't change behavior for users); removed needs-testing-tag.Wed, Jun 17, 11:25 PM

reviewbot added a subscriber: reviewbot.Wed, Jun 17, 11:33 PM

Comment Actions

Code analysis found 10 defects in diff 1303020:

10 build errors found by clang-tidy

IMPORTANT: Found 10 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

(C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1303020.

Harbormaster failed remote builds in B989691: Diff 1303020!Wed, Jun 17, 11:33 PM

keeler updated this revision to Diff 1303066.Thu, Jun 18, 12:01 AM

reviewbot added a comment.Thu, Jun 18, 12:31 AM

Comment Actions

Code analysis found 2 defects in diff 1303066:

2 build errors found by clang-tidy

IMPORTANT: Found 2 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

(C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1303066.

Harbormaster failed remote builds in B989715: Diff 1303066!Thu, Jun 18, 12:31 AM

Revision Contents
Changeset List

Path

Size

dom/

base/

Document.cpp

97 lines

ipc/

6 lines

18 lines

9 lines

2 lines

4 lines

WindowGlobalParent.cpp

46 lines

Commit	Tree	Parents	Author	Summary	Date
f2c57cd1800a	d8d418c79cd2	1f6f9eea1aa7	Dana Keeler	Bug 2013800 - add certificate error overrides using information from the parent… (Show More…)	Fri, Jun 12, 12:01 AM