keithamus (Keith Cirkel)
User

Projects

dom-core-reviewers
Group

User Details

User Since: Mar 27 2020, 4:29 PM (324 w, 5 d)
Availability: Available
Review Queue: 0

Recent Activity
View All

Today

keithamus planned changes to D307336: WIP: Bug 2048302 - Plumb select pseudos through animation pipeline.

Wed, Jun 17, 5:03 PM

keithamus added inline comments to D307133: Bug 2044275 - Sort all UA rules in the same batch. r=keithamus,#style.

Wed, Jun 17, 3:47 PM · needs-testing-tag

keithamus accepted D307133: Bug 2044275 - Sort all UA rules in the same batch. r=keithamus,#style.

Nice, thanks!

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of , , , , . Tip: this Firefox add-on makes it easy!

Wed, Jun 17, 3:35 PM · needs-testing-tag

keithamus updated the diff for D307309: Bug 2048183 - Wire up :open state for Select Element UA popover r?#dom-core.

Wed, Jun 17, 3:33 PM

keithamus updated the diff for D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Wed, Jun 17, 3:33 PM · testing-approved

keithamus created D307309: Bug 2048183 - Wire up :open state for Select Element UA popover r?#dom-core.

Wed, Jun 17, 3:29 PM

keithamus updated the diff for D293526: Bug 2018910 - Add customElementRegistry option to Document.createElement and createElementNS r?#dom-core.

Wed, Jun 17, 2:57 PM

keithamus updated the diff for D293526: Bug 2018910 - Add customElementRegistry option to Document.createElement and createElementNS r?#dom-core.

Wed, Jun 17, 9:38 AM

Yesterday

keithamus updated the diff for D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Tue, Jun 16, 5:03 PM · testing-approved

keithamus updated the diff for D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Tue, Jun 16, 3:46 PM · testing-approved

keithamus added inline comments to D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Tue, Jun 16, 3:44 PM · testing-approved

keithamus requested review of D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Tue, Jun 16, 3:41 PM · testing-approved

keithamus updated the diff for D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Tue, Jun 16, 3:02 PM · testing-approved

keithamus requested review of D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Tue, Jun 16, 1:54 PM · testing-approved

keithamus planned changes to D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Tue, Jun 16, 12:58 PM · testing-approved

keithamus updated the diff for D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Tue, Jun 16, 12:58 PM · testing-approved

Mon, Jun 15

keithamus added inline comments to D293526: Bug 2018910 - Add customElementRegistry option to Document.createElement and createElementNS r?#dom-core.

Mon, Jun 15, 2:10 PM

keithamus updated the diff for D293526: Bug 2018910 - Add customElementRegistry option to Document.createElement and createElementNS r?#dom-core.

Mon, Jun 15, 2:06 PM

keithamus requested review of D293526: Bug 2018910 - Add customElementRegistry option to Document.createElement and createElementNS r?#dom-core.

Mon, Jun 15, 1:52 PM

keithamus accepted D306734: Bug 2009908 - Handle ::picker-icon in InspectorUtils::GetChildrenForNode. r=keithamus..

Thank you for this, nice catch!

Mon, Jun 15, 1:01 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

keithamus added inline comments to D305334: Bug 2045043 - Part 56 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/webscheduling r?#dom-core.

Mon, Jun 15, 10:56 AM

Sat, Jun 13

keithamus accepted D306605: Bug 2047372 - Fix field-sizing-placeholder-stretch to really match the reference. r=keithamus,#layout.

Nice catch. Thanks!

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of , , , , . Tip: this Firefox add-on makes it easy!

Sat, Jun 13, 3:33 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus planned changes to D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Sat, Jun 13, 12:30 PM · testing-approved

keithamus updated the diff for D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Sat, Jun 13, 12:30 PM · testing-approved

Fri, Jun 12

keithamus updated the diff for D293526: Bug 2018910 - Add customElementRegistry option to Document.createElement and createElementNS r?#dom-core.

Fri, Jun 12, 4:40 PM

keithamus abandoned D293527: Bug 2018910 - Part 2: Thread customElementRegistry through HTML parser element creation r?#dom-core,hsivonen.

This has been absorbed into the prior patch.

Fri, Jun 12, 4:40 PM · testing-approved

keithamus requested review of D293526: Bug 2018910 - Add customElementRegistry option to Document.createElement and createElementNS r?#dom-core.

Fri, Jun 12, 4:38 PM

Thu, Jun 11

keithamus planned changes to D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Thu, Jun 11, 10:42 PM · testing-approved

keithamus updated the diff for D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Thu, Jun 11, 10:42 PM · testing-approved

keithamus updated the diff for D304688: Bug 2044945 - Add <select> pseudo elements to devtools style inspector r=devtools-reviewers,nchevobbe.

Thu, Jun 11, 10:42 PM · testing-approved

keithamus updated the diff for D304450: Bug 2041004 - Make ::picker-icon generated content, add UA styles r?#layout.

Thu, Jun 11, 10:42 PM · testing-approved

keithamus planned changes to D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Thu, Jun 11, 5:25 PM · testing-approved

keithamus updated the diff for D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Thu, Jun 11, 5:25 PM · testing-approved

keithamus updated the diff for D304688: Bug 2044945 - Add <select> pseudo elements to devtools style inspector r=devtools-reviewers,nchevobbe.

Thu, Jun 11, 5:25 PM · testing-approved

keithamus updated the diff for D304450: Bug 2041004 - Make ::picker-icon generated content, add UA styles r?#layout.

Thu, Jun 11, 5:25 PM · testing-approved

keithamus updated the diff for D287096: Bug 2018902 - Part 2: Add CustomElementRegistry option to ShadowRoot init r?#dom-core.

Thu, Jun 11, 7:09 AM · testing-approved

keithamus planned changes to D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Thu, Jun 11, 7:00 AM · testing-approved

keithamus updated the diff for D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Thu, Jun 11, 7:00 AM · testing-approved

keithamus updated the diff for D304688: Bug 2044945 - Add <select> pseudo elements to devtools style inspector r=devtools-reviewers,nchevobbe.

Thu, Jun 11, 7:00 AM · testing-approved

keithamus updated the diff for D304450: Bug 2041004 - Make ::picker-icon generated content, add UA styles r?#layout.

Thu, Jun 11, 7:00 AM · testing-approved

Wed, Jun 10

keithamus planned changes to D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Wed, Jun 10, 7:32 PM · testing-approved

keithamus updated the diff for D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Wed, Jun 10, 7:32 PM · testing-approved

keithamus updated the diff for D304688: Bug 2044945 - Add <select> pseudo elements to devtools style inspector r=devtools-reviewers,nchevobbe.

Wed, Jun 10, 7:32 PM · testing-approved

keithamus updated the diff for D304450: Bug 2041004 - Make ::picker-icon generated content, add UA styles r?#layout.

Wed, Jun 10, 7:32 PM · testing-approved

keithamus planned changes to D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Wed, Jun 10, 3:25 PM · testing-approved

keithamus updated the diff for D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Wed, Jun 10, 3:25 PM · testing-approved

keithamus updated the diff for D304688: Bug 2044945 - Add <select> pseudo elements to devtools style inspector r=devtools-reviewers,nchevobbe.

Wed, Jun 10, 3:24 PM · testing-approved

keithamus updated the diff for D304450: Bug 2041004 - Make ::picker-icon generated content, add UA styles r?#layout.

Wed, Jun 10, 3:24 PM · testing-approved

keithamus updated the diff for D305339: Bug 2045044 - Part 2 - Ensure clang plugin for FINAL cycle collecting macros scans all of DOM r?#dom-core.

Wed, Jun 10, 2:52 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305848: Bug 2045043 - Part 61 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/abort r?#dom-core.

Wed, Jun 10, 2:52 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305338: Bug 2045043 - Part 60 - Ensure bindings uses isupports cycle collecting FINAL macros on final classes r?#dom-core.

Wed, Jun 10, 2:52 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305337: Bug 2045043 - Part 59 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/xslt r?#dom-core.

Wed, Jun 10, 2:52 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305336: Bug 2045043 - Part 58 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/xhr r?#dom-core.

Wed, Jun 10, 2:52 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305335: Bug 2045043 - Part 57 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/worklet r?#dom-core.

Wed, Jun 10, 2:52 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305334: Bug 2045043 - Part 56 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/webscheduling r?#dom-core.

Wed, Jun 10, 2:52 PM

keithamus updated the diff for D305333: Bug 2045043 - Part 55 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/webgpu r?#dom-core.

Wed, Jun 10, 2:52 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305332: Bug 2045043 - Part 54 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/webbrowserpersist r?#dom-core.

Wed, Jun 10, 2:52 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305331: Bug 2045043 - Part 53 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/webauthn r?#dom-core.

Wed, Jun 10, 2:52 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305330: Bug 2045043 - Part 52 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/vr r?#dom-core.

Wed, Jun 10, 2:52 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305329: Bug 2045043 - Part 51 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/urlpattern r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305328: Bug 2045043 - Part 50 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/storage r?#dom-core.

Wed, Jun 10, 2:51 PM · needs-testing-tag

keithamus updated the diff for D305327: Bug 2045043 - Part 49 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/simpledb r?#dom-core.

Wed, Jun 10, 2:51 PM · needs-testing-tag

keithamus updated the diff for D305326: Bug 2045043 - Part 48 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/serializers r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305325: Bug 2045043 - Part 47 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/security r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305324: Bug 2045043 - Part 46 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/reporting r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305323: Bug 2045043 - Part 45 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/quota r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305322: Bug 2045043 - Part 44 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/prototype r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305321: Bug 2045043 - Part 43 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/promise r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305320: Bug 2045043 - Part 42 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/power r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305319: Bug 2045043 - Part 41 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/permissions r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305318: Bug 2045043 - Part 40 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/payments r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305317: Bug 2045043 - Part 39 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/modelcontext r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305316: Bug 2045043 - Part 37 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/mls r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305315: Bug 2045043 - Part 36 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/midi r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305314: Bug 2045043 - Part 35 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/messagechannel r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305313: Bug 2045043 - Part 34 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/l10n r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305312: Bug 2045043 - Part 33 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/fs r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305311: Bug 2045043 - Part 32 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/indexedDB r?#dom-core.

Wed, Jun 10, 2:51 PM · needs-testing-tag

keithamus updated the diff for D305310: Bug 2045043 - Part 31 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/geolocation r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305309: Bug 2045043 - Part 30 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/filesystem r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305308: Bug 2045043 - Part 29 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/file r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305307: Bug 2045043 - Part 28 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/crypto r?#dom-core.

Wed, Jun 10, 2:51 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305306: Bug 2045043 - Part 27 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/commandhandler r?#dom-core.

Wed, Jun 10, 2:50 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305305: Bug 2045043 - Part 26 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/fetch r?#dom-core.

Wed, Jun 10, 2:50 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305304: Bug 2045043 - Part 25 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/credentialmanagement r?#dom-core.

Wed, Jun 10, 2:50 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305303: Bug 2045043 - Part 24 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/compression r?#dom-core.

Wed, Jun 10, 2:50 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305302: Bug 2045043 - Part 23 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/clients r?#dom-core.

Wed, Jun 10, 2:50 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305301: Bug 2045043 - Part 22 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/cache r?#dom-core.

Wed, Jun 10, 2:50 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305300: Bug 2045043 - Part 21 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/encoding r?#dom-core.

Wed, Jun 10, 2:50 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305299: Bug 2045043 - Part 20 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/onnx r?#dom-core.

Wed, Jun 10, 2:50 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305298: Bug 2045043 - Part 19 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/gamepad r?#dom-core.

Wed, Jun 10, 2:50 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305297: Bug 2045043 - Part 18 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/ipc r?#dom-core.

Wed, Jun 10, 2:50 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D305296: Bug 2045043 - Part 17 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/webtransport r?#dom-core.

Wed, Jun 10, 2:50 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus updated the diff for D304799: Bug 2045044 - Introduce clang plugin to check for using `_FINAL` macro variants for isupports r?#dom-core.

Wed, Jun 10, 2:50 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus planned changes to D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Wed, Jun 10, 1:58 PM · testing-approved

keithamus updated the diff for D305622: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r?#dom-core.

Wed, Jun 10, 1:58 PM · testing-approved

keithamus updated the diff for D304688: Bug 2044945 - Add <select> pseudo elements to devtools style inspector r=devtools-reviewers,nchevobbe.

Wed, Jun 10, 1:58 PM · testing-approved

keithamus updated the diff for D304450: Bug 2041004 - Make ::picker-icon generated content, add UA styles r?#layout.

Wed, Jun 10, 1:58 PM · testing-approved

keithamus updated the diff for D305339: Bug 2045044 - Part 2 - Ensure clang plugin for FINAL cycle collecting macros scans all of DOM r?#dom-core.

Wed, Jun 10, 12:46 PM · testing-exception-unchanged (Doesn't change behavior for users)

keithamus created D305848: Bug 2045043 - Part 61 - Fixup final classes using _FINAL cycle collecting isupports macro in dom/abort r?#dom-core.

Wed, Jun 10, 12:46 PM · testing-exception-unchanged (Doesn't change behavior for users)

Privacy · Cookies · Legal

URL: https://phabricator.services.mozilla.com/p/keithamus/

⇱ ♟ keithamus

keithamus (Keith Cirkel)
User

Projects

User Details

Recent Activity
View All

Today

Yesterday

Mon, Jun 15

Sat, Jun 13

Fri, Jun 12

Thu, Jun 11

Wed, Jun 10

URL: https://phabricator.services.mozilla.com/p/keithamus/

⇱ ♟ keithamus

keithamus (Keith Cirkel)User

Projects

User Details

Recent ActivityView All

Today

Yesterday

Mon, Jun 15

Sat, Jun 13

Fri, Jun 12

Thu, Jun 11

Wed, Jun 10

keithamus (Keith Cirkel)
User

Recent Activity
View All