Differential D306565
Bug 2019163 - [Nova] Update icon spacing in urlbar quick actions. AcceptedPublic Authored by adw on Fri, Jun 12, 9:46 PM. Referenced Files
Subscribers None
Details
Summary The Figma uses a literal 8px but it seems better to use a variable. Depends on D306367
Diff Detail
Unit TestsBroken
Event Timelineadw created this revision.Fri, Jun 12, 9:46 PM phab-bot published this revision for review.Fri, Jun 12, 9:47 PM phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)". phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. adw added a comment.Fri, Jun 12, 9:49 PM Comment ActionsHere are some screenshots from Windows 11 for comparison. Top: current implementation Middle: hardcoded 8px Bottom: adw attached a referenced file: F72570290: Screenshot 2026-06-12 at 2.33.09 PM.png. (Show Details)Fri, Jun 12, 9:49 PM dao accepted this revision.Sat, Jun 13, 9:35 AM This revision is now accepted and ready to land.Sat, Jun 13, 9:35 AM adw edited the summary of this revision. (Show Details) adw added a parent revision: D306367: Bug 2046297 - Update the legacy search bar border for Nova.. Comment ActionsGetting these several revisions lined up for landing, rebasing on Jules's patch adw added a child revision: D306574: Bug 2019164 - Update chiclets in the urlbar view for Nova..Wed, Jun 17, 3:21 AM adw removed a parent revision: D306443: WIP: Bug 2046942 - Make sure urlbar and tab Nova files are syncing with Figma.
Revision Contents
Diff 1301897 |
