VOOZH about

URL: https://phabricator.services.mozilla.com/D306565

⇱ ⚙ D306565 Bug 2019163 - [Nova] Update icon spacing in urlbar quick actions.


Bug 2019163 - [Nova] Update icon spacing in urlbar quick actions.
AcceptedPublic

Authored by adw on Fri, Jun 12, 9:46 PM.

Details

Reviewers
dao
Group Reviewers
desktop-theme-reviewers
urlbar-reviewers
Bugzilla Bug ID
2019163
Summary

The Figma uses a literal 8px but it seems better to use a variable.
matches 8px pretty well. On Windows 11 with standard scaling,
it ends up being 9px. On Mac, it's 8x, although it slightly changes the subpixel
rendering of the quick action's text compared to a hardcoded 8px.

Depends on D306367

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
default

Unit TestsBroken

TimeTest
0 mscode-review::general
WARNING: A generic error occurred in the code review bot.

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Comment Actions

Here are some screenshots from Windows 11 for comparison.

Top: current implementation

Middle: hardcoded 8px

Bottom:

This revision is now accepted and ready to land.Sat, Jun 13, 9:35 AM
adw edited the summary of this revision. (Show Details)
Comment Actions

Getting these several revisions lined up for landing, rebasing on Jules's patch

Revision Contents

PathSize
browser/
themes/
shared/
urlbar/
2 lines
CommitLocalParentsAuthorSummaryDate
36a92b1759e5856340156968a535feDrew Willcoxon
imported patch nova-quickactions-spacing-jules-2019163
Wed, Jun 17, 3:20 AM

Diff 1301897

browser/themes/shared/urlbar/view-nova.css

Loading...