Differential D67745
Bug 1623971 - part1: Propagate the MediaSession Artwork Images to MPRIS, r=alwu AbandonedPublic Authored by MeFisto94 on Mar 21 2020, 6:25 PM. Tags None Referenced Files
Diff Detail
Event TimelineMeFisto94 created this revision.Mar 21 2020, 6:25 PM phab-bot requested review of this revision.Mar 21 2020, 6:25 PM phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)". phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. MeFisto94 added a comment.Mar 21 2020, 6:35 PM Comment ActionsSo this is only a preliminary patch because it has a few problems that still need addressing:
Comment Actions First, now I still don't know what the best way is to requery the file location of branding icon. If the user modifies their diretory name, such as renaming to then this code would pass an invalid path to user. Second, now we have guaranteed that artwork won't be empty, if we want to replace the favicon icon with branding icon, we should modify the code in [1]. Also, if we would like to use the branding image, we should check what current version Firefox we're using and then select the correct image. @baku we would like to show the branding icon on the virtual control interface that system provides. Do you know what the best way is to get the file-based URL for those branding images? Or you know who we can ask about this topic?
alwu added a comment.Mar 24 2020, 12:07 AM Comment ActionsBTW, will we have a part2 for this bug? I guess you would implement the SMTC part in part2? MeFisto94 added a comment.EditedMar 24 2020, 12:10 AM Comment ActionsExactly, I am just working on the Windows Part to specify a local file. Edit: " Second, now we have guaranteed that artwork won't be empty, if we want to replace the favicon icon with branding icon, we should modify the code in [1]" Note that the MediaController in 1 probably doesn't know about the individual packaging of the user agent. For me there is a big difference between Ubuntu and Windows. But that all depends on what we can come up with, maybe there is a better solution from baku and others. alwu requested changes to this revision.Mar 28 2020, 12:14 AM Comment ActionsAccording to commet7 and comment8 [1] in bug1623971, we should not let external media framework load an URL because of both security and private concern. I will file a bug later to block this bug, which would provide a way to get an image bitmap from an image URL. That could be used for SMTC, but for MPRIS, we should only set the filed-based image, because MRPIS doesn't support an image bitmap as an input. [1] This revision now requires changes to proceed.Mar 28 2020, 12:14 AM MeFisto94 abandoned this revision.Sep 15 2020, 10:04 PM Comment ActionsWe've found another solution and the bug is closed, so let's abandon this revision
Revision Contents
Diff 248269 | |||||||||||||||||||||||||||||||||||||||
