Description
Description
Start a new book and click "add this page to book"
Notice:
load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0cg1aij:154 Use of "wgNamespaceNumber" is deprecated. Use mw.config instead. get @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0cg1aij:154 onclick @ W._J._Cash:53 load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0cg1aij:154 Use of "wgTitle" is deprecated. Use mw.config instead.
It appears this is using globals. This will break soon (@Krinkle probably can inform us on when) and if that happens this feature will be broken.
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Stop using wgNamespace and wgTitle globals | mediawiki/extensions/Collection | master | +8 -5 |
Related Objects
Related Objects
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T52039 Proposed changes to default settings (tracking) | |||
| Resolved | Ladsgroup | T72470 Remove legacy javascript globals | |||
| Declined | Dereckson | T72366 Set $wgLegacyJavaScriptGlobals = false on ptwiki and ptwikibooks | |||
| Resolved | Jdforrester-WMF | T35837 Set $wgLegacyJavaScriptGlobals = false by default | |||
| Resolved | phuedx | T177259 Collection using deprecated global variables |
- Mentioned In
- T72470: Remove legacy javascript globals
Event Timeline
Jdlrobson created this task.Oct 2 2017, 10:40 PM
gerritbot subscribed.Oct 2 2017, 10:47 PM
Comment ActionsChange 381892 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Collection@master] Stop using wgNamespace and wgTitle globals
Krinkle added a parent task: T35837: Set $wgLegacyJavaScriptGlobals = false by default.Oct 2 2017, 11:19 PM
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.Oct 3 2017, 4:04 PM
ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog-Archived board.Oct 10 2017, 12:25 PM
Jdlrobson added a project: Readers-Web-Kanbanana-Board-Old.
MBinder_WMF moved this task from 2017-18 Q1 to 2017-18 Q2 on the Web-Team-Backlog-Archived board.Oct 10 2017, 7:00 PM
Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Oct 11 2017, 7:39 PM
• bmansurov moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Oct 12 2017, 6:57 PM
gerritbot added a comment.Oct 12 2017, 7:01 PM
Comment ActionsChange 381892 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Stop using wgNamespace and wgTitle globals
phuedx claimed this task.
phuedx subscribed.
Comment ActionsI don't see any warnings on Special:Book or on pages where the book creator banner is inserted 🎉🎉🎉
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits