a new page is created
- it is in the main namespace (0); page.page_namespace = 0
- the page title contains the namespace prefix; page.page_title = 'User talk:Hgzh' (normally, no namespace prefix is added in this field)
- the interwiki prefix is stripped somewhere
- example: https://de.wikipedia.beta.wmflabs.org/wiki/Special:Redirect/page/4809
as this new page contains the namespace prefix in its title, it is only accessable via curid
- every ui action refers to the actual talk page (links, protect/delete etc.) instead of the previously created page as they seem to rely on the page_title
- the new page can only be deleted using the API with curid

API query:

API response:

{
 "redirects": [
 {
 "from": "Benutzer:Hgzh/a",
 "to": "meta:User talk:Hgzh"
 }
 ],
 "edit": {
 "new": "",
 "result": "Success",
 "pageid": 4809,
 "title": "meta:User talk:Hgzh",
 "contentmodel": "wikitext",
 "oldrevid": 0,
 "newrevid": 25355,
 "newtimestamp": "2019-11-28T15:43:19Z"
 }
}

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch
ApiEditPage: Test for bad redirect targets	SBassett	mediawiki/core	REL1_33	+16 -0
ApiEditPage: Test for bad redirect targets	SBassett	mediawiki/core	REL1_32	+16 -0
ApiEditPage: Test for bad redirect targets	SBassett	mediawiki/core	REL1_31	+16 -0
ApiEditPage: Test for bad redirect targets	SBassett	mediawiki/core	REL1_34	+17 -1
ApiEditPage: Test for bad redirect targets	Anomie	mediawiki/core	master	+17 -1
ApiEditPage: Test for bad redirect targets	Anomie	mediawiki/core	wmf/1.35.0-wmf.5	+17 -1
ApiEditPage: Test for bad redirect targets	Anomie	mediawiki/core	wmf/1.35.0-wmf.8	+17 -1

Customize query in gerrit

Related Objects

		Status
Resolved	None	T95277 Erroneous Category:Category:Pages_with_script_errors
Resolved	Steinsplitter	T111594 Commons file stuck in category
Resolved	None	T87645 Existing pages without ability to reach and obviously wrong namespace
Resolved	Anomie	T239428 API edit on page with non-resolvable redirect and redirect=1 creates page with invalid title

Mentioned In: T87645: Existing pages without ability to reach and obviously wrong namespace
T239466: Possible to circumvent title-blacklist (CVE-2019-19709)
Mentioned Here: T239466: Possible to circumvent title-blacklist (CVE-2019-19709)

Event Timeline

hgzh created this task.Nov 28 2019, 4:11 PM

Restricted Application added a project: Platform Engineering. · View Herald TranscriptNov 28 2019, 4:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Bugreporter added a parent task: T87645: Existing pages without ability to reach and obviously wrong namespace.Nov 28 2019, 6:22 PM

Bugreporter mentioned this in T239466: Possible to circumvent title-blacklist (CVE-2019-19709).Nov 29 2019, 11:35 AM

Bugreporter subscribed.

Comment Actions

This results in security issue (T239466: Possible to circumvent title-blacklist (CVE-2019-19709)).

Giftpflanze subscribed.Nov 29 2019, 4:19 PM

Umherirrender subscribed.Nov 29 2019, 7:59 PM

Comment Actions

After resolving the redirect in ApiEditPage there is no check for Title::isExternal or Title::canExist (to check for Special or Media namespace redirect targets)

Needs some new apierror texts where I am unsure how to name it

Schniggendiller subscribed.Nov 30 2019, 8:44 AM

Anomie claimed this task.Dec 2 2019, 2:37 PM

Anomie edited projects, added: Platform Team Workboards (Clinic Duty Team); removed: Platform Engineering.

Comment Actions

In T239428#5701358, @Bugreporter wrote:

This results in security issue (T239466: Possible to circumvent title-blacklist (CVE-2019-19709)).

You probably shouldn't proclaim that on a public task.

gerritbot added a comment.Dec 2 2019, 2:41 PM

Comment Actions

Change 554084 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] ApiEditPage: Test for bad redirect targets

https://gerrit.wikimedia.org/r/554084

gerritbot added a project: Patch-For-Review.Dec 2 2019, 2:41 PM

Anomie moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Dec 2 2019, 2:41 PM

Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.

• WDoranWMF triaged this task as High priority.Dec 4 2019, 7:19 PM

gerritbot added a comment.Dec 4 2019, 7:35 PM

Comment Actions

Change 554084 merged by jenkins-bot:
[mediawiki/core@master] ApiEditPage: Test for bad redirect targets

https://gerrit.wikimedia.org/r/554084

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 4 2019, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 4 2019, 8:11 PM

• mobrovac moved this task from Waiting for Review to Waiting for deployment on the Platform Team Workboards (Clinic Duty Team) board.Dec 5 2019, 1:18 PM

gerritbot added a comment.Dec 5 2019, 3:03 PM

Comment Actions

Change 554885 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@wmf/1.35.0-wmf.5] ApiEditPage: Test for bad redirect targets

https://gerrit.wikimedia.org/r/554885

gerritbot added a project: Patch-For-Review.Dec 5 2019, 3:03 PM

Comment Actions

Change 554886 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@wmf/1.35.0-wmf.8] ApiEditPage: Test for bad redirect targets

https://gerrit.wikimedia.org/r/554886

gerritbot added a comment.Dec 5 2019, 3:15 PM

Comment Actions

Change 554885 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.5] ApiEditPage: Test for bad redirect targets

https://gerrit.wikimedia.org/r/554885

gerritbot added a comment.Dec 5 2019, 3:16 PM

Comment Actions

Change 554886 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.8] ApiEditPage: Test for bad redirect targets

https://gerrit.wikimedia.org/r/554886

Stashbot added a comment.Dec 5 2019, 3:17 PM

Comment Actions

Mentioned in SAL (#wikimedia-operations) [2019-12-05T15:17:31Z] <anomie@deploy1001> Started scap: Backporting fix for T239428

Stashbot added a comment.Dec 5 2019, 3:50 PM

Comment Actions

Mentioned in SAL (#wikimedia-operations) [2019-12-05T15:50:51Z] <anomie@deploy1001> Finished scap: Backporting fix for T239428 (duration: 33m 20s)

Anomie closed this task as Resolved.Dec 5 2019, 3:58 PM

Anomie moved this task from Waiting for deployment to Done on the Platform Team Workboards (Clinic Duty Team) board.

gerritbot added a comment.Dec 5 2019, 4:00 PM

Comment Actions

Change 554900 had a related patch set uploaded (by SBassett; owner: Anomie):
[mediawiki/core@REL1_34] ApiEditPage: Test for bad redirect targets

https://gerrit.wikimedia.org/r/554900

ReleaseTaggerBot edited projects, added: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05); removed: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 5 2019, 4:00 PM

gerritbot added a comment.Dec 5 2019, 4:40 PM

Comment Actions

Change 554900 merged by jenkins-bot:
[mediawiki/core@REL1_34] ApiEditPage: Test for bad redirect targets

https://gerrit.wikimedia.org/r/554900

ReleaseTaggerBot added a project: MW-1.34-notes.Dec 5 2019, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 5 2019, 5:10 PM

gerritbot added a comment.Dec 10 2019, 11:03 PM

Comment Actions

Change 556284 had a related patch set uploaded (by SBassett; owner: Anomie):
[mediawiki/core@REL1_33] ApiEditPage: Test for bad redirect targets

https://gerrit.wikimedia.org/r/556284

gerritbot added a project: Patch-For-Review.Dec 10 2019, 11:03 PM

gerritbot added a comment.Dec 10 2019, 11:06 PM

Comment Actions

Change 556286 had a related patch set uploaded (by SBassett; owner: Anomie):
[mediawiki/core@REL1_32] ApiEditPage: Test for bad redirect targets

https://gerrit.wikimedia.org/r/556286

gerritbot added a comment.Dec 10 2019, 11:11 PM

Comment Actions

Change 556287 had a related patch set uploaded (by SBassett; owner: Anomie):
[mediawiki/core@REL1_31] ApiEditPage: Test for bad redirect targets

https://gerrit.wikimedia.org/r/556287

gerritbot added a comment.Dec 10 2019, 11:36 PM

Comment Actions

Change 556287 merged by jenkins-bot:
[mediawiki/core@REL1_31] ApiEditPage: Test for bad redirect targets

https://gerrit.wikimedia.org/r/556287

gerritbot added a comment.Dec 10 2019, 11:38 PM

Comment Actions

Change 556286 merged by jenkins-bot:
[mediawiki/core@REL1_32] ApiEditPage: Test for bad redirect targets

https://gerrit.wikimedia.org/r/556286

gerritbot added a comment.Dec 10 2019, 11:40 PM

Comment Actions

Change 556284 merged by jenkins-bot:
[mediawiki/core@REL1_33] ApiEditPage: Test for bad redirect targets

https://gerrit.wikimedia.org/r/556284

ReleaseTaggerBot added projects: MW-1.32-notes, MW-1.31-release-notes, MW-1.33-notes.Dec 11 2019, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 11 2019, 12:11 AM

Bugreporter mentioned this in T87645: Existing pages without ability to reach and obviously wrong namespace.Mar 18 2020, 7:46 PM

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits

URL: https://phabricator.wikimedia.org/T239428

⇱ ⚓ T239428 API edit on page with non-resolvable redirect and redirect=1 creates page with invalid title

API edit on page with non-resolvable redirect and redirect=1 creates page with invalid title
Closed, ResolvedPublic
Actions

Description

Details

Related Objects

Event Timeline

URL: https://phabricator.wikimedia.org/T239428

⇱ ⚓ T239428 API edit on page with non-resolvable redirect and redirect=1 creates page with invalid title

API edit on page with non-resolvable redirect and redirect=1 creates page with invalid titleClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

API edit on page with non-resolvable redirect and redirect=1 creates page with invalid title
Closed, ResolvedPublic
Actions