Description
Something that came up whilst doing the UTC afternoon backport deployment window: It would be great to flag whether a commit will require a CDB rebuild, which is painful
The ideal would be to warn folks before merges a patch that they're in for a long deployment. This could be tricky/impossible to do deterministically.
But as soon as scap knows that we're going to do a full image rebuild, warning the users would be great.
Details
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| backport: Warn when a l10n-touching change is backported | repos/releng/scap!1187 | dancy | master-I8eff33db223af1cf61d5a0ddd912b602e3d0864e | master |
Event Timeline
But as soon as scap knows that we're going to do a full image rebuild, warning the users would be great.
Do you mean writing a (likely to be overlooked) line of log output while is running, or do you mean an interactive warning which requires the deployer to respond?
In T397089#10920330, @dancy wrote:Do you mean writing a (likely to be overlooked) line of log output while is running, or do you mean an interactive warning which requires the deployer to respond?
More the latter. Ideally, this is a pre-merge signal to the deployer like "This might take a while. Bring a Good Book."
In the case where the deployer is experienced, they can optimize the deployment window to get as many patches deployed as possible.
In the case where the deployer is inexperienced, they've been primed to expect a significantly-longer-than-usual deployment process.
This could be tricky/impossible to do deterministically.
AIUI there's really only one way to be 100% sure and that's immediately after we've run the maintenance script during but that we might be able to guess by checking whether the patch modifies files in the directory. We could, therefore, guess and flag pre-merge and then notify when we've run the maintenance script.
dancy opened https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/1187
backport: Warn when a l10n-touching change is backported
thcipriani merged https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/1187
backport: Warn when a l10n-touching change is backported