"Disgusting" Linux sched_ext Source Code Restructured Following Complaint By Linus Torvalds
Last week the main set of sched_ext changes were merged for Linux 7.2 that included continued work on sub-scheduler support. While Linus Torvalds didn't object to any of the features being worked on for this extensible scheduler framework that relies on user-space BPF programs, he was frustrated by the layout of the new C source files and remarked, "please don't do this disgusting thing...proper hierarchical filesystems have been available since 1965."
Linus Torvalds did not like in last week's sched_ext pull request that several new ext_ pre-fixed C code and header files were made in kernel//sched as opposed to just making a new sub-directory of kernel/sched like kernel/sched/ext/ to avoid prefixing the many individual files.
Torvalds merged the code but commented:
In turn sent out earlier today was a new pull request to reorganize the source tree for sched_ext in making use of kernel/sched/ext/ instead of littering a bunch of ext_* files in the common scheduler directory.
Linus Torvalds already merged the code to restructure sched_ext files.
Linus Torvalds did not like in last week's sched_ext pull request that several new ext_ pre-fixed C code and header files were made in kernel//sched as opposed to just making a new sub-directory of kernel/sched like kernel/sched/ext/ to avoid prefixing the many individual files.
Torvalds merged the code but commented:
"> create mode 100644 kernel/sched/ext_arena.c
> create mode 100644 kernel/sched/ext_arena.h
> create mode 100644 kernel/sched/ext_cid.c
> create mode 100644 kernel/sched/ext_cid.h
> create mode 100644 kernel/sched/ext_types.h
Please don't do this disgusting thing.
There's a reason we have subdirectories: it's to group files together and separate them out
Using name prefixing instead of directories is disgusting and wrong. If you have this many random sched-ext files, it damn well should be cleaned up and not be this kind of mess.
I've pulled this, but under protest. Proper hierarchical filesystems have been available since 1965."
In turn sent out earlier today was a new pull request to reorganize the source tree for sched_ext in making use of kernel/sched/ext/ instead of littering a bunch of ext_* files in the common scheduler directory.
Linus Torvalds already merged the code to restructure sched_ext files.