mconley retitled this revision from WIP: Bug 1999334 - Part 2: Remove contentSearchUI (non-handoff content search mechanism) and tests. r?#home-newtab-reviewers!,#search-reviewers! to Bug 1999334 - Part 2: Remove contentSearchUI (non-handoff content search mechanism) and tests. r?#home-newtab-reviewers!,#search-reviewers!.

mconley added reviewers: home-newtab-reviewers-rotation, search-reviewers.

Herald added a reviewer: desktop-theme-reviewers. · View Herald TranscriptNov 24 2025, 9:07 PM

Herald added a reviewer: urlbar-reviewers. · View Herald Transcript

Harbormaster completed remote builds in B879197: Diff 1162064.Nov 24 2025, 9:26 PM

mconley updated this revision to Diff 1162433.Nov 25 2025, 2:47 PM

Comment Actions

Fix some more tests that try caught.

Harbormaster completed remote builds in B879511: Diff 1162433.Nov 25 2025, 3:08 PM

mconley planned changes to this revision.Nov 25 2025, 5:30 PM

mconley updated this revision to Diff 1162571.

mconley retitled this revision from Bug 1999334 - Part 2: Remove contentSearchUI (non-handoff content search mechanism) and tests. r?#home-newtab-reviewers!,#search-reviewers! to WIP: Bug 1999334 - Part 2: Remove contentSearchUI (non-handoff content search mechanism) and tests. r?#home-newtab-reviewers!,#search-reviewers!.

Comment Actions

More fixups required, it seems.

Harbormaster completed remote builds in B879585: Diff 1162571.Nov 25 2025, 5:49 PM

mconley requested review of this revision.Nov 26 2025, 6:35 PM

mconley updated this revision to Diff 1163100.

Comment Actions

Made train-hop compatible now.

Harbormaster completed remote builds in B879988: Diff 1163100.Nov 26 2025, 6:50 PM

mconley updated this revision to Diff 1163761.Nov 27 2025, 7:22 PM

Comment Actions

Rebase, fix some tests that I apparently missed.

Harbormaster completed remote builds in B880498: Diff 1163761.Nov 27 2025, 7:37 PM

dao removed a reviewer: desktop-theme-reviewers.Nov 28 2025, 8:58 AM

Standard8 accepted this revision.Nov 28 2025, 2:55 PM

Standard8 added a project: testing-approved.

Comment Actions

Thank you, this looks good. As discussed there's some additional cleanup in ContentSearchParent that we can do, but we'll handle that in a follow-up.

mconley updated this revision to Diff 1164115.Nov 28 2025, 3:01 PM

Comment Actions

Rebase, fix the last remaining flake-y tests that try revealed.

Harbormaster completed remote builds in B880822: Diff 1164115.Nov 28 2025, 3:15 PM

mconley updated this revision to Diff 1166255.Dec 3 2025, 3:36 PM

Comment Actions

Rebase, address review feedback.

Harbormaster failed remote builds in B882653: Diff 1166255!Dec 3 2025, 5:12 PM

mconley updated this revision to Diff 1168964.Dec 8 2025, 7:16 PM

Comment Actions

Rebase.

Harbormaster completed remote builds in B884985: Diff 1168964.Dec 8 2025, 7:35 PM

scunnane mentioned this in D276156: Bug 2003294 - Remove now unnecessary messages from ContentSearchParent. r?#search-reviewers!.Dec 12 2025, 6:25 PM

mconley updated this revision to Diff 1175212.Dec 17 2025, 4:57 PM

Comment Actions

Rebase, take patches for bug 2004784 out of WIP.

Harbormaster completed remote builds in B890015: Diff 1175212.Dec 17 2025, 5:11 PM

thecount added a subscriber: thecount.Dec 17 2025, 6:09 PM

thecount added inline comments.

browser/app/profile/firefox.js
2092	This there any specific reason why this had to be removed in Part 2, or was it just something you could have done in Part 1, and you didn't notice it until you were working on part 2?

mconley updated this revision to Diff 1175507.Dec 17 2025, 9:27 PM

Comment Actions

Rebase, address some review feedback.

Herald added a reviewer: frontend-codestyle-reviewers. · View Herald TranscriptDec 17 2025, 9:27 PM

mconley added inline comments.Dec 17 2025, 9:28 PM

browser/app/profile/firefox.js
2092	The only rationale being that this was also the patch that removed all of the _usages_ of the pref (some of the search tests used it). So once those usages were gone here, I removed the pref.

thecount accepted this revision.Dec 17 2025, 9:30 PM

thecount added inline comments.

browser/app/profile/firefox.js
2092	makes perfect sense, thanks.

Harbormaster completed remote builds in B890251: Diff 1175507.Dec 17 2025, 9:57 PM

Standard8 accepted this revision.Dec 18 2025, 11:18 AM

Comment Actions

r=me for the additional change

This revision is now accepted and ready to land.Dec 18 2025, 11:18 AM

mconley updated this revision to Diff 1176065.Dec 18 2025, 3:50 PM

Comment Actions

Rebase on latest main@origin.

Harbormaster completed remote builds in B890657: Diff 1176065.Dec 18 2025, 4:14 PM

mconley marked 2 inline comments as done.Dec 18 2025, 5:24 PM

Closed by commit rFIREFOXAUTOLAND77be0140471e: Bug 1999334 - Part 2: Remove contentSearchUI (non-handoff content search… (authored by mconley). · Explain WhyDec 18 2025, 8:08 PM

This revision was automatically updated to reflect the committed changes.

mconley added a commit: rFIREFOXAUTOLAND77be0140471e: Bug 1999334 - Part 2: Remove contentSearchUI (non-handoff content search….

mconley removed a child revision: D273882: Bug 2002027 - Part 1: Make contentSearchHandoffUI a module..Jan 5 2026, 2:21 PM

mconley mentioned this in rFIREFOXBETA77be0140471e: Bug 1999334 - Part 2: Remove contentSearchUI (non-handoff content search….Jan 12 2026, 1:56 PM

mconley mentioned this in rFIREFOXRELEASE77be0140471e: Bug 1999334 - Part 2: Remove contentSearchUI (non-handoff content search….Feb 16 2026, 3:39 PM

Revision Contents
Changeset List

Path

Size

browser/

actors/

AboutNewTabChild.sys.mjs

1 line

app/

profile/

firefox.js

3 lines

components/

search/

content/

contentSearchUI.css

contentSearchUI.js

jar.mn

2 lines

test/

browser/

POSTSearchEngine.xml

browser.toml

24 lines

browser_aboutHome_search_POST.js

browser_aboutHome_search_composing.js

browser_aboutHome_search_suggestion.js

browser_contentSearchUI.js

browser_contentSearchUI_default.js

56 lines

telemetry/

5 lines

browser_search_telemetry_aboutHome.js

browser_search_telemetry_content.js

72 lines

browser_search_telemetry_sources.js

4 lines

browser_search_telemetry_sources_about.js

browser_search_telemetry_sources_webextension.js

4 lines

urlbar/

tests/

browser/

browser_urlbar_telemetry_handoff.js

9 lines

extensions/

newtab/

bin/

render-activity-stream-html.js

5 lines

data/

content/

abouthomecache/

page.html.template

1 line

prerendered/

activity-stream-debug.html

5 lines

activity-stream-noscripts.html

4 lines

activity-stream.html

5 lines

stylelint-rollouts.config.js

2 lines

Commit	Tree	Parents	Author	Summary	Date
77be0140471e	078e6a20d3cb	Mike Conley	Bug 1999334 - Part 2: Remove contentSearchUI (non-handoff content search… (Show More…)

	Status	Author	Revision
Closed	mconley	D273881 Bug 1999334 - Part 2: Remove contentSearchUI (non-handoff content search mechanism) and tests. r?#home-newtab-reviewers!,#search-reviewers!
Closed	mconley	D273880 Bug 1999334 - Part 1: Get rid of search handoff preference, and non-handoff support in newtab. r?#home-newtab-reviewers!

D306022 Bug 2034921 - Re-enable smart cursor and integrate with Smart Window r=#ai-frontend-reviewers
·Reviewers: Restricted Project, flozia, bolsson
Wed, Jun 17, 10:42 PM
Author: echa
D307400 Bug 2048359 - Add Resource Monitor New Tab widget r?maxx
·Reviewers: maxx, Restricted Project, desktop-theme-reviewers
Wed, Jun 17, 7:52 PM
Author: tthorne
D307405 Bug 2048359 - Add Resource Monitor New Tab widget r?maxx
·Reviewers: maxx, Restricted Project, desktop-theme-reviewers
Wed, Jun 17, 7:40 PM
Author: tthorne
D307390 Bug 1979722 - Remove browser.urlbar.deduplication.thresholdDays pref. r=mbeier
·Reviewers: mbeier, urlbar-reviewers
Wed, Jun 17, 7:08 PM
Author: dong
D306821 WIP: Bug 2047653 - Add a dropdown for switching sidebar panels when sidebar.revamp is true
·No Reviewers
Wed, Jun 17, 7:06 PM
Author: kcochrane
D305808 Bug 2032645 - Unify Windows first run launch-on-login in browser-before-ui-startup, off by default, enabled via Nimbus. r?iholmes
·Reviewers: iholmes, mstriemer
Wed, Jun 17, 6:10 PM
Author: drubino
D306859 Bug 2033325 - (part 1) Probe backup directory access to trigger permission prompts at appropriate instances. r=#backup-reviewers
·Reviewers: Restricted Project, omc-reviewers, aborondo, iain
Wed, Jun 17, 5:28 PM
Author: hsohaney
D299756 Bug 2037948 - Add search_query tool backed by Exa search API
·Reviewers: bjohns, simonf
Wed, Jun 17, 4:59 PM
Author: gazhibekova
D303319 Bug 2040596 - Add new pref to display a Kit image behind the set default browser button in Windows Settings and expose it via Nimbus r=cdupuis,nrishel
·Reviewers: cdupuis, nrishel
Wed, Jun 17, 3:27 PM
Author: aborondo
D303207 Bug 1736955 - Add pref to trim www. from URLs. r=dao
·Reviewers: dao, urlbar-reviewers
Wed, Jun 17, 3:06 PM
Author: dong

Diff 1176283

View Options

browser/actors/AboutNewTabChild.sys.mjs

View Options

browser/app/profile/firefox.js

View Options

browser/components/search/content/contentSearchUI.css

View Options

browser/components/search/content/contentSearchUI.js

View Options

browser/components/search/jar.mn

View Options

browser/components/search/test/browser/POSTSearchEngine.xml

View Options

browser/components/search/test/browser/browser.toml

View Options

browser/components/search/test/browser/browser_aboutHome_search_POST.js

View Options

browser/components/search/test/browser/browser_aboutHome_search_composing.js

View Options

browser/components/search/test/browser/browser_aboutHome_search_suggestion.js

View Options

browser/components/search/test/browser/browser_contentSearchUI.js

View Options

browser/components/search/test/browser/browser_contentSearchUI_default.js

View Options

browser/components/search/test/browser/contentSearchUI.html

View Options

browser/components/search/test/browser/contentSearchUI.js

View Options

browser/components/search/test/browser/print_postdata.sjs

View Options

browser/components/search/test/browser/telemetry/browser.toml

View Options

browser/components/search/test/browser/telemetry/browser_search_telemetry_aboutHome.js

View Options

browser/components/search/test/browser/telemetry/browser_search_telemetry_content.js

View Options

browser/components/search/test/browser/telemetry/browser_search_telemetry_sources.js

View Options

browser/components/search/test/browser/telemetry/browser_search_telemetry_sources_about.js

View Options

browser/components/search/test/browser/telemetry/browser_search_telemetry_sources_webextension.js

View Options

browser/components/urlbar/tests/browser/browser_urlbar_telemetry_handoff.js

View Options

browser/extensions/newtab/bin/render-activity-stream-html.js

View Options

browser/extensions/newtab/data/content/abouthomecache/page.html.template

View Options

browser/extensions/newtab/prerendered/activity-stream-debug.html

View Options

browser/extensions/newtab/prerendered/activity-stream-noscripts.html

View Options

browser/extensions/newtab/prerendered/activity-stream.html

View Options

stylelint-rollouts.config.js

Privacy · Cookies · Legal

URL: https://phabricator.services.mozilla.com/D273881

⇱ ⚙ D273881 Bug 1999334 - Part 2: Remove contentSearchUI (non-handoff content search mechanism) and tests. r?#home-newtab-reviewers!,#search-reviewers!

Bug 1999334 - Part 2: Remove contentSearchUI (non-handoff content search mechanism) and tests. r?#home-newtab-reviewers!,#search-reviewers!
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1176283

browser/actors/AboutNewTabChild.sys.mjs

browser/app/profile/firefox.js

browser/components/search/content/contentSearchUI.css

browser/components/search/content/contentSearchUI.js

browser/components/search/jar.mn

browser/components/search/test/browser/POSTSearchEngine.xml

browser/components/search/test/browser/browser.toml

browser/components/search/test/browser/browser_aboutHome_search_POST.js

browser/components/search/test/browser/browser_aboutHome_search_composing.js

browser/components/search/test/browser/browser_aboutHome_search_suggestion.js

browser/components/search/test/browser/browser_contentSearchUI.js

browser/components/search/test/browser/browser_contentSearchUI_default.js

browser/components/search/test/browser/contentSearchUI.html

browser/components/search/test/browser/contentSearchUI.js

browser/components/search/test/browser/print_postdata.sjs

browser/components/search/test/browser/telemetry/browser.toml

browser/components/search/test/browser/telemetry/browser_search_telemetry_aboutHome.js

browser/components/search/test/browser/telemetry/browser_search_telemetry_content.js

browser/components/search/test/browser/telemetry/browser_search_telemetry_sources.js

browser/components/search/test/browser/telemetry/browser_search_telemetry_sources_about.js

browser/components/search/test/browser/telemetry/browser_search_telemetry_sources_webextension.js

browser/components/urlbar/tests/browser/browser_urlbar_telemetry_handoff.js

browser/extensions/newtab/bin/render-activity-stream-html.js

browser/extensions/newtab/data/content/abouthomecache/page.html.template

browser/extensions/newtab/prerendered/activity-stream-debug.html

browser/extensions/newtab/prerendered/activity-stream-noscripts.html

browser/extensions/newtab/prerendered/activity-stream.html

stylelint-rollouts.config.js

URL: https://phabricator.services.mozilla.com/D273881

⇱ ⚙ D273881 Bug 1999334 - Part 2: Remove contentSearchUI (non-handoff content search mechanism) and tests. r?#home-newtab-reviewers!,#search-reviewers!

Bug 1999334 - Part 2: Remove contentSearchUI (non-handoff content search mechanism) and tests. r?#home-newtab-reviewers!,#search-reviewers!ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1176283

browser/actors/AboutNewTabChild.sys.mjs

browser/app/profile/firefox.js

browser/components/search/content/contentSearchUI.css

browser/components/search/content/contentSearchUI.js

browser/components/search/jar.mn

browser/components/search/test/browser/POSTSearchEngine.xml

browser/components/search/test/browser/browser.toml

browser/components/search/test/browser/browser_aboutHome_search_POST.js

browser/components/search/test/browser/browser_aboutHome_search_composing.js

browser/components/search/test/browser/browser_aboutHome_search_suggestion.js

browser/components/search/test/browser/browser_contentSearchUI.js

browser/components/search/test/browser/browser_contentSearchUI_default.js

browser/components/search/test/browser/contentSearchUI.html

browser/components/search/test/browser/contentSearchUI.js

browser/components/search/test/browser/print_postdata.sjs

browser/components/search/test/browser/telemetry/browser.toml

browser/components/search/test/browser/telemetry/browser_search_telemetry_aboutHome.js

browser/components/search/test/browser/telemetry/browser_search_telemetry_content.js

browser/components/search/test/browser/telemetry/browser_search_telemetry_sources.js

browser/components/search/test/browser/telemetry/browser_search_telemetry_sources_about.js

browser/components/search/test/browser/telemetry/browser_search_telemetry_sources_webextension.js

browser/components/urlbar/tests/browser/browser_urlbar_telemetry_handoff.js

browser/extensions/newtab/bin/render-activity-stream-html.js

browser/extensions/newtab/data/content/abouthomecache/page.html.template

browser/extensions/newtab/prerendered/activity-stream-debug.html

browser/extensions/newtab/prerendered/activity-stream-noscripts.html

browser/extensions/newtab/prerendered/activity-stream.html

stylelint-rollouts.config.js

Bug 1999334 - Part 2: Remove contentSearchUI (non-handoff content search mechanism) and tests. r?#home-newtab-reviewers!,#search-reviewers!
ClosedPublic
Actions

Revision Contents
Changeset List