Differential D307405
Bug 2048359 - Add Resource Monitor New Tab widget r?maxx Needs ReviewPublic Authored by tthorne on Wed, Jun 17, 7:17 PM.
Details
Summary Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Diff Detail
Event Timelinetthorne created this revision.Wed, Jun 17, 7:17 PM phab-bot published this revision for review.Wed, Jun 17, 7:17 PM phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)". phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. Comment Actions This revision makes changes to files both inside and in files outside of it. The New Tab page for Firefox Desktop supports train-hopping — a mechanism that allows New Tab code to be deployed to Beta and Release channels independently of the standard release train. Cross-layer changes can break train-hop compatibility, which may block New Tab deployments until fixes reach Release through normal channels. If your change modifies platform code that browser/extensions/newtab depends on (such as module URIs, DOM APIs, or Nimbus feature definitions), please check whether a compatibility shim is needed. Shims should be marked with a comment indicating the Firefox version that must reach Release before the shim can be removed. If your change is unrelated to the New Tab page's train-hop compatibility (for example, it only touches tests or documentation), you can possibly disregard this message - but if you are unsure whether your change affects train-hop compatibility, please ensure that someone from the home-newtab-reviewers-rotation review group has a chance to review before landing. phab-bot removed a reviewer: home-newtab-reviewers-rotation. phab-bot added a subscriber: home-newtab-reviewers-rotation. Comment Actions Code analysis found 18 defects in diff 1302825:
IMPORTANT: Found 18 defects (error level) that must be fixed before landing.
You can run this analysis locally with: If you see a problem in this automated review, please report it here. You can view these defects in the Diff Detail section of Phabricator diff 1302825.
Revision Contents
Diff 1302825 browser/extensions/newtab/content-src/components/CustomizeMenu/ContentSection/ContentSection.jsxLoading... browser/extensions/newtab/content-src/components/CustomizeMenu/CustomizeMenu.jsxLoading... browser/extensions/newtab/content-src/components/Nova/CustomizeMenu/WidgetsManagementPanel/WidgetsManagementPanel.jsxLoading... browser/extensions/newtab/content-src/components/Widgets/ResourceMonitor/ResourceMonitor.jsxLoading... browser/extensions/newtab/content-src/components/Widgets/ResourceMonitor/_ResourceMonitor.scssLoading... browser/extensions/newtab/content-src/components/Widgets/WidgetsComponentRegistry.jsxLoading... browser/extensions/newtab/test/jest/content-src/components/Widgets/ResourceMonitor.test.jsxLoading... |
