VOOZH about

URL: https://phabricator.services.mozilla.com/D307405

⇱ ⚙ D307405 Bug 2048359 - Add Resource Monitor New Tab widget r?maxx


Bug 2048359 - Add Resource Monitor New Tab widget r?maxx
Needs ReviewPublic

Authored by tthorne on Wed, Jun 17, 7:17 PM.

Details

Reviewers
maxx
Group Reviewers
Restricted Project
desktop-theme-reviewers
Bugzilla Bug ID
2048359
Summary

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Comment Actions

This revision makes changes to files both inside and in files outside of it. The New Tab page for Firefox Desktop supports train-hopping — a mechanism that allows New Tab code to be deployed to Beta and Release channels independently of the standard release train. Cross-layer changes can break train-hop compatibility, which may block New Tab deployments until fixes reach Release through normal channels.

If your change modifies platform code that browser/extensions/newtab depends on (such as module URIs, DOM APIs, or Nimbus feature definitions), please check whether a compatibility shim is needed. Shims should be marked with a comment indicating the Firefox version that must reach Release before the shim can be removed.

If your change is unrelated to the New Tab page's train-hop compatibility (for example, it only touches tests or documentation), you can possibly disregard this message - but if you are unsure whether your change affects train-hop compatibility, please ensure that someone from the home-newtab-reviewers-rotation review group has a chance to review before landing.

Comment Actions

Code analysis found 18 defects in diff 1302825:

  • 2 defects found by fluent-lint (Mozlint)
  • 2 defects found by stylelint (Mozlint)
  • 14 defects found by eslint (Mozlint)
IMPORTANT: Found 18 defects (error level) that must be fixed before landing.

You can run this analysis locally with:


If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1302825.

Revision Contents

PathSize
browser/
extensions/
newtab/
common/
6 lines
31 lines
21 lines
content-src/
components/
Base/
4 lines
CustomizeMenu/
ContentSection/
20 lines
3 lines
Nova/
CustomizeMenu/
WidgetsManagementPanel/
22 lines
Widgets/
ResourceMonitor/
341 lines
166 lines
2 lines
styles/
1 line
css/
161 lines
data/
content/
360 lines
lib/
13 lines
29 lines
449 lines
test/
jest/
content-src/
components/
Widgets/
144 lines
locales/
en-US/
browser/
newtab/
2 lines
preferences/
2 lines
1 line
CommitTreeParentsAuthorSummaryDate
9c7df1d0adb49d22768fdf42f757373292c8tyler-thorne
Bug 2048359 - Add Resource Monitor New Tab widget r?maxx (Show More…)
Wed, Jun 17, 7:06 PM

Diff 1302825

browser/extensions/newtab/common/Actions.mjs

Loading...

browser/extensions/newtab/common/Reducers.sys.mjs

Loading...

browser/extensions/newtab/common/WidgetsRegistry.mjs

Loading...

browser/extensions/newtab/content-src/components/Base/Base.jsx

Loading...

browser/extensions/newtab/content-src/components/CustomizeMenu/ContentSection/ContentSection.jsx

Loading...

browser/extensions/newtab/content-src/components/CustomizeMenu/CustomizeMenu.jsx

Loading...

browser/extensions/newtab/content-src/components/Nova/CustomizeMenu/WidgetsManagementPanel/WidgetsManagementPanel.jsx

Loading...

browser/extensions/newtab/content-src/components/Widgets/ResourceMonitor/ResourceMonitor.jsx

Loading...

browser/extensions/newtab/content-src/components/Widgets/ResourceMonitor/_ResourceMonitor.scss

Loading...

browser/extensions/newtab/content-src/components/Widgets/WidgetsComponentRegistry.jsx

Loading...

browser/extensions/newtab/content-src/styles/activity-stream.scss

Loading...

browser/extensions/newtab/css/activity-stream.css

Loading...

browser/extensions/newtab/data/content/activity-stream.bundle.js

Loading...

browser/extensions/newtab/lib/AboutPreferences.sys.mjs

Loading...

browser/extensions/newtab/lib/ActivityStream.sys.mjs

Loading...

browser/extensions/newtab/lib/ResourceMonitorFeed.sys.mjs

Loading...

browser/extensions/newtab/test/jest/content-src/components/Widgets/ResourceMonitor.test.jsx

Loading...

browser/locales/en-US/browser/newtab/newtab.ftl

Loading...

browser/locales/en-US/browser/preferences/preferences.ftl

Loading...

stylelint-rollouts.config.js

Loading...