Code analysis found 1 defect in diff 1260522:

• 1 defect found by eslint (Mozlint)

You can run this analysis locally with:

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1260522.

This is paused for now.

Code analysis found 7 defects in diff 1292511:

• 2 defects found by stylelint (Mozlint)
• 5 defects found by eslint (Mozlint)

You can run this analysis locally with:

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1292511.

A few visual nits:

• I think the dragging shortcut is meant to be 75x75 (hover size)
• Blank placeholder still needs to be implemented (this should be 64x64)

Functionality open questions:

• Are we letting users drag outside of the pinned area to unpin? This is specified in the Figma. I imagine it would do the same thing as unpinning from the context menu (restore the shortcut to frecency position).
• Before we enable this feature, we still need to work out the drag and drop behaviour when no pinned shortcuts exist yet. Otherwise, it's inaccessible to new users unless they pin something first from the context menu.

This revision makes changes to files both inside and in files outside of it. The New Tab page for Firefox Desktop supports train-hopping — a mechanism that allows New Tab code to be deployed to Beta and Release channels independently of the standard release train. Cross-layer changes can break train-hop compatibility, which may block New Tab deployments until fixes reach Release through normal channels.

If your change modifies platform code that browser/extensions/newtab depends on (such as module URIs, DOM APIs, or Nimbus feature definitions), please check whether a compatibility shim is needed. Shims should be marked with a comment indicating the Firefox version that must reach Release before the shim can be removed.

If your change is unrelated to the New Tab page's train-hop compatibility (for example, it only touches tests or documentation), you can possibly disregard this message - but if you are unsure whether your change affects train-hop compatibility, please ensure that someone from the home-newtab-reviewers-rotation review group has a chance to review before landing.