VOOZH about

URL: https://bugzilla.mozilla.org/show_bug.cgi?id=1298157

⇱ 1298157 - Backout the dll shim work around from bug 1294650


Closed Bug 1298157 Opened 9 years ago Closed 9 years ago

Backout the dll shim work around from bug 1294650

Backout the dll shim work around from bug 1294650
External Software Affecting Firefox
Other
unspecified
Unspecified
Unspecified
defect
Not set
normal
RESOLVED FIXED
RESOLVED
FIXED
Accessibility Severity
Webcompat Priority
Webcompat Score
Tracking Status
firefox48 --- wontfix
firefox49 + fixed
firefox50 + fixed
firefox51 + fixed
Tracking Status
firefox48
firefox49
relnote-firefox
firefox50
firefox51
firefox-esr115
firefox-esr140
firefox-esr153
firefox152
firefox153
firefox154
---
QA Whiteboard:
---
Has STR:
---
Change Request:
---
Bug Flags:
Signature:
None
This bug is publicly visible.

 
Track 49+/50+/51+ as the fix doesn't work.
Maybe the fix didn't work for all users but was a workaround for some of them. A few users in bug 1181091 (and an user in bug 1294650) mention that storing a shim QIPCAP.dll file in the Firefox installation directory fixed the issue for them. Should we keep the dll shim as a mitigation, even if it doesn't fix the issue for all users? The last times we had similar issues with WebSense (bug 828184 and bug 1181091) we weren't able to do anything but had to wait for a new WebSense release.
It doesn't make sense to keep the workaround anymore, since WebSense has fixed the issue and we have a hotfix to prevent people using WebSense from updating.
Jimm, Marco just pointed this out to me. Are you doing the backouts? Should someone else do it? Thanks.
Reporter

Comment 5

9 years ago
we don't want to keep this dummy dll in our install. For backouts, tree managers can handle backing out the appropriate cset on each tree itemized in the first comment.
Keywords: checkin-needed

Comment 6

9 years ago
(In reply to Marco Castelluccio [:marco] from comment #3) > It doesn't make sense to keep the workaround anymore, since WebSense has > fixed the issue and we have a hotfix to prevent people using WebSense from > updating. well, I still have the old websense version on my professionnal computer, I've already updated to FF 48.0.2 and the workaround works for me... Without a websense update on my computer and with the workaround backout, FF will crash again on my computer with the next version..
Wes, can you back out the patches in comment 0 so we will have the dummy dll removed for the 49 release candidate build? Thanks.
Flags: needinfo?(wkocher)
(In reply to jcleval from comment #6) > well, I still have the old websense version on my professionnal computer, > I've already updated to FF 48.0.2 and the workaround works for me... Without > a websense update on my computer and with the workaround backout, FF will > crash again on my computer with the next version.. You can update WebSense to avoid the crash (they have found the cause and fixed it). If you aren't able to update before Firefox 49 is released (but you have some time), you can create a dummy DLL yourself (or just copy the current one from the Firefox folder and copy it back after the update).

Comment 10

9 years ago
backout bugherder
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.