Put the dll shim workaround from bug 1294650 back into 49

👁 Image	Liz Henry (:lizzard) Reporter
	Description • 9 years ago

We put the shim into 48 and above, in bug 1294650. Then we backed it out from 49 and up in bug 1298157. We know the shim fixed the crash on at least one older version of Websense for one users and Florin was able to see that result as well. But we don't know that the crashes on 49 for websense users (#2 top crash in the first day's crash-stats results) are the same, different, worse, or what version of websense they're caused by. Without a ton of information to go on, we're going to put the shim back into place for windows users for 49.0.1. We will also keep the 48.0.x users who we *know* have websense, on 48 for now. Sorry about doing the hokey pokey here. We don't have a good solution, but this may mitigate the frequency of the crash for websense users, so we are going to try it (again). +++ This bug was initially created as a clone of Bug #1298157 +++ [Tracking Requested - why for this release]: This fix attempt didn't work, we can back it out. https://hg.mozilla.org/mozilla-central/rev/d332de446548 https://hg.mozilla.org/releases/mozilla-aurora/rev/a72bfbdf5c9b https://hg.mozilla.org/releases/mozilla-beta/rev/29dd7d227b7b

👁 Image	Liz Henry (:lizzard) Reporter
	Comment 1 • 9 years ago

Wes or Ryan, can you land this on m-r please: https://hg.mozilla.org/releases/mozilla-beta/rev/29dd7d227b7b

👁 Image	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 2 • 9 years ago

👁 Image	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Updated • 9 years ago

👁 Image	[SV Manager] Florin Mezei, QA (:FlorinMezei)
	Comment 3 • 9 years ago

I've verified that the shim dll shows up after install and after update from various older versions (46.0.1-de, 47.0-it, 48.0-en-US, 48.0.1-fr, 48.0.2-ro, 49.0-es-ES) on Windows 7 x64 and Windows 8.1 x64.

👁 Image	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 4 • 9 years ago

Hi Wes, we need this change in Fx50 RC2 as well. Could you please land this on m-r?

👁 Image	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 5 • 9 years ago

👁 Image	Chris Peterson [:cpeterson]
	Updated • 9 years ago

👁 Image	Sylvestre Ledru [:Sylvestre]
	Comment 6 • 9 years ago

Because we are still affected by this stuff and we don't have . We should land it on every branch until we know it is fixed for real. FYI, we shipped 50.1.0 with this shimm dll https://hg.mozilla.org/releases/mozilla-release/file/aed42f9ce9f7/browser/installer/package-manifest.in#l144

👁 Image	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 7 • 9 years ago

Hi Wes, Ryan, would you be able to land this on moz-release so we can spin a 51.0.1 build3? Thanks!

👁 Image	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 9 years ago

👁 Image	Sylvestre Ledru [:Sylvestre]
	Comment 9 • 9 years ago

We should take it on all branches too to make sure we don't regress again.

👁 Image	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 10 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/bba5ddb15392baa3c8968179120e50e99b6061fa https://hg.mozilla.org/releases/mozilla-aurora/rev/f3a3afaf7e41b6ea973e97b00528f6d58bdb08cb https://hg.mozilla.org/releases/mozilla-beta/rev/2cfff4488cc160aafb9d8f1b3baa8543d7a170b2