VOOZH about

URL: https://bugzilla.mozilla.org/show_bug.cgi?id=1799563

⇱ 1799563 - UX improvements for swipe-to-navigation


Closed Bug 1799563 Opened 3 years ago Closed 3 years ago

UX improvements for swipe-to-navigation

UX improvements for swipe-to-navigation
Firefox
General
unspecified
Desktop
All
enhancement
Points:
---
RESOLVED FIXED
RESOLVED
FIXED
111 Branch
Iteration:
---
a11y-review
Accessibility Severity
Performance Impact
Webcompat Priority
Webcompat Score
Tracking Status
firefox111 --- fixed
Tracking Status
relnote-firefox
firefox-esr115
firefox-esr140
firefox-esr153
firefox111
firefox152
firefox153
firefox154
---
QA Whiteboard:
---
Has STR:
---
Change Request:
---
Bug Flags:
Signature:
None
This bug is publicly visible.

 

In this bug we are going to just tweaking the icon itself, we are not going to do any fancy page changes (e.g. page is transitioning visually).

There are two things that I have no idea how to do it. So what the Windows version of the new icon looks like are;

  1. the icon consists of two parts, a circle and an arrow inside the circle
  2. the icon moves in response to gestures
  3. the circle gets larger as the gesture moves to right, the arrow size is unchanged, the stroke width of the circle is also unchanged
  4. the circle stroke color is blue and it fills in white, the arrow fills in blue
  5. when the icon reaches to a point where the navigation happen, the blue parts turn into white and the white parts turn into blue gradually (animating)
  6. after the color animations above finished, the icon has an animating blur effect on the edge

So the two things I can't make it happen are the blurry effect (6) and scaling only the circle (parts of 3).

So for 3) I can scale the entire icon, I mean both of the circle and the arrow get scaled altogether. To scale only the circle we need context-value to work for referenced SVG images, :dholbert told me on Matrix that we can probably add the support, but I am unsure how much work would be necessary for the support.

So for 6) if we don't do the color animations (5), we can probably do 6). For the color animations (5) I used both of context-fill and context-stroke for the color changes (blue -> white and white -> blue), there's no more context-blah we can use for the blurry effect.

The icon SVG files were exported from the Figma document

Attached image Size and color spec.svgDetails

This is an SVG exported from the same Figma document in the URL field. It explains icon's colors and sizes. Though in this SVG colors on non-HCM mode are defined as "SelectedItemText" and "SelectedItem", I did confirm with Josh that colors on non-HCM mode should be colors as spec-ed, i.e. #0060DF and #FFFFFF rather than the named colors, colors on HCM mode should be the named ones.

Attachment #9307431 - Attachment description: WIP: Bug 1799563 - Refresh swipe-to-navigation UX. → Bug 1799563 - Refresh swipe-to-navigation UX. r?mconley!
Attachment #9307431 - Attachment description: Bug 1799563 - Refresh swipe-to-navigation UX. r?mconley! → WIP: Bug 1799563 - Refresh swipe-to-navigation UX.
Attachment #9309089 - Attachment is obsolete: true
Attachment #9307431 - Attachment description: WIP: Bug 1799563 - Refresh swipe-to-navigation UX. → Bug 1799563 - Refresh swipe-to-navigation UX. r?mconley!,tnikkel!

The following patch is waiting for review from an inactive reviewer:

ID Title Author Reviewer Status
D164271 Bug 1799563 - Refresh swipe-to-navigation UX. r?mconley!,tnikkel! hiro mconley: Back Jan 4, 2023

:hiro, could you please find another reviewer?

For more information, please visit auto_nag documentation.

Flags: needinfo?(hikezoe.birchill)

Silly bot, people are allowed to go on pto.

Flags: needinfo?(hikezoe.birchill)

Comment 8

3 years ago
Pushed by hikezoe.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/286a4fd230f7 Refresh swipe-to-navigation UX. r=mconley,emilio https://hg.mozilla.org/integration/autoland/rev/7a0ff8d67ea9 Remove browser.swipe.navigation-icon-move-distance pref. r=tnikkel
Pushed by hikezoe.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/36ac39e041af Fix a rebase failure in browser-gestureSupport.js. r=tnikkel

Comment 11

3 years ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Assignee

Updated

3 years ago
No longer regressions: 1811687

Updated

3 years ago
Depends on: 1811877
Regressions: 1811877

Updated

3 years ago
Depends on: 1811873
Regressions: 1811873

Updated

3 years ago
Depends on: 1811871
Regressions: 1811871

Comment 13

3 years ago

I noticed some regressions that I have linked to this bug. Thanks for checking.

Updated

3 years ago
Depends on: 1812100
Regressions: 1812100
Assignee

Updated

3 years ago
No longer regressions: 1811791

Updated

3 years ago
See Also: → 1815138

Updated

3 years ago
Depends on: 1815491
Assignee

Updated

3 years ago
No longer depends on: 1815491
You need to log in before you can comment on or make changes to this bug.