Remove widget.non-native-theme.enabled pref

👁 Image	Gregory Pappas [:gregp] Reporter
	Description • 2 years ago

Non-native theming of widgets in content has been enabled by default for about 2 years now (bug 1697053). Should be safe to remove this pref now

👁 Image	Gregory Pappas [:gregp] Reporter
	Comment 1 • 2 years ago

One benefit of doing this is that it will be harder to accidentally turn off win32k lockdown
https://searchfox.org/mozilla-central/rev/f1f50693655c093d974f026bd37860d939cd5529/toolkit/xre/nsAppRunner.cpp#803-806

👁 Image	Gregory Pappas [:gregp] Reporter
	Comment 2 • 2 years ago

Emilio, do you have any concerns about this?

👁 Image	Thorin [:thorin]
	Comment 3 • 2 years ago

as long as other prefs don't affect it, because it's also a fingerprint protection

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Comment 4 • 2 years ago

Yeah, I guess it might be useful to test the native theme on content, but given we already render most of the stuff using the non-native theme I'm fine just removing it.

👁 Image	Tom S. (please needinfo tschuster)
	Comment 5 • 2 years ago

This came up again in https://phabricator.services.mozilla.com/D207442, probably a good thing to remove it.

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Comment 6 • 2 years ago

👁 Image	Phabricator Automation
	Updated • 2 years ago

👁 Image	Pulsebot
	Comment 7 • 2 years ago

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9500b79c1ab4 Remove widget.non-native-theme.enabled. r=desktop-theme-reviewers,dao,dholbert

👁 Image	Norisz Fay [:noriszfay]
	Comment 8 • 2 years ago

Backed out for causing failures on test_bug869314.html

Backout link

Push with failures

Failure log

👁 Image	Pulsebot
	Comment 9 • 2 years ago

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2c9f9407d659 Remove widget.non-native-theme.enabled. r=desktop-theme-reviewers,dao,dholbert

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Updated • 2 years ago

👁 Image	Cosmin Sabou [:CosminS]
	Comment 10 • 2 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/2c9f9407d659