edgar retitled this revision from Bug 2037356 - [Cocoa] Report buttons correctly while pointer is locked with native API; to Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with native API;.

edgar changed the Bugzilla Bug ID from 2037356 to 2037367.

edgar added reviewers: mstange, spohl.May 6 2026, 12:12 PM

edgar added inline comments.

widget/cocoa/nsCocoaWindow.mm
2902	This is a bug, silly me. Returning early here doesn’t actually stop the event from being dispatched. My intention was to filter out zero movement, but we already report zero movement without using the native API while pointer lock. So it should be fine to report zero movement. We could try to reduce the event later in a followup if we want.

edgar added a child revision: D298759: Bug 2037356 - Enable dom.pointer-lock.native-lock.enabled by default on macOS; r?smaug.May 6 2026, 12:14 PM

edgar mentioned this in D298759: Bug 2037356 - Enable dom.pointer-lock.native-lock.enabled by default on macOS; r?smaug.

Harbormaster completed remote builds in B962966: Diff 1267695.May 6 2026, 12:26 PM

Harbormaster completed remote builds in B962968: Diff 1267697.May 6 2026, 12:39 PM

mstange accepted this revision.May 6 2026, 1:26 PM

This revision is now accepted and ready to land.May 6 2026, 1:26 PM

Herald added a project: needs-testing-tag. · View Herald TranscriptMay 6 2026, 1:26 PM

Comment Actions

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of , , , , . Tip: this Firefox add-on makes it easy!

edgar edited projects, added testing-exception-other (Please leave a comment explaining why) ; removed needs-testing-tag.May 6 2026, 2:21 PM

Comment Actions

testing-exception-other: There is no good way to test platform API.

Closed by commit rFIREFOXAUTOLANDba9517421f8d: Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with… (authored by edgar). · Explain WhyMay 6 2026, 2:24 PM

This revision was automatically updated to reflect the committed changes.

edgar added a commit: rFIREFOXAUTOLANDba9517421f8d: Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with….

edgar added a parent revision: D298772: Bug 2036482 - [Cocoa] Have PointerLock use native APIs;.May 6 2026, 2:46 PM

edgar edited parent revisions, added: D297981: Bug 2036482 - [Cocoa] Have PointerLock use native APIs;; removed: D298772: Bug 2036482 - [Cocoa] Have PointerLock use native APIs;.

edgar added a child revision: D297193: Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS first;.May 6 2026, 2:48 PM

edgar added a child revision: D299006: WIP: Bug 1829401 - Part 1: Implements Element.requestPointerLock() to return Promise<undefined>;.May 6 2026, 11:35 PM

edgar removed a child revision: D297193: Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS first;.May 6 2026, 11:40 PM

edgar removed a child revision: D298759: Bug 2037356 - Enable dom.pointer-lock.native-lock.enabled by default on macOS; r?smaug.May 6 2026, 11:50 PM

edgar added a child revision: D299009: Bug 1829401 - Part 1: Implements Element.requestPointerLock() to return Promise<undefined>; r?smaug.May 7 2026, 12:12 AM

edgar removed a child revision: D299006: WIP: Bug 1829401 - Part 1: Implements Element.requestPointerLock() to return Promise<undefined>;.

edgar mentioned this in D299014: Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with native API;.May 7 2026, 12:21 AM

dmeehan mentioned this in rFIREFOXBETAe7290fa975a3: Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with….May 7 2026, 12:42 PM

dmeehan mentioned this in rFIREFOXRELEASEe7290fa975a3: Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with….May 13 2026, 8:51 PM

edgar mentioned this in rFIREFOXBETAba9517421f8d: Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with….May 18 2026, 2:50 PM

edgar mentioned this in rFIREFOXRELEASEba9517421f8d: Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with….Wed, Jun 10, 5:49 PM

Revision Contents
Changeset List

Path

Size

widget/

cocoa/

nsCocoaWindow.mm

13 lines

Commit	Tree	Parents	Author	Summary	Date
ba9517421f8d	259ba51a6606	Edgar Chen	Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with… (Show More…)

	Status	Author
Closed	edgar	D298444 Bug 2036904 - [Windows] Support locking pointer with unadjustedMovement;
Closed	edgar	D297193 Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS first;
Closed	edgar	D299009 Bug 1829401 - Part 1: Implements Element.requestPointerLock() to return Promise<undefined>; r?smaug
Closed	edgar	D298803 Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with native API;
Closed	edgar	D297981 Bug 2036482 - [Cocoa] Have PointerLock use native APIs;

D299239 Bug 2038040 - Improve/simplify indexing and visibility tracking in macOS menu code. r=mac-reviewers,bradwerth
·Reviewers: mac-reviewers, bradwerth
Mon, Jun 15, 11:22 AM
Author: jaas
D297491 Bug 2037914: Embed the macOS native traffic-light buttons in the toolbox during fullscreen. r=emilio!,mstange!,#desktop-theme-reviewers
·Reviewers: desktop-theme-reviewers
Wed, Jun 3, 7:54 AM
Author: spohl
D299341 WIP: Bug 1912002 - Auto-pip on app switch on macOS. WIP
·No Reviewers
Wed, May 27, 6:15 AM
Author: hsohaney
D299584 Bug 1991893 - Part 2 - Fix popovers not opening if the given rect is not valid
·Reviewers: emilio
Thu, May 21, 1:34 PM
Author: cheff

Diff 1267822

View Options

widget/cocoa/nsCocoaWindow.mm

Privacy · Cookies · Legal

URL: https://phabricator.services.mozilla.com/D298803

⇱ ⚙ D298803 Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with native API;

Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with native API;
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1267822

widget/cocoa/nsCocoaWindow.mm

URL: https://phabricator.services.mozilla.com/D298803

⇱ ⚙ D298803 Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with native API;

Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with native API;ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1267822

widget/cocoa/nsCocoaWindow.mm

Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with native API;
ClosedPublic
Actions

Revision Contents
Changeset List