dom/webidl/PointerLockOptions.webidl
10 ↗	(On Diff #1261147)	We need a pref for this, I think. Something which is enabled only once most platforms (desktop at least, probably) support the feature. So, add dom.pointer-lock.unadjusted-movement.enabled pref check here?

noahbpeterson1997 updated this revision to Diff 1262166.Apr 29 2026, 8:06 PM

Harbormaster completed remote builds in B958575: Diff 1262166.Apr 29 2026, 8:28 PM

edgar requested changes to this revision.Apr 30 2026, 11:11 AM

edgar added a subscriber: edgar.

Comment Actions

Thanks for the patch. I have some suggestion.

dom/base/PointerLockManager.cpp
107	Mapping twice seems unnecessary, could we map the to Promise reject method directly?
widget/nsIWidget.h
1936	Can we reuse by making it taking the argument instead? And make reseting the in Cocoa implmentation.

This revision now requires changes to proceed.Apr 30 2026, 11:11 AM

mstange mentioned this in D297195: Bug 1829401 - Deliver raw, smooth pointer-lock unadjustedMovement motion on macOS r?#dom-core,#mac-reviewers.Apr 30 2026, 7:04 PM

edgar added a parent revision: D297981: Bug 2036482 - [Cocoa] Have PointerLock use native APIs;.May 4 2026, 6:39 PM

edgar edited parent revisions, added: D298803: Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with native API;; removed: D297981: Bug 2036482 - [Cocoa] Have PointerLock use native APIs;.May 6 2026, 2:48 PM

edgar mentioned this in D297196: Bug 1829401 - Reject unadjustedMovement on platforms that can't honor it r?#dom-core,#mac-reviewers.May 6 2026, 11:37 PM

edgar mentioned this in D297194: Bug 1829401 - Source unaccelerated mouse delta from CGEvent on macOS for pointer lock unadjustedMovement r?#dom-core,#mac-reviewers.

edgar removed a child revision: D297194: Bug 1829401 - Source unaccelerated mouse delta from CGEvent on macOS for pointer lock unadjustedMovement r?#dom-core,#mac-reviewers.

edgar commandeered this revision.May 6 2026, 11:40 PM

edgar edited parent revisions, added: D299006: WIP: Bug 1829401 - Part 1: Implements Element.requestPointerLock() to return Promise<undefined>;; removed: D298803: Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with native API;.

edgar edited reviewers, added: noahbpeterson1997; removed: edgar.

edgar planned changes to this revision.May 6 2026, 11:41 PM

edgar updated this revision to Diff 1268526.

edgar retitled this revision from Bug 1829401 - Add unadjustedMovement option and Promise return to Element.requestPointerLock r?#dom-core to WIP: Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS first;.

edgar edited the summary of this revision. (Show Details)

edgar added a child revision: D298444: Bug 2036904 - [Windows] Support locking pointer with unadjustedMovement;.May 6 2026, 11:48 PM

Harbormaster completed remote builds in B963612: Diff 1268526.May 7 2026, 12:03 AM

edgar edited parent revisions, added: D299009: Bug 1829401 - Part 1: Implements Element.requestPointerLock() to return Promise<undefined>; r?smaug; removed: D299006: WIP: Bug 1829401 - Part 1: Implements Element.requestPointerLock() to return Promise<undefined>;.May 7 2026, 12:09 AM

edgar planned changes to this revision.May 7 2026, 10:40 AM

edgar updated this revision to Diff 1268828.

Harbormaster completed remote builds in B963869: Diff 1268828.May 7 2026, 11:10 AM

edgar requested review of this revision.May 7 2026, 12:04 PM

edgar updated this revision to Diff 1268870.

edgar retitled this revision from WIP: Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS first; to Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS first;.

edgar edited reviewers, added: smaug, mstange; removed: dom-core-reviewers, noahbpeterson1997.May 7 2026, 12:05 PM

smaug accepted this revision.May 7 2026, 12:38 PM

Comment Actions

Can't say about nsCocoaWindow.mm

dom/base/PointerLockManager.cpp
267	Nit, s/do/does/
267	File perhaps a followup to match the spec also in this case?
512	presshell->GetRootWidget() doesn't work here?
562	Curious, have we tested that doing non-unadjustedmovement lock after doing unadjusted movement lock works? Even just locally.
widget/nsIWidget.h
1939	SupportsUnadjustedMovement() might read a bit better, no?

Harbormaster completed remote builds in B963940: Diff 1268870.May 7 2026, 12:38 PM

edgar added a comment.May 7 2026, 1:09 PM

Comment Actions

In D297193#10372899, @smaug wrote:

Can't say about nsCocoaWindow.mm

@mstange, can you help to review the changes in , thanks!

edgar added inline comments.May 7 2026, 1:13 PM

dom/base/PointerLockManager.cpp
562	Yes, I tested it locally with https://codepen.io/editor/edgarchen-the-decoder/pen/019dfd60-01d7-75c2-a54b-959456fce306.

edgar marked 2 inline comments as done.May 7 2026, 1:39 PM

edgar added inline comments.

dom/base/PointerLockManager.cpp
267	Filed https://bugzilla.mozilla.org/show_bug.cgi?id=2037874.

edgar marked 2 inline comments as done.May 7 2026, 2:10 PM

edgar added inline comments.

dom/base/PointerLockManager.cpp
512	It works. Fixed.

edgar marked an inline comment as done.May 7 2026, 2:15 PM

edgar marked an inline comment as done.

edgar added inline comments.

widget/nsIWidget.h
1939	I was considering that, but ended up using , switched back. :)

edgar marked an inline comment as done.May 7 2026, 2:17 PM

edgar updated this revision to Diff 1269032.May 7 2026, 2:46 PM

mstange accepted this revision.May 7 2026, 2:49 PM

mstange added a project: testing-approved.

Comment Actions

The code changes are fine but the API is really strange. "Is supporting" sounds like something that depends on the moment and can change over time, but nsCocoaWindow just checks a pref. Could this be a NativePointerLockMode enum instead? Maybe with Unlocked, LockedRegular, LockedUnadjusted variants - or maybe Locked/Unlocked should be kept in a separate state.
"UpdateNativePointerLockUnadjustedMovement" sounds like something that takes a movement delta, not a bool. If this could be SetNativePointerLockMode it would read more clearly.
Why is InitIsSupportingUnadjustedMovement a separate message? Could the mode be passed when the actual pointer lock begins?

This revision is now accepted and ready to land.May 7 2026, 2:49 PM

mstange added a comment.May 7 2026, 2:53 PM

Comment Actions

Oh, InitIsSupportingUnadjustedMovement goes from parent to content, I see.

Harbormaster completed remote builds in B964065: Diff 1269032.May 7 2026, 3:10 PM

edgar added a comment.May 7 2026, 3:11 PM

Comment Actions

In D297193#10374464, @mstange wrote:

Oh, InitIsSupportingUnadjustedMovement goes from parent to content, I see.

Right, (It was ) is an API for querying whether the platform supports reporting unadjusted movement. Not all platforms support this capability, such as Linux X11. (Naming suggestions are welcome!)
The intention to check the pref is because I don't want and goes too different logic.

Could this be a NativePointerLockMode enum instead? Maybe with Unlocked, LockedRegular, LockedUnadjusted variants - or maybe Locked/Unlocked should be kept in a separate state.

Right, NativePointerLockMode maybe can be a , I will try this.

"UpdateNativePointerLockUnadjustedMovement" sounds like something that takes a movement delta, not a bool. If this could be SetNativePointerLockMode it would read more clearly.

Will rename to .

edgar updated this revision to Diff 1269183.May 7 2026, 4:31 PM

edgar added a comment.May 7 2026, 4:32 PM

Comment Actions

@mstange, mind taking another look? Thanks!

edgar updated this revision to Diff 1269188.May 7 2026, 4:34 PM

Harbormaster completed remote builds in B964176: Diff 1269188.May 7 2026, 4:52 PM

Harbormaster failed remote builds in B964171: Diff 1269183!May 7 2026, 4:58 PM

edgar added a comment.May 7 2026, 5:36 PM

Comment Actions

In D297193#10375555, @edgar wrote:

@mstange, mind taking another look? Thanks!

I am going to land the patch as is for now, feel free to let me know if there is anything I should address, I will do that in a follow-up, thanks!

edgar mentioned this in D298444: Bug 2036904 - [Windows] Support locking pointer with unadjustedMovement;.May 7 2026, 5:59 PM

mstange accepted this revision.May 7 2026, 6:12 PM

Comment Actions

Looks good to me, thanks!

As a follow-up you could make more use of PointerLockMode in places where you currently have bools, e.g. in .

edgar added a comment.May 7 2026, 6:27 PM

Comment Actions

In D297193#10376393, @mstange wrote:

Looks good to me, thanks!

As a follow-up you could make more use of PointerLockMode in places where you currently have bools, e.g. in .

I filed bug 2037988 as follow-up, thank you!

edgar updated this revision to Diff 1269417.May 7 2026, 8:29 PM

Harbormaster completed remote builds in B964372: Diff 1269417.May 7 2026, 8:47 PM

edgar updated this revision to Diff 1269455.May 7 2026, 8:48 PM

Comment Actions

rebase

Harbormaster completed remote builds in B964408: Diff 1269455.May 7 2026, 9:16 PM

Closed by commit rFIREFOXAUTOLAND782dcf9aee2e: Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS… (authored by edgar). · Explain WhyMay 7 2026, 11:40 PM

This revision was automatically updated to reflect the committed changes.

edgar added a commit: rFIREFOXAUTOLAND782dcf9aee2e: Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS….

CosminS reopened this revision.May 8 2026, 9:18 PM

This revision is now accepted and ready to land.May 8 2026, 9:18 PM

CosminS added a reverting change: rFIREFOXAUTOLAND53bb72f2746d: Revert "Bug 1829401 - Part 2: Support unadjustedMovement option and implement….May 8 2026, 9:18 PM

Harbormaster completed remote builds in B964854: Diff 1269583.May 8 2026, 9:18 PM

CosminS added a reverting change: rFIREFOXAUTOLAND7fa25c8ffbac: Revert "Bug 1829401 - Part 2: Support unadjustedMovement option and implement….May 8 2026, 9:52 PM

edgar updated this revision to Diff 1270839.May 9 2026, 10:14 PM

edgar edited the summary of this revision. (Show Details)

Harbormaster failed remote builds in B965563: Diff 1270839!May 9 2026, 10:24 PM

This revision was landed with ongoing or failed builds.May 10 2026, 7:06 AM

Closed by commit rFIREFOXAUTOLAND90143df1b5db: Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS… (authored by edgar). · Explain Why

This revision was automatically updated to reflect the committed changes.

edgar added a commit: rFIREFOXAUTOLAND90143df1b5db: Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS….

Harbormaster completed remote builds in B965626: Diff 1270892.May 11 2026, 8:13 AM

edgar mentioned this in rFIREFOXBETA782dcf9aee2e: Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS….May 18 2026, 2:54 PM

edgar mentioned this in rFIREFOXBETA90143df1b5db: Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS….May 18 2026, 3:00 PM

edgar mentioned this in rFIREFOXRELEASE782dcf9aee2e: Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS….Wed, Jun 10, 5:56 PM

edgar mentioned this in rFIREFOXRELEASE90143df1b5db: Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS….Wed, Jun 10, 6:05 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

dom/

base/

Element.h

6 lines

96%

Element.cpp

7 lines

PointerLockManager.h

15 lines

100%

PointerLockManager.cpp

100 lines

events/

EventStateManager.h

3 lines

85%

EventStateManager.cpp

7 lines

89%

ipc/

BrowserChild.h

3 lines

91%

BrowserChild.cpp

6 lines

BrowserParent.h

6 lines

96%

BrowserParent.cpp

15 lines

PBrowser.ipdl

10 lines

webidl/

Element.webidl

8 lines

modules/

libpref/

init/

StaticPrefList.yaml

9 lines

testing/

web-platform/

meta/

pointerlock/

__dir__.ini

1 line

pointerlock-maintains-mousedown.html.ini

12 lines

pointerlock_unadjustedMovement.html.ini

6 lines

pointerlock_unadjustedMovement_update.html.ini

17 lines

tests/

pointerlock/

pointerlock_unadjustedMovement_update.html

58 lines

widget/

PuppetWidget.h

12 lines

86%

PuppetWidget.cpp

13 lines

WidgetMessageUtils.h

7 lines

100%

cocoa/

nsCocoaWindow.h

10 lines

nsCocoaWindow.mm

75 lines

gtk/

nsWindowWayland.h

2 lines

nsWindowWayland.cpp

3 lines

nsIWidget.h

21 lines

67%

Commit	Tree	Parents	Author	Summary	Date
90143df1b5db	7a455d0ed929	Edgar Chen	Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS… (Show More…)

	Status	Author
Closed	edgar	D298444 Bug 2036904 - [Windows] Support locking pointer with unadjustedMovement;
Closed	edgar	D297193 Bug 1829401 - Part 2: Support unadjustedMovement option and implement on macOS first;
Closed	edgar	D299009 Bug 1829401 - Part 1: Implements Element.requestPointerLock() to return Promise<undefined>; r?smaug
Closed	edgar	D298803 Bug 2037367 - [Cocoa] Report buttons correctly while pointer is locked with native API;
Closed	edgar	D297981 Bug 2036482 - [Cocoa] Have PointerLock use native APIs;