A number of updates here:

1. The Acorn team updated their icon exporter to trim clip paths and references to them. I confirmed that there are no longer any in the Nova icons. There are some in the existing Proton icons, but I don't think I need to clean those up in this patch. They should be cleaned up when Nova icons are promoted and the Proton paths are deleted.
2. the Acorn team uploaded closed-tabs-16 to the acorn-icons repo, so I was able to add it here
3. I went through all of the icons that set fill/stroke/etc. on specific paths. In most cases, I was able to promote those attributes to the <svg> element, but there are some icons that need path-specific colors.

Through this process of going through all of the icons, I did encounter a few novel issues that hadn't been flagged by anyone yet. Mostly, these were issues where I mapped an inappropriate Acorn icon to the codebase. I think it's likely that there are still some errata in this patch stack, but I think they should be isolated issues rather than systematic ones.

However, there are some specific icons where I know there are issues:

add-circle-fill and subtract-circle-fill

The Proton versions of these icons draw a and then a on top. The Nova versions in acorn-icons draw a single describing the filled area around the + or -. That would mean the Nova version could only be used when the icon is supposed to have a transparent + or -.

Since there are existing uses for explicitly coloring the + or - (e.g. the application menu zoom controls), I manually updated the Nova version of this icons to draw a and then remove the circle drawing parts of the . This means the Nova versions in this patch diverge from the acorn-icons repo at this time. I'm talking with the icon designers about how they want to proceed, but I think in practical terms, we need these icons to work the same way as Proton.

bookmark-12 and pin-12

The Proton versions of these icons draw a and a . The practical purpose of this is to draw these icons as "badges" on top of favicons (Firefox View, URL bar, New Tab). When the stroke color is set to the background color of the UI surface, the badge gets a stroke that prevents the favicon colors from bleeding into the badge color.

This would not be easy for me to deal with manually, so this patch contains the current Nova version from acorn-icons. I believe these will need to be updated by the icon designers and then updated in the codebase in an upcoming patch.

In D301961#10511905, @sthompson wrote:

add-circle-fill and subtract-circle-fill

The Proton versions of these icons draw a and then a on top. The Nova versions in acorn-icons draw a single describing the filled area around the + or -. That would mean the Nova version could only be used when the icon is supposed to have a transparent + or -.

Since there are existing uses for explicitly coloring the + or - (e.g. the application menu zoom controls), I manually updated the Nova version of this icons to draw a and then remove the circle drawing parts of the . This means the Nova versions in this patch diverge from the acorn-icons repo at this time. I'm talking with the icon designers about how they want to proceed, but I think in practical terms, we need these icons to work the same way as Proton.

Agreed. Please file a follow-up to keep track of this, if it doesn't get fully resolved here.

bookmark-12 and pin-12

The Proton versions of these icons draw a and a . The practical purpose of this is to draw these icons as "badges" on top of favicons (Firefox View, URL bar, New Tab). When the stroke color is set to the background color of the UI surface, the badge gets a stroke that prevents the favicon colors from bleeding into the badge color.

This would not be easy for me to deal with manually, so this patch contains the current Nova version from acorn-icons. I believe these will need to be updated by the icon designers and then updated in the codebase in an upcoming patch.

Are you going to file a follow-up bug on this?

Thanks!

In D301961#10514367, @dao wrote:

Agreed. Please file a follow-up to keep track of this, if it doesn't get fully resolved here.

Are you going to file a follow-up bug on this?

I passed this information to Juliana and she will look at updating the acorn-icons desktop-transform pipeline to try to support this class of icons systematically. I filed bug 2043461 specifically for updating bookmark-12 and pin-12 since the Nova versions of those will be insufficient until those are reprocessed.