VOOZH about

URL: https://phabricator.services.mozilla.com/D301963

⇱ ⚙ D301963 Bug 2041515 - urlbar Nova icons r=#urlbar-reviewers!

Paths

Bug 2041515 - urlbar Nova icons r=#urlbar-reviewers!
ClosedPublic

Authored by sthompson on Fri, May 22, 2:11 AM.
Referenced Files
F72885352: D301963/new/.1781747914.diff
Wed, Jun 17, 1:58 AM
Unknown Object (File)
Tue, Jun 16, 9:54 PM
Unknown Object (File)
Mon, Jun 15, 4:57 PM
Unknown Object (File)
Mon, Jun 15, 12:13 PM
Unknown Object (File)
Thu, Jun 4, 12:16 PM
Unknown Object (File)
Wed, Jun 3, 9:14 PM
Unknown Object (File)
Wed, Jun 3, 6:11 PM
Unknown Object (File)
Wed, Jun 3, 5:09 PM
Subscribers

Details

Summary

Displays the Nova iconography when is true.

Updates 8 existing urlbar icons with the following approach:

  1. wraps the existing <path>(s) in a
  2. appends the Nova redrawn icon's <path>(s) in a
  3. adds a <style> block with rules to show only one group at a time

This is an unorthodox approach. It has several drawbacks:

  1. increases individual SVG size
  2. increases the time required to render each SVG
  3. viewing the SVGs in normal image tools will only show the Proton variant, which is confusing

However, I think this approach is better than alternatives.

  1. do not need to add new Nova icon files and CSS rules to use them conditionally
  2. SVG uses in XHTML and similar contexts doesn't require special handling
  3. this can be undone very easily after Nova is released, leaving only the Nova paths
  4. the SVG rendering performance impact is not large, and alternatives would still have non-zero performance impact
  5. total size of SVGs is not that much larger than if we added separate Nova icons

Diff Detail

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
dao added a subscriber: dao.
dao added inline comments.
browser/themes/shared/urlbar/icons/flight-airline.svg
17 ↗(On Diff #1280699)

bogus clip-path

This revision is now accepted and ready to land.Tue, May 26, 1:19 PM
sthompson edited the summary of this revision. (Show Details)
Comment Actions

flight-airline.svg is a 26px icon that I erroneously mapped to plane-16. I reverted that icon change because there isn't an appropriately sized redrawn icon.

Other icons are unchanged.

Revision Contents

PathSize
browser/
themes/
shared/
urlbar/
icons/
14 lines
13 lines
13 lines
13 lines
14 lines
14 lines
14 lines
14 lines
CommitTreeParentsAuthorSummaryDate
e07fecf25a5cbf8766e4be06Stephen Thompson
Bug 2041515 - urlbar Nova icons r=urlbar-reviewers,desktop-theme-reviewers,dao (Show More…)

Diff 1286247

browser/themes/shared/urlbar/icons/sports-american-football.svg

Loading...

browser/themes/shared/urlbar/icons/sports-baseball.svg

Loading...

browser/themes/shared/urlbar/icons/sports-basketball.svg

Loading...

browser/themes/shared/urlbar/icons/sports-cricket.svg

Loading...

browser/themes/shared/urlbar/icons/sports-golf.svg

Loading...

browser/themes/shared/urlbar/icons/sports-hockey.svg

Loading...

browser/themes/shared/urlbar/icons/sports-racing.svg

Loading...

browser/themes/shared/urlbar/icons/sports-soccer.svg

Loading...