VOOZH about

URL: https://phabricator.services.mozilla.com/D302544

⇱ ⚙ D302544 Bug 1803575 - Implement color picker / eyedropper quick action. r?daleharvey


Bug 1803575 - Implement color picker / eyedropper quick action. r?daleharvey
ClosedPublic

Authored by dao on Tue, May 26, 3:31 PM.
Referenced Files
Unknown Object (File)
Sat, Jun 6, 4:19 AM
Unknown Object (File)
Fri, Jun 5, 9:51 PM
Unknown Object (File)
Fri, Jun 5, 7:59 PM
Unknown Object (File)
Fri, Jun 5, 7:29 AM
Unknown Object (File)
Wed, Jun 3, 10:34 PM
Unknown Object (File)
Tue, Jun 2, 1:20 AM
Unknown Object (File)
Mon, Jun 1, 1:54 AM
Subscribers

Diff Detail

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
nchevobbe added a subscriber: nchevobbe.
Comment Actions

Looks good to me, thanks Dao

browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs
173

question: Why are we only excluding those pages (and not all about: page for examples) ?

This revision is now accepted and ready to land.Wed, May 27, 3:28 PM
dao marked an inline comment as done.Thu, May 28, 10:14 AM
dao added inline comments.
browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs
173

Not sure; this is copied from the action above. I don't see a good reason to exclude all pages here, but I don't really know what's special about . I am noticing that the eyedropper menu item also doesn't seem to work when I load , so I'll keep this check for the time being.

dao marked an inline comment as done.Thu, May 28, 10:15 AM

Revision Contents

PathSize
browser/
components/
urlbar/
25 lines
tests/
browser-quickactions/
48 lines
locales/
en-US/
browser/
4 lines
CommitTreeParentsAuthorSummaryDate
7063ba8e20f9116086e20c64Dão Gottwald
Bug 1803575 - Implement color picker / eyedropper quick action. r=daleharvey… (Show More…)

Diff 1285244

browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs

Loading...

browser/components/urlbar/tests/browser-quickactions/browser_devtools.js

Loading...

browser/locales/en-US/browser/browser.ftl

Loading...