VOOZH about

URL: https://phabricator.services.mozilla.com/D302719

⇱ ⚙ D302719 Bug 1983835 - Drop allowFromInactiveWorkspace flag from urlbar quick actions and interventions provider. r?daleharvey


Bug 1983835 - Drop allowFromInactiveWorkspace flag from urlbar quick actions and interventions provider. r?daleharvey
ClosedPublic

Authored by dao on Wed, May 27, 8:23 AM.
Referenced Files
Unknown Object (File)
Fri, Jun 5, 11:17 AM
Unknown Object (File)
Fri, Jun 5, 7:28 AM
Unknown Object (File)
Fri, Jun 5, 7:14 AM
Unknown Object (File)
Thu, Jun 4, 9:14 PM
Unknown Object (File)
Thu, Jun 4, 9:13 PM
Unknown Object (File)
Tue, Jun 2, 2:17 AM
Unknown Object (File)
Mon, Jun 1, 10:38 PM
Unknown Object (File)
Mon, Jun 1, 10:27 PM
Subscribers
None

Details

Summary

The urlbar is always in the user's focused window, so the visibility
checks should reflect that window — not an arbitrary window on another
workspace. ActionsProviderTabGroups still uses the flag intentionally
(its comment documents that suggesting tab groups across workspaces is
desired).

Diff Detail

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Comment Actions

Yeh I believe we want to be passing the current window to isVisible and avoid these window lookups, but this makes sense as well.

This revision is now accepted and ready to land.Wed, May 27, 3:07 PM

Revision Contents

PathSize
browser/
components/
urlbar/
18 lines
6 lines
CommitTreeParentsAuthorSummaryDate
4f42a2af477d6f62cca90af8Dão Gottwald
Bug 1983835 - Drop allowFromInactiveWorkspace flag from urlbar quick actions… (Show More…)

Diff 1285245

browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs

Loading...

browser/components/urlbar/UrlbarProviderInterventions.sys.mjs

Loading...