Details

Reviewers

daisuke

dao

Group Reviewers

desktop-theme-reviewers

urlbar-reviewers

Commits

rFIREFOXAUTOLAND0b7a725bc8fb: Bug 2033583 - [Nova] Update the urlbar for compact mode. r=daisuke,dao,desktop…

Bugzilla Bug ID

2033583

Summary

Please see the bug for notes on the intended design. Summary:

Add more variables to to accommodate Nova compact mode.

I kept the bottom border radius of the background the same as it is in
non-compact mode since I don't think that's intended to change. When the view is
open, the top radius needs to be smaller so it matches the top radius of the
input.

Move the existing definition up to where all the
other variables are defined and rename it
so it's clearer it's only used when the breakout is active.

In , in order to compensate for the row gutter, set all the
margins of rather than only the inline margins. The gutter goes
all the way around each row, not only the sides. That lets us remove the rule in
with the "Rely on the height of urlbar" comment.

One-offs tweaks: We should probably remove the one-offs from Nova but for now
make sure they look OK in both compact and non-compact mode. (a) Give them
enough inline margin to account for the larger border radius of the
view/background in Nova. (b) The is needed to unset
set elsewhere, which makes the one-offs overflow the view width with the margin
applied.

Depends on D301257, D302682

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland

Event Timeline

adw created this revision.Fri, May 29, 12:39 AM

Herald added a project: secure-revision. · View Herald TranscriptFri, May 29, 12:39 AM

phab-bot published this revision for review.Fri, May 29, 12:40 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: desktop-theme-reviewers. · View Herald TranscriptFri, May 29, 12:40 AM

Herald added a reviewer: desktop-theme-reviewers. · View Herald Transcript

Herald added a reviewer: urlbar-reviewers. · View Herald Transcript

Herald added a subscriber: Itiel. · View Herald Transcript

adw added a comment.Fri, May 29, 12:43 AM

Comment Actions

View open:

👁 Screenshot 2026-05-28 at 5.25.43 PM.png (914×1 px, 133 KB)

Closed but focused:

👁 Screenshot 2026-05-28 at 5.42.10 PM.png (102×1 px, 18 KB)

adw attached a referenced file: F71524572: Screenshot 2026-05-28 at 5.42.10 PM.png. (Show Details)Fri, May 29, 12:43 AM

adw attached a referenced file: F71524573: Screenshot 2026-05-28 at 5.25.43 PM.png. (Show Details)

Harbormaster completed remote builds in B977238: Diff 1286192.Fri, May 29, 1:10 AM

adw updated this revision to Diff 1286400.Fri, May 29, 6:06 AM

Comment Actions

Don't add to when there are no results

Harbormaster completed remote builds in B977352: Diff 1286400.Fri, May 29, 6:33 AM

adw updated this revision to Diff 1286408.Fri, May 29, 6:34 AM

Comment Actions

More fixes for .

Compact mode:

👁 Screenshot 2026-05-28 at 11.17.41 PM.png (94×1 px, 26 KB)

Non-compact mode:

👁 Screenshot 2026-05-28 at 11.17.21 PM.png (130×1 px, 35 KB)

adw attached a referenced file: F71538911: Screenshot 2026-05-28 at 11.17.21 PM.png. (Show Details)Fri, May 29, 6:34 AM

adw attached a referenced file: F71538912: Screenshot 2026-05-28 at 11.17.41 PM.png. (Show Details)

adw planned changes to this revision.Fri, May 29, 6:59 AM

Comment Actions

Needs more work

Harbormaster completed remote builds in B977357: Diff 1286408.Fri, May 29, 7:07 AM

adw mentioned this in D302682: Bug 2042570: Add enough margin to the bottom even if no results.Fri, May 29, 9:31 PM

adw updated this revision to Diff 1287229.Fri, May 29, 10:00 PM

adw edited the summary of this revision. (Show Details)

adw added a parent revision: D302682: Bug 2042570: Add enough margin to the bottom even if no results.

Comment Actions

Rebase on D302682, which lets me set a proper border radius on the urlbar-background in compact mode when is active

Harbormaster failed remote builds in B977999: Diff 1287229!Fri, May 29, 10:10 PM

daisuke added a comment.Mon, Jun 1, 3:45 AM

Comment Actions

Thank you very much!

question:

👁 2026-06-01 12.25.10.png (70×554 px, 11 KB)

Please see the screenshot. When the one-off buttons are shown, there doesn't seem to be any margin around them. Should we add some?

browser/themes/shared/urlbar-searchbar.css
80	question: Should we use since we decided to use it for ?

daisuke attached a referenced file: F71700659: 2026-06-01 12.25.10.png. (Show Details)Mon, Jun 1, 3:45 AM

adw updated this revision to Diff 1290045.Wed, Jun 3, 12:00 AM

adw marked an inline comment as done.

adw edited the summary of this revision. (Show Details)

adw added a parent revision: D301257: Bug 2039721: Add proper padding between urlbr-input-container and inside components.

Comment Actions

Address comments:
- Use rather than
- We should probably remove the one-offs from Nova but for now make sure they look OK in both compact and non-compact mode: (a) Give them enough inline margin to account for the larger border radius of the view/background in Nova, (b) the is needed to unset set elsewhere, which makes the one-offs overflow the view width with the margin applied
Rename some of the new variables, rework some of the new rules
Rebase on D301257 (in addition to D302682 as before)