Differential D306308

Bug 2046522 - "Account and sync" pane can appear empty when its sections are disabled r=mstriemer
ClosedPublic
Actions

Authored by akulyk on Thu, Jun 11, 9:50 PM.

Details

Reviewers

mstriemer

bolsson

Group Reviewers

Restricted Project

desktop-theme-reviewers

Commits

rFIREFOXAUTOLANDc3098e063b03: Bug 2046522 - "Account and sync" pane can appear empty when its sections are…
rFIREFOXAUTOLAND211f54d74e35: Bug 2046522 - "Account and sync" pane can appear empty when its sections are…
rFIREFOXAUTOLANDbbf736719f5b: Bug 2046522 - "Account and sync" pane can appear empty when its sections are…
rFIREFOXAUTOLANDcfd0670364c5: Bug 2046522 - "Account and sync" pane can appear empty when its sections are…

Bugzilla Bug ID

2046522

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland

Event Timeline

akulyk created this revision.Thu, Jun 11, 9:50 PM

Herald added a project: secure-revision. · View Herald TranscriptThu, Jun 11, 9:50 PM

Herald added a reviewer: Restricted Project. · View Herald Transcript

phab-bot published this revision for review.Thu, Jun 11, 9:51 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jun 11, 9:51 PM

Herald added a reviewer: desktop-theme-reviewers. · View Herald Transcript

Herald added a subscriber: flod. · View Herald Transcript

phab-bot removed a reviewer: Restricted Project.Thu, Jun 11, 9:51 PM

phab-bot added a subscriber: Restricted Project.

akulyk added a comment.Thu, Jun 11, 9:57 PM

Comment Actions

👁 Screenshot 2026-06-11 165808.png (447×797 px, 29 KB)

browser/components/preferences/tests/sync/browser_account_sync_visibility.js
341–342	fix for preexisting test failure with flag
browser/themes/shared/preferences/preferences.css
779–781	Fixes empty space from empty container

akulyk updated this revision to Diff 1298088.Thu, Jun 11, 9:58 PM

akulyk attached a referenced file: F72490068: Screenshot 2026-06-11 165808.png. (Show Details)Thu, Jun 11, 10:31 PM

mstriemer accepted this revision.Thu, Jun 11, 10:47 PM

mstriemer added a project: testing-approved.

Comment Actions

Thank you!

browser/components/preferences/tests/sync/browser_account_sync_visibility.js
73	Currently the test would pass without setting . It would be good to verify that the group is hidden when we're showing other sections here

bolsson accepted this revision.Thu, Jun 11, 10:51 PM

This revision is now accepted and ready to land.Thu, Jun 11, 10:51 PM

akulyk updated this revision to Diff 1298157.Thu, Jun 11, 10:58 PM

akulyk updated this revision to Diff 1298161.

akulyk marked an inline comment as done.Thu, Jun 11, 11:00 PM

Comment Actions

test update

This revision was landed with ongoing or failed builds.Fri, Jun 12, 2:16 AM

Closed by commit rFIREFOXAUTOLANDcfd0670364c5: Bug 2046522 - "Account and sync" pane can appear empty when its sections are… (authored by akulyk). · Explain Why

This revision was automatically updated to reflect the committed changes.

akulyk added a commit: rFIREFOXAUTOLANDcfd0670364c5: Bug 2046522 - "Account and sync" pane can appear empty when its sections are….

ctuns reopened this revision.Fri, Jun 12, 3:45 AM

This revision is now accepted and ready to land.Fri, Jun 12, 3:45 AM

ctuns added a reverting change: rFIREFOXAUTOLAND05c188ccdf43: Revert "Bug 2046522 - "Account and sync" pane can appear empty when its….Fri, Jun 12, 3:45 AM

akulyk updated this revision to Diff 1298344.Fri, Jun 12, 5:03 AM

akulyk added a comment.Fri, Jun 12, 5:07 AM

Comment Actions

Fix for the failing test

browser/components/preferences/tests/searchResults/browser_search_category_filter.js
86	Aligning the selector with findInPage.js

This revision was landed with ongoing or failed builds.Fri, Jun 12, 5:10 AM

Closed by commit rFIREFOXAUTOLANDbbf736719f5b: Bug 2046522 - "Account and sync" pane can appear empty when its sections are… (authored by akulyk). · Explain Why

This revision was automatically updated to reflect the committed changes.

akulyk added a commit: rFIREFOXAUTOLANDbbf736719f5b: Bug 2046522 - "Account and sync" pane can appear empty when its sections are….

agoloman reopened this revision.Fri, Jun 12, 9:29 AM

agoloman added a commit: rFIREFOXAUTOLAND211f54d74e35: Bug 2046522 - "Account and sync" pane can appear empty when its sections are….

This revision is now accepted and ready to land.Fri, Jun 12, 9:29 AM

Closed by commit rFIREFOXAUTOLANDc3098e063b03: Bug 2046522 - "Account and sync" pane can appear empty when its sections are… (authored by akulyk, committed by agoloman). · Explain WhyFri, Jun 12, 9:29 AM

This revision was automatically updated to reflect the committed changes.

agoloman added a reverting change: rFIREFOXAUTOLANDcfbd12c2df45: Revert "Bug 2046522 - "Account and sync" pane can appear empty when its….

agoloman added a commit: rFIREFOXAUTOLANDc3098e063b03: Bug 2046522 - "Account and sync" pane can appear empty when its sections are….

akulyk mentioned this in rFIREFOXBETAcfd0670364c5: Bug 2046522 - "Account and sync" pane can appear empty when its sections are….Mon, Jun 15, 1:05 PM

akulyk mentioned this in rFIREFOXBETAbbf736719f5b: Bug 2046522 - "Account and sync" pane can appear empty when its sections are….

agoloman mentioned this in rFIREFOXBETA211f54d74e35: Bug 2046522 - "Account and sync" pane can appear empty when its sections are….Mon, Jun 15, 1:08 PM

agoloman mentioned this in rFIREFOXBETAc3098e063b03: Bug 2046522 - "Account and sync" pane can appear empty when its sections are….

Revision Contents
Changeset List

Path

Size

browser/

components/

preferences/

config/

account-sync.mjs

21 lines

preferences.js

1 line

tests/

searchResults/

browser_search_category_filter.js

2 lines

sync/

browser_account_sync_visibility.js

12 lines

locales/

en-US/

browser/

preferences/

preferences.ftl

4 lines

themes/

shared/

preferences/

preferences.css

4 lines

Commit	Tree	Parents	Author	Summary	Date
c3098e063b03	5e286f064654	Anna Kulyk	Bug 2046522 - "Account and sync" pane can appear empty when its sections are… (Show More…)

D306793 Bug 2043353 - Restore focus when navigating back in about:preferences r=#reusable-components-reviewers-rotation
·Reviewers: akulyk
Thu, Jun 18, 1:59 AM
Author: mkennedy
D307436 WIP: Bug 2048368: Pt.1 - Adding entry points for about:keyboard to Settings - Accessibility. r=Jamie!,settings-reviewers-rotation!
·No Reviewers
Wed, Jun 17, 11:43 PM
Author: ayeddi
D307437 WIP: Bug 2048368: Pt.2 - Adding entry points for about:keyboard to Settings - Tabs. r=Jamie!,settings-reviewers-rotation!
·No Reviewers
Wed, Jun 17, 11:24 PM
Author: ayeddi
D307400 Bug 2048359 - Add Resource Monitor New Tab widget r?maxx
·Reviewers: maxx, Restricted Project, desktop-theme-reviewers
Wed, Jun 17, 7:52 PM
Author: tthorne
D307405 Bug 2048359 - Add Resource Monitor New Tab widget r?maxx
·Reviewers: maxx, Restricted Project, desktop-theme-reviewers
Wed, Jun 17, 7:40 PM
Author: tthorne
D283460 Bug 1443042 - Add custom label to saved credit cards r?dlee,sgalich
·Reviewers: Restricted Project, desktop-theme-reviewers, flod, dimi
Wed, Jun 17, 11:00 AM
Author: TealStarsong
D307187 Bug 2048149 - Containers: update nova colors & styles
·Reviewers: desktop-theme-reviewers, fxview-reviewers, tabbrowser-reviewers, urlbar-reviewers, mstriemer, jsudiaman
Wed, Jun 17, 7:45 AM
Author: baku
D307071 Bug 2048020 - Containers: remove description in the about:preferences#containers for the '+' policy
·Reviewers: lesleynorton, Restricted Project, bolsson
Wed, Jun 17, 5:32 AM
Author: baku
D306883 Bug 2040000 - Add Back button to preferences search results header to restore keyboard navigation. r?#settings-reviewers
·Reviewers: Restricted Project, desktop-theme-reviewers, akulyk, bolsson
Wed, Jun 17, 3:01 AM
Author: tgiles
D306159 Bug 2043356 - Restore search in about:preferences when navigating back r=#reusable-components-reviewers-rotation
·Reviewers: mstriemer
Thu, Jun 11, 1:52 PM
Author: mkennedy

Diff 1298564

View Options

browser/components/preferences/config/account-sync.mjs

View Options

browser/components/preferences/preferences.js

View Options

browser/components/preferences/tests/searchResults/browser_search_category_filter.js

View Options

browser/components/preferences/tests/sync/browser_account_sync_visibility.js

View Options

browser/locales/en-US/browser/preferences/preferences.ftl

View Options

browser/themes/shared/preferences/preferences.css

Privacy · Cookies · Legal

URL: https://phabricator.services.mozilla.com/D306308

⇱ ⚙ D306308 Bug 2046522 - "Account and sync" pane can appear empty when its sections are disabled r=mstriemer

Bug 2046522 - "Account and sync" pane can appear empty when its sections are disabled r=mstriemer
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1298564

browser/components/preferences/config/account-sync.mjs

browser/components/preferences/preferences.js

browser/components/preferences/tests/searchResults/browser_search_category_filter.js

browser/components/preferences/tests/sync/browser_account_sync_visibility.js

browser/locales/en-US/browser/preferences/preferences.ftl

browser/themes/shared/preferences/preferences.css

URL: https://phabricator.services.mozilla.com/D306308

⇱ ⚙ D306308 Bug 2046522 - "Account and sync" pane can appear empty when its sections are disabled r=mstriemer

Bug 2046522 - "Account and sync" pane can appear empty when its sections are disabled r=mstriemerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1298564

browser/components/preferences/config/account-sync.mjs

browser/components/preferences/preferences.js

browser/components/preferences/tests/searchResults/browser_search_category_filter.js

browser/components/preferences/tests/sync/browser_account_sync_visibility.js

browser/locales/en-US/browser/preferences/preferences.ftl

browser/themes/shared/preferences/preferences.css

Bug 2046522 - "Account and sync" pane can appear empty when its sections are disabled r=mstriemer
ClosedPublic
Actions

Revision Contents
Changeset List